dasher r3604 - in trunk: . Src/DasherCore

[pwelche svn gnome org]

Author: pwelche
Date: Tue Dec 16 17:52:59 2008
New Revision: 3604
URL: http://svn.gnome.org/viewvc/dasher?rev=3604&view=rev

Log:
It seems we are maintaing two lists: modules and event listeners. All modules
listen => we are in danger of freeing the modules twice.


Modified:
   trunk/ChangeLog
   trunk/Src/DasherCore/ModuleManager.cpp

Modified: trunk/Src/DasherCore/ModuleManager.cpp
==============================================================================
--- trunk/Src/DasherCore/ModuleManager.cpp	(original)
+++ trunk/Src/DasherCore/ModuleManager.cpp	Tue Dec 16 17:52:59 2008
@@ -78,9 +78,14 @@
 }
 
 CModuleManager::~CModuleManager() {
+/* XXX PRLW: Modules are Components. Components are registered
+ * with an event handler on creation. When they are unregistered,
+ * they are deleted, so this part is not necessary. One question
+ * then is why are effectively maintaining two lists.
     for (ModuleID_t i = 0; i < m_vModules.size(); ++i) {
         delete m_vModules[i];
     }
+ */
 }
 
 CDasherModule *CModuleManager::GetDefaultInputDevice() {