perl-GStreamer r93 - in trunk: . t xs

[tsch svn gnome org]

Author: tsch
Date: Mon Dec 15 19:00:56 2008
New Revision: 93
URL: http://svn.gnome.org/viewvc/perl-GStreamer?rev=93&view=rev

Log:
Properly marshal the return values of gst_element_add_pad,
gst_element_remove_pad, and gst_element_set_locked_state.


Modified:
   trunk/ChangeLog
   trunk/t/GstElement.t
   trunk/xs/GstElement.xs

Modified: trunk/t/GstElement.t
==============================================================================
--- trunk/t/GstElement.t	(original)
+++ trunk/t/GstElement.t	Mon Dec 15 19:00:56 2008
@@ -1,7 +1,7 @@
 #!/usr/bin/perl
 use strict;
 use warnings;
-use Test::More tests => 36;
+use Test::More tests => 39;
 
 # $Id$
 
@@ -19,7 +19,7 @@
                                                             "alsasink", "tmp two");
 
 SKIP: {
-  skip 'failed to create alsa elements', 34
+  skip 'failed to create alsa elements', 37
     unless defined $tmp_one && defined $tmp_two;
 
   isa_ok($tmp_one, "GStreamer::Element");
@@ -60,16 +60,21 @@
 
   my $pad = GStreamer::Pad -> new("urgs", "src");
 
-  $element -> add_pad($pad);
+  ok($element -> add_pad($pad));
 
   is($element -> get_pad("urgs"), $pad);
   is($element -> get_static_pad("urgs"), $pad);
   is($element -> get_request_pad("urgs"), undef);
 
   my $caps = GStreamer::Caps::Any -> new();
-  isa_ok($element -> get_compatible_pad($pad, $caps), "GStreamer::Pad");
+  my $compatible_pad = $element -> get_compatible_pad($pad, $caps);
+  SKIP: {
+    skip 'get_compatible_pad returned undef', 1
+      unless defined $compatible_pad;
+    isa_ok($compatible_pad, "GStreamer::Pad");
+  }
 
-  $element -> remove_pad($pad);
+  ok($element -> remove_pad($pad));
 
   isa_ok($element -> iterate_pads(), "GStreamer::Iterator");
   isa_ok($element -> iterate_src_pads(), "GStreamer::Iterator");
@@ -119,7 +124,7 @@
   $element_one -> found_tags($test_tags);
   $element_one -> found_tags_for_pad($pad_one, $test_tags);
 
-  $element -> set_locked_state(TRUE);
+  ok($element -> set_locked_state(TRUE));
   ok($element -> is_locked_state());
   ok(!$element -> sync_state_with_parent());
 

Modified: trunk/xs/GstElement.xs
==============================================================================
--- trunk/xs/GstElement.xs	(original)
+++ trunk/xs/GstElement.xs	Mon Dec 15 19:00:56 2008
@@ -55,9 +55,9 @@
 
 GstBus_ornull * gst_element_get_bus (GstElement * element);
 
-void gst_element_add_pad (GstElement *element, GstPad *pad);
+gboolean gst_element_add_pad (GstElement *element, GstPad *pad);
 
-void gst_element_remove_pad (GstElement *element, GstPad *pad);
+gboolean gst_element_remove_pad (GstElement *element, GstPad *pad);
 
 GstPad_ornull * gst_element_get_pad (GstElement *element, const gchar *name);
 
@@ -169,7 +169,7 @@
 
 gboolean gst_element_is_locked_state (GstElement *element);
 
-void gst_element_set_locked_state (GstElement *element, gboolean locked_state);
+gboolean gst_element_set_locked_state (GstElement *element, gboolean locked_state);
 
 gboolean gst_element_sync_state_with_parent (GstElement *element);