gnome-subtitles r1098 - in trunk/src: Glade GnomeSubtitles/Dialog

[pcastro svn gnome org]

Author: pcastro
Date: Thu Dec 11 23:10:17 2008
New Revision: 1098
URL: http://svn.gnome.org/viewvc/gnome-subtitles?rev=1098&view=rev

Log:
Don't user border in the Clear button.
Don't proceed to shift if the value is zero.
Code cleanup.



Modified:
   trunk/src/Glade/TimingsShiftDialog.glade
   trunk/src/GnomeSubtitles/Dialog/TimingsShiftDialog.cs

Modified: trunk/src/Glade/TimingsShiftDialog.glade
==============================================================================
--- trunk/src/Glade/TimingsShiftDialog.glade	(original)
+++ trunk/src/Glade/TimingsShiftDialog.glade	Thu Dec 11 23:10:17 2008
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8" standalone="no"?>
 <!DOCTYPE glade-interface SYSTEM "glade-2.0.dtd">
-<!--Generated with glade3 3.4.5 on Sun Nov 16 00:29:57 2008 
+<!--Generated with glade3 3.4.5 on Thu Dec 11 23:05:43 2008 
 	Version: 3.0.1
 	Date: Thu Dec  7 16:42:10 2006
 	User: noup
@@ -36,7 +36,7 @@
                 <child>
                   <widget class="GtkHBox" id="alignmentHBox">
                     <property name="visible">True</property>
-                    <property name="spacing">10</property>
+                    <property name="spacing">4</property>
                     <child>
                       <widget class="GtkSpinButton" id="spinButton">
                         <property name="visible">True</property>
@@ -48,10 +48,15 @@
                         <property name="climb_rate">1</property>
                         <property name="numeric">True</property>
                       </widget>
+                      <packing>
+                        <property name="expand">False</property>
+                        <property name="fill">False</property>
+                      </packing>
                     </child>
                     <child>
                       <widget class="GtkButton" id="clearButton">
                         <property name="visible">True</property>
+                        <property name="relief">GTK_RELIEF_NONE</property>
                         <property name="response_id">0</property>
                         <signal name="clicked" handler="OnClear"/>
                         <child>

Modified: trunk/src/GnomeSubtitles/Dialog/TimingsShiftDialog.cs
==============================================================================
--- trunk/src/GnomeSubtitles/Dialog/TimingsShiftDialog.cs	(original)
+++ trunk/src/GnomeSubtitles/Dialog/TimingsShiftDialog.cs	Thu Dec 11 23:10:17 2008
@@ -133,11 +133,11 @@
 	}
 	
 	private void OnResponse (object o, ResponseArgs args) {
-		if (args.ResponseId == ResponseType.Ok) {
+		if ((args.ResponseId == ResponseType.Ok) && (spinButton.Value != 0)) {
 			SelectionIntended selectionIntended = GetSelectionIntended();
 			
 			if (timingMode == TimingMode.Times) {
-				TimeSpan time = TimeSpan.Parse(spinButton.Text); //TODO use value that holds milliseconds
+				TimeSpan time = TimeSpan.FromMilliseconds(spinButton.Value);
 				Base.CommandManager.Execute(new ShiftTimingsCommand(time, selectionIntended));
 			}
 			else {