gtkhtml r9065 - trunk/components/editor



Author: mbarnes
Date: Thu Dec 11 14:32:39 2008
New Revision: 9065
URL: http://svn.gnome.org/viewvc/gtkhtml?rev=9065&view=rev

Log:
2008-12-11  Matthew Barnes  <mbarnes redhat com>

	** Supplements bug #553995

	* gtkhtml-editor.c (gtkhtml_editor_set_changed):
	Add a comment explaining why.



Modified:
   trunk/components/editor/ChangeLog
   trunk/components/editor/gtkhtml-editor.c

Modified: trunk/components/editor/gtkhtml-editor.c
==============================================================================
--- trunk/components/editor/gtkhtml-editor.c	(original)
+++ trunk/components/editor/gtkhtml-editor.c	Thu Dec 11 14:32:39 2008
@@ -1042,6 +1042,13 @@
 
 	if (!changed) {
 		html = gtkhtml_editor_get_html (editor);
+
+		/* XXX The NULL check was added to deal with a race in
+		 *     Evolution when saving a message to a remote Drafts
+		 *     folder (which is asynchronous) and then closing the
+		 *     editor (which is immediate).  The GtkHTML object
+		 *     may already be disposed by the time the Save Draft
+		 *     callback gets here.  See bug #553995 for details. */
 		if (html)
 			html_engine_saved (html->engine);
 	}



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]