gnumeric r16992 - in trunk: . src test

[mortenw svn gnome org]

Author: mortenw
Date: Mon Dec  8 18:20:28 2008
New Revision: 16992
URL: http://svn.gnome.org/viewvc/gnumeric?rev=16992&view=rev

Log:
2008-12-08  Morten Welinder  <terra gnome org>

	* src/gnumeric-gconf.c (gnm_conf_shutdown): Plug leaks.

2008-12-08  Morten Welinder  <terra gnome org>

	* test/GnumericTest.pm (test_valgrind): Set resident-modules too.

	* common.supp: Add a few more variants for OpenSuSE 11.  Valgrind
	needs to get that "..." enhancement distributed.




Modified:
   trunk/ChangeLog
   trunk/src/gnumeric-gconf.c
   trunk/test/ChangeLog
   trunk/test/GnumericTest.pm
   trunk/test/common.supp

Modified: trunk/src/gnumeric-gconf.c
==============================================================================
--- trunk/src/gnumeric-gconf.c	(original)
+++ trunk/src/gnumeric-gconf.c	Mon Dec  8 18:20:28 2008
@@ -384,6 +384,12 @@
 	if (prefs.printer_decoration_font)
 		gnm_style_unref (prefs.printer_decoration_font);
 
+	go_slist_free_custom ((GSList *)prefs.printer_header, g_free);
+	go_slist_free_custom ((GSList *)prefs.printer_header_formats_left, g_free);
+	go_slist_free_custom ((GSList *)prefs.printer_header_formats_middle, g_free);
+	go_slist_free_custom ((GSList *)prefs.printer_header_formats_right, g_free);
+	go_slist_free_custom ((GSList *)prefs.printer_footer, g_free);
+
 	g_hash_table_destroy (prefs.toolbars);
 	g_hash_table_destroy (prefs.toolbar_positions);
 
@@ -403,6 +409,11 @@
 	 * people for doing stupid things */
 	go_slist_free_custom ((GSList *)prefs.recent_funcs, g_free);
 
+	go_slist_free_custom ((GSList *)prefs.plugin_extra_dirs, g_free);
+	go_slist_free_custom ((GSList *)prefs.active_plugins, g_free);
+
+	go_slist_free_custom ((GSList *)prefs.autoformat.extra_dirs, g_free);
+
 	g_free (prefs.print_repeat_top);
 	g_free (prefs.print_repeat_left);
 
@@ -496,6 +507,7 @@
 		 gtk_page_setup_get_right_margin (setup, GTK_UNIT_POINTS));
 }
 
+/* Note: takes ownership of argument.  */
 void
 gnm_gconf_set_plugin_file_states (GSList *list)
 {
@@ -510,6 +522,7 @@
 	go_conf_set_str_list (root, PLUGIN_GCONF_DIR "/" PLUGIN_GCONF_FILE_STATES, list);
 }
 
+/* Note: takes ownership of argument.  */
 void
 gnm_gconf_set_plugin_extra_dirs (GSList *list)
 {
@@ -523,6 +536,7 @@
 	go_conf_set_str_list (root, PLUGIN_GCONF_DIR "/" PLUGIN_GCONF_EXTRA_DIRS, list);
 }
 
+/* Note: argument is unchanged.  */
 void
 gnm_gconf_set_active_plugins (GSList *list)
 {
@@ -535,6 +549,7 @@
 	go_conf_set_bool (root, PLUGIN_GCONF_DIR "/" PLUGIN_GCONF_ACTIVATE_NEW, val);
 }
 
+/* Note: takes ownership of argument.  */
 void
 gnm_gconf_set_recent_funcs (GSList *list)
 {

Modified: trunk/test/GnumericTest.pm
==============================================================================
--- trunk/test/GnumericTest.pm	(original)
+++ trunk/test/GnumericTest.pm	Mon Dec  8 18:20:28 2008
@@ -251,7 +251,7 @@
     my ($cmd,$uselibtool) = @_;
 
     local %ENV;
-    $ENV{'G_DEBUG'} .= ':gc-friendly';
+    $ENV{'G_DEBUG'} .= ':gc-friendly:resident-modules';
     $ENV{'G_SLICE'} = 'always-malloc';
     delete $ENV{'VALGRIND_OPTS'};
 

Modified: trunk/test/common.supp
==============================================================================
--- trunk/test/common.supp	(original)
+++ trunk/test/common.supp	Mon Dec  8 18:20:28 2008
@@ -15,6 +15,20 @@
 }
 
 {
+   ORBit_gconf_ping_writev_i686_v2
+   Memcheck:Param
+   writev(vector[...])
+   fun:*
+   fun:*
+   fun:link_connection_writev
+   fun:giop_send_buffer_write
+   fun:*
+   fun:ORBit_small_invoke_stub
+   fun:ConfigServer_ping
+   fun:gconf_activate_server
+}
+
+{
    ORBit_gconf_ping_writev_i686_sym
    Memcheck:Param
    writev(vector[...])
@@ -278,6 +292,16 @@
 }
 
 {
+   Leak/gtk_page_setup_copy2
+   Memcheck:Leak
+   fun:malloc
+   fun:g_malloc
+   fun:g_slice_alloc
+   fun:g_slice_alloc0
+   fun:gtk_paper_size_new
+}
+
+{
    Leak/font-config/FcStrCopy
    Memcheck:Leak
    fun:malloc