rhythmbox r6093 - in trunk: . plugins



Author: jmatthew
Date: Sat Dec  6 22:27:36 2008
New Revision: 6093
URL: http://svn.gnome.org/viewvc/rhythmbox?rev=6093&view=rev

Log:
2008-12-07  Jonathan Matthew  <jonathan d14n org>

	* plugins/rb-plugin-manager.c: (cursor_changed_cb):
	Don't crash if the plugin's .rb-plugin file doesn't list any authors.
	Fixes #563476.


Modified:
   trunk/ChangeLog
   trunk/plugins/rb-plugin-manager.c

Modified: trunk/plugins/rb-plugin-manager.c
==============================================================================
--- trunk/plugins/rb-plugin-manager.c	(original)
+++ trunk/plugins/rb-plugin-manager.c	Sat Dec  6 22:27:36 2008
@@ -168,6 +168,7 @@
 	RBPluginInfo *info;
 	char *string;
 	GdkPixbuf *icon;
+	const gchar **authors;
 
 	view = gtk_tree_selection_get_tree_view (selection);
 	info = plugin_manager_get_selected_plugin (pm);
@@ -187,9 +188,14 @@
 	gtk_label_set_text (GTK_LABEL (pm->priv->site_text),
 			    rb_plugins_engine_get_plugin_website (info));
 
-	string = g_strjoinv ("\n", (gchar**)rb_plugins_engine_get_plugin_authors (info));
-	gtk_label_set_text (GTK_LABEL (pm->priv->authors_text), string);
-	g_free (string);
+	authors = rb_plugins_engine_get_plugin_authors (info);
+	if (authors != NULL) {
+		string = g_strjoinv ("\n", (gchar **)authors);
+		gtk_label_set_text (GTK_LABEL (pm->priv->authors_text), string);
+		g_free (string);
+	} else {
+		gtk_label_set_text (GTK_LABEL (pm->priv->authors_text), NULL);
+	}
 
 	icon = rb_plugins_engine_get_plugin_icon (info);
 	if (icon != NULL) {



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]