gedit r6648 - in trunk: . gedit



Author: pborelli
Date: Mon Dec  1 22:58:06 2008
New Revision: 6648
URL: http://svn.gnome.org/viewvc/gedit?rev=6648&view=rev

Log:
fix a couple of refcounting problems spotted with refdbg, but this does not solve the py refcounting issue


Modified:
   trunk/ChangeLog
   trunk/gedit/gedit-documents-panel.c
   trunk/gedit/gedit-window.c

Modified: trunk/gedit/gedit-documents-panel.c
==============================================================================
--- trunk/gedit/gedit-documents-panel.c	(original)
+++ trunk/gedit/gedit-documents-panel.c	Mon Dec  1 22:58:06 2008
@@ -352,7 +352,7 @@
 	g_return_if_fail (panel->priv->window == NULL);
 	g_return_if_fail (GEDIT_IS_WINDOW (window));
 
-	panel->priv->window = window;
+	panel->priv->window = g_object_ref (window);
 
 	g_signal_connect (window,
 			  "tab_added",
@@ -449,12 +449,26 @@
 	G_OBJECT_CLASS (gedit_documents_panel_parent_class)->finalize (object);
 }
 
+static void
+gedit_documents_panel_dispose (GObject *object)
+{
+	GeditDocumentsPanel *panel = GEDIT_DOCUMENTS_PANEL (object);
+
+	if (panel->priv->window != NULL) {
+		g_object_unref (panel->priv->window);
+		panel->priv->window = NULL;
+	}
+
+	G_OBJECT_CLASS (gedit_documents_panel_parent_class)->dispose (object);
+}
+
 static void 
 gedit_documents_panel_class_init (GeditDocumentsPanelClass *klass)
 {
 	GObjectClass *object_class = G_OBJECT_CLASS (klass);
 
 	object_class->finalize = gedit_documents_panel_finalize;
+	object_class->dispose = gedit_documents_panel_dispose;
 	object_class->get_property = gedit_documents_panel_get_property;
 	object_class->set_property = gedit_documents_panel_set_property;
 

Modified: trunk/gedit/gedit-window.c
==============================================================================
--- trunk/gedit/gedit-window.c	(original)
+++ trunk/gedit/gedit-window.c	Mon Dec  1 22:58:06 2008
@@ -1270,6 +1270,7 @@
 
 		gtk_action_group_add_action (p->recents_action_group,
 					     action);
+		g_object_unref (action);
 
 		gtk_ui_manager_add_ui (p->manager,
 				       p->recents_menu_ui_id,



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]