gedit r6643 - in trunk: . plugins/filebrowser plugins/spell



Author: pborelli
Date: Mon Dec  1 10:25:59 2008
New Revision: 6643
URL: http://svn.gnome.org/viewvc/gedit?rev=6643&view=rev

Log:
2008-12-01  Paolo Borelli  <pborelli katamail com>

	* plugins/filebrowser/gedit-file-browser-store.c:
	* plugins/spell/gedit-spell-plugin.c:
	* plugins/spell/gedit-automatic-spell-checker.c:
	Do not use g_quark_from_static_string, it should not be used in
	loadable modules.



Modified:
   trunk/ChangeLog
   trunk/plugins/filebrowser/gedit-file-browser-store.c
   trunk/plugins/spell/gedit-automatic-spell-checker.c
   trunk/plugins/spell/gedit-spell-plugin.c

Modified: trunk/plugins/filebrowser/gedit-file-browser-store.c
==============================================================================
--- trunk/plugins/filebrowser/gedit-file-browser-store.c	(original)
+++ trunk/plugins/filebrowser/gedit-file-browser-store.c	Mon Dec  1 10:25:59 2008
@@ -2588,10 +2588,9 @@
 {
 	static GQuark quark = 0;
 
-	if (G_UNLIKELY (quark == 0))
-		quark =
-		    g_quark_from_static_string
-		    ("gedit_file_browser_store_error");
+	if (G_UNLIKELY (quark == 0)) {
+		quark = g_quark_from_string ("gedit_file_browser_store_error");
+	}
 
 	return quark;
 }

Modified: trunk/plugins/spell/gedit-automatic-spell-checker.c
==============================================================================
--- trunk/plugins/spell/gedit-automatic-spell-checker.c	(original)
+++ trunk/plugins/spell/gedit-automatic-spell-checker.c	Mon Dec  1 10:25:59 2008
@@ -707,12 +707,13 @@
 	spell->doc = doc;
 	spell->spell_checker = g_object_ref (checker);
 
-	if (automatic_spell_checker_id == 0)
+	if (automatic_spell_checker_id == 0) {
 		automatic_spell_checker_id = 
-			g_quark_from_static_string ("GeditAutomaticSpellCheckerID");
-	if (suggestion_id == 0)
-		suggestion_id = 
-			g_quark_from_static_string ("GeditAutoSuggestionID");
+			g_quark_from_string ("GeditAutomaticSpellCheckerID");
+	}
+	if (suggestion_id == 0) {
+		suggestion_id = g_quark_from_string ("GeditAutoSuggestionID");
+	}
 
 	g_object_set_qdata_full (G_OBJECT (doc), 
 				 automatic_spell_checker_id, 

Modified: trunk/plugins/spell/gedit-spell-plugin.c
==============================================================================
--- trunk/plugins/spell/gedit-spell-plugin.c	(original)
+++ trunk/plugins/spell/gedit-spell-plugin.c	Mon Dec  1 10:25:59 2008
@@ -996,8 +996,8 @@
 	plugin_class->update_ui = impl_update_ui;
 
 	if (spell_checker_id == 0)
-		spell_checker_id = g_quark_from_static_string ("GeditSpellCheckerID");
-	
+		spell_checker_id = g_quark_from_string ("GeditSpellCheckerID");
+
 	if (check_range_id == 0)
-		check_range_id = g_quark_from_static_string ("CheckRangeID");
+		check_range_id = g_quark_from_string ("CheckRangeID");
 }



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]