gnome-terminal r3004 - trunk/src



Author: chpe
Date: Mon Aug 25 15:58:47 2008
New Revision: 3004
URL: http://svn.gnome.org/viewvc/gnome-terminal?rev=3004&view=rev

Log:
Bug 549308 â gnome-terminal crashed with SIGSEGV in free()
Don't try to g_strfreev something we don't own.

Modified:
   trunk/src/terminal-window.c

Modified: trunk/src/terminal-window.c
==============================================================================
--- trunk/src/terminal-window.c	(original)
+++ trunk/src/terminal-window.c	Mon Aug 25 15:58:47 2008
@@ -2689,7 +2689,7 @@
 
 static void
 clipboard_uris_received_cb (GtkClipboard *clipboard,
-                            char **uris,
+                            /* const */ char **uris,
                             PasteData *data)
 {
   char *text;
@@ -2701,6 +2701,7 @@
     return;
   }
 
+  /* This potentially modifies the strings in |uris| but that's ok */
   if (data->uris_as_paths)
     terminal_util_transform_uris_to_quoted_fuse_paths (uris);
 
@@ -2708,8 +2709,6 @@
   vte_terminal_feed_child (VTE_TERMINAL (data->screen), text, len);
   g_free (text);
 
-  g_strfreev (uris);
-
   g_object_unref (data->screen);
   g_slice_free (PasteData, data);
 }



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]