libsoup r1152 - in trunk: . libsoup

[danw svn gnome org]

Author: danw
Date: Thu Aug 14 14:38:21 2008
New Revision: 1152
URL: http://svn.gnome.org/viewvc/libsoup?rev=1152&view=rev

Log:
	* libsoup/soup-auth.c (soup_auth_authenticate): g_return_if_fail
	if either username or password is NULL. Noted on the mailing list.

	* libsoup/soup-auth-basic.c (authenticate): remove redundant check


Modified:
   trunk/ChangeLog
   trunk/libsoup/soup-auth-basic.c
   trunk/libsoup/soup-auth.c

Modified: trunk/libsoup/soup-auth-basic.c
==============================================================================
--- trunk/libsoup/soup-auth-basic.c	(original)
+++ trunk/libsoup/soup-auth-basic.c	Thu Aug 14 14:38:21 2008
@@ -106,9 +106,6 @@
 	char *user_pass;
 	int len;
 
-	g_return_if_fail (username != NULL);
-	g_return_if_fail (password != NULL);
-
 	user_pass = g_strdup_printf ("%s:%s", username, password);
 	len = strlen (user_pass);
 

Modified: trunk/libsoup/soup-auth.c
==============================================================================
--- trunk/libsoup/soup-auth.c	(original)
+++ trunk/libsoup/soup-auth.c	Thu Aug 14 14:38:21 2008
@@ -302,7 +302,8 @@
 	gboolean was_authenticated;
 
 	g_return_if_fail (SOUP_IS_AUTH (auth));
-	g_return_if_fail (username != NULL || password == NULL);
+	g_return_if_fail (username != NULL);
+	g_return_if_fail (password != NULL);
 
 	was_authenticated = soup_auth_is_authenticated (auth);
 	SOUP_AUTH_GET_CLASS (auth)->authenticate (auth, username, password);