banshee r3838 - in trunk/banshee: . src/Core/Banshee.Services/Banshee.MediaEngine

[gburt svn gnome org]

Author: gburt
Date: Mon Apr 28 22:04:29 2008
New Revision: 3838
URL: http://svn.gnome.org/viewvc/banshee?rev=3838&view=rev

Log:
2008-04-28  Gabriel Burt  <gabriel burt gmail com>

	* src/Core/Banshee.Services/Banshee.MediaEngine/PlayerEngineService.cs:
	Fix bug with incrementing skip count instead of play count when a song
	ended and the next one began (behavior was correct if the song hadn't
	ended and the user manually pressed next.)  Fixes BGO #527879.


Modified:
   trunk/banshee/ChangeLog
   trunk/banshee/src/Core/Banshee.Services/Banshee.MediaEngine/PlayerEngineService.cs

Modified: trunk/banshee/src/Core/Banshee.Services/Banshee.MediaEngine/PlayerEngineService.cs
==============================================================================
--- trunk/banshee/src/Core/Banshee.Services/Banshee.MediaEngine/PlayerEngineService.cs	(original)
+++ trunk/banshee/src/Core/Banshee.Services/Banshee.MediaEngine/PlayerEngineService.cs	Mon Apr 28 22:04:29 2008
@@ -334,7 +334,8 @@
         {
             if (!incremented_last_played && active_engine.CurrentTrack != null) {
                 // If we're at least 50% done playing a song, mark it as played, otherwise as skipped
-                if (active_engine.Length > 0 && active_engine.Position >= active_engine.Length / 2) {
+                // If the Length <= 0, assume the song was finished and increment its play count
+                if (active_engine.Length <= 0 || active_engine.Position >= active_engine.Length / 2) {
                     active_engine.CurrentTrack.IncrementPlayCount ();
                 } else {
                     active_engine.CurrentTrack.IncrementSkipCount ();