gdm r6145 - in trunk: . daemon



Author: halfline
Date: Fri Apr 11 20:09:25 2008
New Revision: 6145
URL: http://svn.gnome.org/viewvc/gdm?rev=6145&view=rev

Log:
2008-04-11  Ray Strode <rstrode redhat com>

	* daemon/gdm-session-worker.c
	(_change_user): Don't setreuid to user before setcred since
	even though it's documented that you should, modules break if
	you do


Modified:
   trunk/ChangeLog
   trunk/daemon/gdm-session-worker.c

Modified: trunk/daemon/gdm-session-worker.c
==============================================================================
--- trunk/daemon/gdm-session-worker.c	(original)
+++ trunk/daemon/gdm-session-worker.c	Fri Apr 11 20:09:25 2008
@@ -1165,6 +1165,7 @@
 
         ret = FALSE;
 
+#ifdef THE_MAN_PAGE_ISNT_LYING
         /* pam_setcred wants to be called as the authenticated user
          * but pam_open_session needs to be called as super-user.
          *
@@ -1174,6 +1175,7 @@
         if (setreuid (uid, GDM_SESSION_ROOT_UID) < 0) {
                 return FALSE;
         }
+#endif
 
         if (setgid (gid) < 0) {
                 return FALSE;



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]