empathy r888 - trunk/libempathy



Author: xclaesse
Date: Fri Apr 11 14:10:22 2008
New Revision: 888
URL: http://svn.gnome.org/viewvc/empathy?rev=888&view=rev

Log:
Make use of mission_control_get_tpconnection()


Modified:
   trunk/libempathy/empathy-tp-chat.c
   trunk/libempathy/empathy-tp-contact-factory.c

Modified: trunk/libempathy/empathy-tp-chat.c
==============================================================================
--- trunk/libempathy/empathy-tp-chat.c	(original)
+++ trunk/libempathy/empathy-tp-chat.c	Fri Apr 11 14:10:22 2008
@@ -101,15 +101,7 @@
 			gchar         *message,
 			EmpathyTpChat *chat)
 {
-	EmpathyTpChatPriv *priv = GET_PRIV (chat);
-
 	empathy_debug (DEBUG_DOMAIN, "Channel invalidated: %s", message);
-
-	g_object_unref (priv->channel);
-	g_object_unref (priv->tp_chan);
-	priv->channel = NULL;
-	priv->tp_chan = NULL;
-
 	g_signal_emit (chat, signals[DESTROY], 0);
 }
 
@@ -921,7 +913,6 @@
 	object_class->get_property = tp_chat_get_property;
 	object_class->set_property = tp_chat_set_property;
 
-	/* Construct properties */
 	g_object_class_install_property (object_class,
 					 PROP_ACCOUNT,
 					 g_param_spec_object ("account",
@@ -954,6 +945,7 @@
 							       FALSE,
 							       G_PARAM_READWRITE |
 							       G_PARAM_CONSTRUCT));
+
 	g_object_class_install_property (object_class,
 					 PROP_REMOTE_CONTACT,
 					 g_param_spec_object ("remote-contact",
@@ -965,7 +957,7 @@
 					 PROP_READY,
 					 g_param_spec_boolean ("ready",
 							       "Is the object ready",
-							       "This object is can't be used until this becomes true",
+							       "This object can't be used until this becomes true",
 							       FALSE,
 							       G_PARAM_READABLE));
 
@@ -1045,11 +1037,9 @@
 	TpChannel      *channel;
 	TpConnection   *connection;
 	MissionControl *mc;
-	TpConn         *tp_conn;
 
 	mc = empathy_mission_control_new ();
-	tp_conn = mission_control_get_connection (mc, account, NULL);
-	connection = tp_conn_dup_connection (tp_conn);
+	connection = mission_control_get_tpconnection (mc, account, NULL);
 	channel = tp_chan_dup_channel (tp_chan, connection, NULL);
 
 	chat = g_object_new (EMPATHY_TYPE_TP_CHAT, 
@@ -1060,7 +1050,6 @@
 			     NULL);
 
 	g_object_unref (channel);
-	g_object_unref (tp_conn);
 	g_object_unref (connection);
 	g_object_unref (mc);
 

Modified: trunk/libempathy/empathy-tp-contact-factory.c
==============================================================================
--- trunk/libempathy/empathy-tp-contact-factory.c	(original)
+++ trunk/libempathy/empathy-tp-contact-factory.c	Fri Apr 11 14:10:22 2008
@@ -833,7 +833,6 @@
 tp_contact_factory_status_updated (EmpathyTpContactFactory *tp_factory)
 {
 	EmpathyTpContactFactoryPriv *priv = GET_PRIV (tp_factory);
-	TpConn                      *tp_conn;
 	gboolean                     connection_ready;
 
 	if (priv->connection) {
@@ -841,15 +840,12 @@
 		return;
 	}
 
-	tp_conn = mission_control_get_connection (priv->mc, priv->account, NULL);
-	if (!tp_conn) {
+	priv->connection = mission_control_get_tpconnection (priv->mc, priv->account, NULL);
+	if (!priv->connection) {
 		return;
 	}
 
 	/* We got a new connection, wait for it to be ready */
-	priv->connection = tp_conn_dup_connection (tp_conn);
-	g_object_unref (tp_conn);
-
 	g_signal_connect_swapped (priv->connection, "invalidated",
 				  G_CALLBACK (tp_contact_factory_connection_invalidated_cb),
 				  tp_factory);



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]