libgda r3127 - in branches/libgda-3-2: . providers/postgres

[murrayc svn gnome org]

Author: murrayc
Date: Mon Apr  7 14:54:36 2008
New Revision: 3127
URL: http://svn.gnome.org/viewvc/libgda?rev=3127&view=rev

Log:
2008-04-07  Murray Cumming  <murrayc murrayc com>

* providers/postgres/gda-postgres-provider.c (fetch_existing_blobs):
Added a comment about a possible leak reported by valgrind.

Modified:
   branches/libgda-3-2/ChangeLog
   branches/libgda-3-2/providers/postgres/gda-postgres-provider.c

Modified: branches/libgda-3-2/providers/postgres/gda-postgres-provider.c
==============================================================================
--- branches/libgda-3-2/providers/postgres/gda-postgres-provider.c	(original)
+++ branches/libgda-3-2/providers/postgres/gda-postgres-provider.c	Mon Apr  7 14:54:36 2008
@@ -1244,9 +1244,12 @@
 				g_object_unref (plist);
 			g_object_unref (select);
 			if (!sql || !*sql) {
+				/* TODO: valgrind reports this as a definite leak, 
+				 * but I can't see how. murrayc:
+				 */
 				gchar *msg = g_strdup_printf (_("Could not render SQL for SELECT "
 								"query to fetch existing BLOB values: %s"), 
-							      error && error->message ? 
+							      (error && error->message) ? 
 							      error->message : _("No detail"));
 				gda_connection_add_event_string (cnc, msg);
 				g_error_free (error);