totem r5332 - in trunk: . src/backend

[hadess svn gnome org]

Author: hadess
Date: Thu Apr  3 14:06:17 2008
New Revision: 5332
URL: http://svn.gnome.org/viewvc/totem?rev=5332&view=rev

Log:
2008-04-03  Bastien Nocera  <hadess hadess net>

        * src/backend/bacon-video-widget-gst-0.10.c
	(bvw_update_interface_implementations):
	Fix unreffing a non-reffed element, fixes warnings
	when ximagesink is forced (Closes: #524807)
	Patch from Sjoerd Simons <sjoerd luon net>



Modified:
   trunk/ChangeLog
   trunk/src/backend/bacon-video-widget-gst-0.10.c

Modified: trunk/src/backend/bacon-video-widget-gst-0.10.c
==============================================================================
--- trunk/src/backend/bacon-video-widget-gst-0.10.c	(original)
+++ trunk/src/backend/bacon-video-widget-gst-0.10.c	Thu Apr  3 14:06:17 2008
@@ -4875,7 +4875,7 @@
     element = gst_bin_get_by_interface (GST_BIN (video_sink),
                                         GST_TYPE_X_OVERLAY);
   } else {
-    element = video_sink;
+    element = gst_object_ref(video_sink);
   }
 
   if (GST_IS_X_OVERLAY (element)) {
@@ -4883,6 +4883,7 @@
     bvw->priv->xoverlay = GST_X_OVERLAY (element);
   } else {
     GST_DEBUG ("No xoverlay found");
+    gst_object_unref (element);
     bvw->priv->xoverlay = NULL;
   }