gdm2 r5360 - in branches/mccann-gobject: . common daemon gui/simple-chooser

[mccann svn gnome org]

Author: mccann
Date: 2007-10-15 15:20:43 +0100 (Mon, 15 Oct 2007)
New Revision: 5360
ViewCVS link: http://svn.gnome.org/viewcvs/gdm2?rev=5360&view=rev

Modified:
   branches/mccann-gobject/ChangeLog
   branches/mccann-gobject/common/gdm-address.c
   branches/mccann-gobject/common/gdm-address.h
   branches/mccann-gobject/daemon/gdm-xdmcp-display-factory.c
   branches/mccann-gobject/gui/simple-chooser/gdm-host-chooser-widget.c
Log:
2007-10-15  William Jon McCann  <mccann jhu edu>

	* common/gdm-address.c: (gdm_address_new_from_sockaddr),
	(gdm_address_peek_local_list):
	* common/gdm-address.h:
	* daemon/gdm-xdmcp-display-factory.c: (do_bind),
	(create_address_from_request), (decode_packet):
	* gui/simple-chooser/gdm-host-chooser-widget.c: (decode_packet),
	(find_broadcast_addresses), (add_hosts):
	The function gdm_address_new_from_sockaddr_storage gets called in a
	few places with socket addresses that aren't necessary
	sockaddr_storage bytes big (all the places that call getaddrinfo).
	This results in the memdup call in that function potentially copying
	out of bounds bytes.
	Patch from: Ray Strode <halfline gmail com>