[Notes] [Git][BuildStream/buildstream][valentindavid/wrong_type_in_status_code] Fix type of error codes in CAS server

[Valentin David <gitlab mg gitlab com>]

Title: GitLab

Valentin David pushed to branch valentindavid/wrong_type_in_status_code at BuildStream / buildstream

Commits:

• d88302e8
  by Valentin David at 2019-01-23T12:50:50Z

  Fix type of error codes in CAS server
  
  Fixes #882.
  

1 changed file:

• buildstream/_cas/casserver.py

Changes:

buildstream/_cas/casserver.py

---

...	...	@@ -293,12 +293,12 @@ class _ContentAddressableStorageServicer(remote_execution_pb2_grpc.ContentAddres
293	293	try:
294	294	with open(self.cas.objpath(digest), 'rb') as f:
295	295	if os.fstat(f.fileno()).st_size != digest.size_bytes:
296		- blob_response.status.code = code_pb2.NOT_FOUND
	296	+ blob_response.status.code = code_pb2.NOT_FOUND.value[0]
297	297	continue
298	298
299	299	blob_response.data = f.read(digest.size_bytes)
300	300	except FileNotFoundError:
301		- blob_response.status.code = code_pb2.NOT_FOUND
	301	+ blob_response.status.code = code_pb2.NOT_FOUND.value[0]
302	302
303	303	return response
304	304
...	...	@@ -324,7 +324,7 @@ class _ContentAddressableStorageServicer(remote_execution_pb2_grpc.ContentAddres
324	324	blob_response.digest.size_bytes = digest.size_bytes
325	325
326	326	if len(blob_request.data) != digest.size_bytes:
327		- blob_response.status.code = grpc.StatusCode.FAILED_PRECONDITION
	327	+ blob_response.status.code = code_pb2.FAILED_PRECONDITION.value[0]
328	328	continue
329	329
330	330	try:
...	...	@@ -335,10 +335,10 @@ class _ContentAddressableStorageServicer(remote_execution_pb2_grpc.ContentAddres
335	335	out.flush()
336	336	server_digest = self.cas.add_object(path=out.name)
337	337	if server_digest.hash != digest.hash:
338		- blob_response.status.code = grpc.StatusCode.FAILED_PRECONDITION
	338	+ blob_response.status.code = code_pb2.FAILED_PRECONDITION.value[0]
339	339
340	340	except ArtifactTooLargeException:
341		- blob_response.status.code = grpc.StatusCode.RESOURCE_EXHAUSTED
	341	+ blob_response.status.code = code_pb2.RESOURCE_EXHAUSTED.value[0]
342	342
343	343	return response
344	344

—
View it on GitLab.
You're receiving this email because of your account on gitlab.com. If you'd like to receive fewer emails, you can adjust your notification settings.