[Notes] [Git][BuildStream/buildstream][master] 2 commits: tests/testutils/python_repo.py: Use subprocess to run sdist

[Tristan Van Berkom <gitlab mg gitlab com>]

Title: GitLab

Tristan Van Berkom pushed to branch master at BuildStream / buildstream

Commits:

• adfb9291
  by Tristan Van Berkom at 2019-01-18T21:23:05Z

  tests/testutils/python_repo.py: Use subprocess to run sdist
  
  The current approach using setuptools.sandbox.run_setup() was
  causing a spurious (but highly frequent) failure where setuptools
  gets mixed up with it's manipulation of sys.modules and hits a
  RuntimeError as a dictionary changes size while being iterated over.
  
  For instance: https://gitlab.com/BuildStream/buildstream/-/jobs/147967307
  
  Since this already happens in an isolated virtual environment created
  by tox, we should not need additional sandboxing here from setuptools,
  and launching this as a subprocess will be safer.
  

• d114a6bd
  by Tristan Van Berkom at 2019-01-18T22:07:22Z

  Merge branch 'tristan/fix-pip-source-test' into 'master'
  
  tests/testutils/python_repo.py: Use subprocess to run sdist
  
  See merge request BuildStream/buildstream!1090

1 changed file:

• tests/testutils/python_repo.py

Changes:

tests/testutils/python_repo.py

---

1		-from setuptools.sandbox import run_setup
2	1	import os
3	2	import pytest
4	3	import re
5	4	import shutil
	5	+import subprocess
6	6
7	7
8	8	SETUP_TEMPLATE = '''\
...	...	@@ -88,7 +88,9 @@ def generate_pip_package(tmpdir, pypi, name, version='0.1'):
88	88	f.write(INIT_TEMPLATE.format(name=name))
89	89	os.chmod(main_file, 0o644)
90	90
91		- run_setup(setup_file, ['sdist'])
	91	+ # Run sdist with a fresh process
	92	+ p = subprocess.run(['python3', 'setup.py', 'sdist'], cwd=tmpdir)
	93	+ assert p.returncode == 0
92	94
93	95	# create directory for this package in pypi resulting in a directory
94	96	# tree resembling the following structure:

—
View it on GitLab.
You're receiving this email because of your account on gitlab.com. If you'd like to receive fewer emails, you can adjust your notification settings.