[Notes] [Git][BuildStream/buildstream][phil/plugin-testing-api] 56 commi

Phil Dawson pushed to branch phil/plugin-testing-api at BuildStream / buildstream

Commits:

006370af

by Chandan Singh at 2019-01-15T01:21:33Z

Merge branch 'chandan/reqs-update-test' into 'master'

.gitlab-ci.yml: Add job to attempt to update dependencies

See merge request BuildStream/buildstream!1038

4b544555

by Chandan Singh at 2019-01-15T21:28:40Z

.gitlab-ci.yml: Add tests for python 3.7

We already have tests for python 3.5 and 3.6 but not 3.7.

Fixes https://gitlab.com/BuildStream/buildstream/issues/838.

80fe0d9a

by Javier Jardón at 2019-01-15T22:48:22Z

Merge branch 'chandan/python37-tests' into 'master'

.gitlab-ci.yml: Add tests for python 3.7

Closes #838

See merge request BuildStream/buildstream!1074

c91784ab

by Chandan Singh at 2019-01-15T22:49:01Z

conftest.py: Don't use deprecated get_marker() function

Starting from `pytest` version 4.1.0, `Node.get_marker()` has been
removed, and hence our tests break when running with newer versions of
`pytest`. It was deprecated since a while back but it has recently been
removed completely. Use `get_closest_marker()` as a replacement that is
suggested in the changelog, and seems to work fine for our use case.

See https://github.com/pytest-dev/pytest/pull/4564 for more context on
the upstream issue.

One way of verifying this change is that this should fix the recently
added `tests-fedora-update-deps` job, that was failing before due to
this issue.

ecae4d73

by Javier Jardón at 2019-01-15T23:23:41Z

Merge branch 'chandan/fix-pytest-get-marker' into 'master'

conftest.py: Don't use deprecated get_marker() function

See merge request BuildStream/buildstream!1073

0eac4008

by Valentin David at 2019-01-16T10:04:57Z

buildstream/_gitsourcebase.py: Reduce git history for git describe.

Found during #833.

`git rev-list --boundary tag..HEAD` unfortunately gives boundaries
that are deeper than should when there is a merge commit between `tag`
and `HEAD`. The common ancestory of the two parents of the merge is
a boundary instead of the parent of the branch that is not traversed.

`--ancestry-path` fixes this issue by restricting `git` traversing
those branches.

a405e08f

by Valentin David at 2019-01-16T10:04:57Z

buildstream/_gitsourcebase.py: Fix case where HEAD is tagged

`git rev-list --boundary HEAD..HEAD` does not return any boundary.
So in this case we need to manually tag the HEAD as a boundary.

c0631d48

by Valentin David at 2019-01-16T10:33:52Z

Merge branch 'valentindavid/git-reduced-history' into 'master'

buildstream/_gitsourcebase.py: Reduce git history for git describe.

See merge request BuildStream/buildstream!1069

b608ac86

by James Ennis at 2019-01-16T11:05:44Z

_context.py: Doc fix: get_toplevel_project() returns object not list

97a3beb6

by James Ennis at 2019-01-16T11:05:44Z

_context.py: Add documentation to get_workspaces() command

d6587aa0

by James Ennis at 2019-01-16T11:33:21Z

Merge branch 'jennis/doc_fixes_in_context' into 'master'

Small documentation/comment fixes in context.py

See merge request BuildStream/buildstream!1072

2683f98a

by Raoul Hidalgo Charman at 2019-01-16T11:55:07Z

_cas: Rename artifactcache folder and move that to a root module

Other components will start to reply on cas modules, and not the artifact cache
modules so it should be organized to reflect this.

All relevant imports have been changed.

Part #802

d2cc4798

by Raoul Hidalgo Charman at 2019-01-16T11:55:07Z

casremote.py: Move remote CAS classes into its own file

Part of #802

76f67483

by Raoul Hidalgo Charman at 2019-01-16T11:55:07Z

cas: move remote only functions to CASRemote

List of methods moved
* Initialization check: made it a class method that is run in a subprocess, for
  when checking in the main buildstream process.
* fetch_blobs
* send_blobs
* verify_digest_on_remote
* push_method

Part of #802

6c428bc9

by Jürg Billeter at 2019-01-16T12:56:38Z

Merge branch 'raoul/cas-refactor' into 'master'

Cas refactor

See merge request BuildStream/buildstream!1071

2648b0bd
by Angelos Evripiotis at 2019-01-16T14:44:25Z
```
bst-docker-import: fix Chandan's name
```

780d0f3a

by Angelos Evripiotis at 2019-01-16T15:13:06Z

Merge branch 'chadnan' into 'master'

bst-docker-import: fix Chandan's name

See merge request BuildStream/buildstream!1076

4ca37dcd

by Tristan Van Berkom at 2019-01-16T15:47:21Z

source-determinism.py integration test: Dont use integration_cache fixture

This was just deadcode, it's not really used here.

6286d820

by Tristan Van Berkom at 2019-01-16T15:47:21Z

conftest.py: Use different artifact directory for integration tests

To ensure we can run integration tests in parallel, use a tempdir
for the artifact cache of each separate integration test run.

This makes it possible to run multiple full test runs including
integration tests in parallel under detox.

471af316

by Tristan Van Berkom at 2019-01-16T16:32:52Z

Merge branch 'tristan/detoxing-integration-tests' into 'master'

Make integration tests parallelizable

See merge request BuildStream/buildstream!1077

081e8426

by James Ennis at 2019-01-16T17:58:41Z

setup.py: Import server main from _cas/casserver.py

Since the CAS refactor, we have not been able to execute
bst-artifact-server. This commit ensures that we can.

This fix closes #867

e385660c

by James Ennis at 2019-01-16T18:33:20Z

Merge branch 'jennis/fix_bst_artifact_server' into 'master'

Ensure that we can execute `bst-artifact-server`

Closes #867

See merge request BuildStream/buildstream!1079

6991d6d6

by Tristan Van Berkom at 2019-01-16T19:28:14Z

_scheduler: Refactor of queues and resources.

This branch makes the following changes:

  * jobs/job.py: No longer stores any interested resource list

    Jobs are ephemeral again, they only ever exist while they
    are running.

  * queues/queue.py: Revert to only handling lists of elements

    Elements pass through the queues, Queue.harvest_jobs()
    replaces Queue.pop_ready_jobs() and now the Queue stops
    creating jobs as soon as there are not enough resources
    for the job.

    Also removed unused `prepare()` abstract method.

  * queues/buildqueue.py: Adapt the part where we launch a job

    This part needs to be reworked anyway, just touch it up for
    now so that it doesnt break with the surrounding changes.

  * jobs/{cachesize,cleanup}job.py: Expose uniform complete callback

    Allows the scheduler to manage resource deallocation for these
    two job completions as a custom thing, at the same phase
    that the Queues take care of their own resource deallocation.

  * resources.py: No longer has knowledge of the job

    Since jobs are ephemeral, they are not a suitable place
    to store the resource identifiers, these must be provided
    by the callers wherever needed.

    Now the main Resources object is owned by the Scheduler
    but shared with Queues, each take care of managing the
    resources of the jobs they create through the same
    resource API.

  * scheduler.py: Reverted to only creating jobs on demand

    This changes the flow of the scheduler such that whenever
    jobs complete, the queues are interrogated for as many
    jobs which can run at the moment but not more; and this
    completely removes the waiting list.

    For the internal cache management jobs, we handle this
    with a little state instead of having a waiting list
    and only launch when the resources permit it.

By abolishing the scheduler waiting list and creating jobs
on demand, we fix the order of element processing and consequently
fix issue #712.

04ba59bc

by Tristan Van Berkom at 2019-01-16T19:28:14Z

tests/frontend/order.py: Enable the test for build and fix the fetch tests

With the scheduler changes, fetch jobs get automatically skipped
so the output is changed, using a separate repo for each element
fixes the test such that every fetch job gets a job launched.

32bdded8

by Tristan Van Berkom at 2019-01-16T19:28:14Z

_artifactcache/artifactcache.py: Rephrase failure message

It was saying "There is not enough space to build the given element.",
this makes me think the error is associated to a specific element, but
this does not make sense to show up in a cleanup task.

Instead say "There is not enough space to complete the build.", which
should be more clear that even after cleaning up there is not enough
space.

17f6e5a8

by Tristan Van Berkom at 2019-01-16T20:10:30Z

Merge branch 'tristan/element-processing-order' into 'master'

Scheduler refactor, fix processing order

Closes #712

See merge request BuildStream/buildstream!1067

19adc9e5

by Tristan Van Berkom at 2019-01-16T20:48:10Z

element.py: Cleanup temporary staging directories on termination

Use utils._tempdir() which in turn uses _signals.terminator() for
this purpose.

This also changes utils._tempdir() to use utils._force_rmtree()
so that it is safe to use for cleaning up the staging directory.

This patch fixes orphaned temporary directories being left behind
in the artifact cache directory at forceful termination time.

5e9598c5

by Tristan Van Berkom at 2019-01-16T21:17:26Z

Merge branch 'tristan/cleanup-staging-tempdir' into 'master'

element.py: Cleanup temporary staging directories on termination

See merge request BuildStream/buildstream!1080

5ea2f59d
by Tristan Van Berkom at 2019-01-16T23:35:21Z
```
tests: Migrate completions test to tests/frontend
```

1eafc25c