[Notes] [Git][BuildStream/buildstream][bschubert/add-centos-runner] 49 commits: Support running test environments in parallel with `detox`

[Benjamin Schubert <gitlab mg gitlab com>]

Title: GitLab

Benjamin Schubert pushed to branch bschubert/add-centos-runner at BuildStream / buildstream

Commits:

• f29a0995
  by Tristan Van Berkom at 2019-01-09T19:51:14Z

  Support running test environments in parallel with `detox`
  
  This patch namespaces the test temp directory and the output
  coverage report file with the name of the environment under test,
  such that separately run tests do not access the same files.
  
  When running tests without tox, directly through setup.py,
  then the tmp directory will still be `./tmp`.
  
    * .gitignore: Added new .coverage-reports/ directory
  
    * .gitlab-ci.yml: Rely on tox to combine and report coverage, only
      tell tox about the COVERAGE_PREFIX so that results can be namespaced
      by CI job name.
  
      This change also publishes the sources and final combined `.coverage`
      file in an output gitlab artifact for inspection, and lists some missing
      dependencies to the `coverage` job.
  
    * tox.ini: Add comments and refactor main [testenv] section so that
      other environments dont inherit too much unrelated cruft.
  
      Generate the coverate reports in the respective {envtmpdir} so that
      all per-process coverage files are prefixed with a full path, ensuring
      that concurrent runs don't mix reports and addressing concerns
      raised in #844.
  
      Also implemented new `tox -e coverage` environment to combine
      any found coverage and print a report.
  
    * .coveragerc: Omit .tox/ directory from coverage stats
  
  Fixes issue #844
  

• d364ad02
  by Tristan Van Berkom at 2019-01-09T19:52:22Z

  CONTRIBUTING.rst: Updated to mention new `coverage` tox environment.
  
  Also point out that it is possible to run test environments in
  parallel using the `detox` tool.
  

• 1e352434
  by Tristan Van Berkom at 2019-01-09T20:36:06Z

  Merge branch 'tristan/detox-tests' into 'master'
  
  Allow using detox, and fix/refactor collection of coverage reports
  
  Closes #844
  
  See merge request BuildStream/buildstream!1051

• 116c1070
  by Tristan Van Berkom at 2019-01-09T20:39:15Z

  .coveragerc: Omit some things which are irrelevant to cover.
  
    * Omit versioneer's _version.py
  
    * Omit our __main__.py which is used only internally for generating
      documentation
  

• c8f3616d
  by Tristan Van Berkom at 2019-01-09T21:12:29Z

  Merge branch 'tristan/refine-coverage' into 'master'
  
  .coveragerc: Omit some things which are irrelevant to cover.
  
  See merge request BuildStream/buildstream!1052

• c87bb592
  by Jürg Billeter at 2019-01-10T09:43:37Z

  _platform/platform.py: Add canonicalize_arch() method
  

• 26e33346
  by Jürg Billeter at 2019-01-10T12:50:15Z

  _options/optionarch.py: Accept architecture aliases
  
  Accept common architecture aliases for arch options instead of only
  accepting the canonicalized, OS-independent architecture name. This
  restores compatibility with existing projects and may simplify option
  handling for projects that only target a single OS (and thus, do not
  need OS-independent architecture names).
  

• 06deb4c4
  by Jürg Billeter at 2019-01-10T12:50:15Z

  element.py: Accept architecture aliases for sandbox config
  
  Accept common architecture aliases for the sandbox config for
  consistency with arch options.
  

• 0c2a66b3
  by Jürg Billeter at 2019-01-10T13:06:02Z

  tests/format/optionarch.py: Add tests for architecture aliases
  

• f86bc760
  by Jürg Billeter at 2019-01-10T13:34:56Z

  Merge branch 'juerg/arch' into 'master'
  
  Accept architecture aliases
  
  See merge request BuildStream/buildstream!1034

• 347eb34e
  by Angelos Evripiotis at 2019-01-10T14:38:23Z

  contributing: fix 'oprtation' and some other typos
  

• 6bc27bc1
  by Angelos Evripiotis at 2019-01-10T15:07:46Z

  Merge branch 'aevri/contrib-typos' into 'master'
  
  contributing: fix 'oprtation' and some other typos
  
  See merge request BuildStream/buildstream!1055

• 0b83d024
  by Tristan Van Berkom at 2019-01-10T20:02:50Z

  _pipeline.py: Fix the planner to retain the original order when depth sorting
  
  The algorithm adds elements to a dictionary and then sorts the dictionary
  by the discovered depths while recursing - using an OrderedDict is enough
  to ensure a stable order.
  
  This fixes `bst show --deps plan ...` reporting different results on
  each invocation.
  
  This fixes an aspect of #824
  

• 630e26f1
  by Tristan Van Berkom at 2019-01-10T20:03:52Z

  testutils/runcli.py: Added Result.get_start_order()
  
  Added a function to report the list of elements which appeared in
  a given queue in the order of their first appearance.
  

• d1d7de57
  by Tristan Van Berkom at 2019-01-11T04:13:16Z

  tests/frontend/order.py: Adding tests ensuring stable element processing order
  
  For each sample project and expected result order, this test ensures that:
  
    * bst show --deps plan: Always shows the expected build order.
  
    * bst source fetch: Always executes in the expected build order.
  
    * bst build: Always builds in the expected order (disabled).
  
  The build part of the test is currently disabled as the scheduler
  seems to be messing with the order even in a `--builders 1` scenario.
  

• 276b8d48
  by Tristan Van Berkom at 2019-01-11T04:42:24Z

  Merge branch 'tristan/element-processing-order' into 'master'
  
  Make build plan element list stable
  
  See merge request BuildStream/buildstream!1058

• fc3dcec8
  by Angelos Evripiotis at 2019-01-11T16:45:00Z

  dev-requirements: pytest-cov==2.6.1 for '--no-cov'
  
  Bump the version of pytest-cov, so that we pick up the fix for
  the '--no-cov' option breaking in pytest 4.0:
  
      https://github.com/pytest-dev/pytest-cov/pull/230
  
  This was the error you would get prior to this version:
  
      _pytest.warning_types.RemovedInPytest4Warning: config.warn has been
      deprecated, use warnings.warn instead
  
  Although it says 'deprecated', it did result in
  termination with stack trace.
  

• f86b7ff3
  by Angelos Evripiotis at 2019-01-11T16:45:00Z

  contributing: '--last-failed' and '--no-cov' tips
  
  To help new folks get to grips with pytest, add some tips on other
  frequently used features.
  

• d983f231
  by Angelos Evripiotis at 2019-01-11T17:19:06Z

  Merge branch 'aevri/tox_no_cov' into 'master'
  
  pytest-cov==2.6.1, contributing: '--last-failed' and '--no-cov' tips
  
  See merge request BuildStream/buildstream!1059

• 829a2b93
  by Tristan Van Berkom at 2019-01-12T21:32:13Z

  _scheduler/queues/queue.py: Put elements in the skip list, not jobs
  
  Minor correction, looks like we're not observing this queue
  otherwise we'd be seeing crashes.
  

• 993e30ae
  by Tristan Van Berkom at 2019-01-12T22:02:55Z

  Merge branch 'tristan/fix-skipped-elements' into 'master'
  
  _scheduler/queues/queue.py: Put elements in the skip list, not jobs
  
  See merge request BuildStream/buildstream!1063

• 32732e01
  by Javier Jardón at 2019-01-14T09:04:01Z

  .gitlab-ci.yml: Use latest freedesktop-sdk 18.08.25
  

• 4f5f1184
  by Valentin David at 2019-01-14T09:40:56Z

  Merge branch 'jjardon/freedesktop-sdk_latest' into 'master'
  
  .gitlab-ci.yml: Use latest freedesktop-sdk 18.08.25
  
  Closes #858
  
  See merge request BuildStream/buildstream!1064

• bb80a2b8
  by Chandan Singh at 2019-01-14T14:30:15Z

  .gitlab-ci.yml: Use newer image for overning aarch tests
  
  During recent reorganizing of `.gitlab-ci.yml` to work with `tox`, seems
  like we missed to update the image used by the overnight aarch tests,
  meaning that they currently fail due to `tox` being missing from them.
  
  While these tests will be skipped on MRs usually, here is an example of
  what the tests look like if they are actually run with this change:
  https://gitlab.com/BuildStream/buildstream/-/jobs/145449561.
  
  Fixes #859.
  

• 10b3ee62
  by Chandan Singh at 2019-01-14T14:57:08Z

  Merge branch 'chandan/fix-overnight-aarch' into 'master'
  
  Chandan/fix overnight aarch
  
  Closes #859
  
  See merge request BuildStream/buildstream!1065

• 542cdaf0
  by Jürg Billeter at 2019-01-14T18:46:57Z

  _frontend/cli.py: Also check original args for --config in bash completion
  
  The path of the config file generated by testutils for completion tests
  is passed as regular argument, not via COMP_WORDS. Use that config file
  in complete_artifact() to ensure the test uses the right artifact
  directory.
  

• ff666e76
  by James Ennis at 2019-01-14T18:46:57Z

  completions.py: Add a test for our artifact ref autocompletions
  
  Since the artifact subcommand group has been created, we have been able
  to tab complete both element names and artifact refs as arguments to
  the artifact subcommands (e.g. bst artifact log), this commit adds a
  test for this.
  

• 273b0f55
  by Tristan Van Berkom at 2019-01-14T20:24:57Z

  Merge branch 'jennis/add_artifacts_completion' into 'master'
  
  completions.py: Add a test for our artifact ref autocompletions
  
  See merge request BuildStream/buildstream!1054

• 2e3c2ea2
  by Javier Jardón at 2019-01-14T22:26:04Z

  .gitlab-ci.yml: Use latest bst-external
  
  which include flatpak_repo plugin needed to build fdsdk
  

• d60d2e31
  by Javier Jardón at 2019-01-15T00:39:22Z

  Merge branch 'jjardon/bst_external_0_9' into 'master'
  
  .gitlab-ci.yml: Use latest bst-external
  
  Closes #861
  
  See merge request BuildStream/buildstream!1068

• 605836c1
  by Chandan Singh at 2019-01-15T00:57:05Z

  .gitlab-ci.yml: Add job to attempt to update dependencies
  
  This will help us check if BuildStream is working with the latest
  version of dependencies, as per our constraints. This job is allowed to
  fail but its failure should signal that we need to add stricter
  constraints in some of our `.in` requirements files.
  

• 006370af
  by Chandan Singh at 2019-01-15T01:21:33Z

  Merge branch 'chandan/reqs-update-test' into 'master'
  
  .gitlab-ci.yml: Add job to attempt to update dependencies
  
  See merge request BuildStream/buildstream!1038

• 4b544555
  by Chandan Singh at 2019-01-15T21:28:40Z

  .gitlab-ci.yml: Add tests for python 3.7
  
  We already have tests for python 3.5 and 3.6 but not 3.7.
  
  Fixes https://gitlab.com/BuildStream/buildstream/issues/838.
  

• 80fe0d9a
  by Javier Jardón at 2019-01-15T22:48:22Z

  Merge branch 'chandan/python37-tests' into 'master'
  
  .gitlab-ci.yml: Add tests for python 3.7
  
  Closes #838
  
  See merge request BuildStream/buildstream!1074

• c91784ab
  by Chandan Singh at 2019-01-15T22:49:01Z

  conftest.py: Don't use deprecated get_marker() function
  
  Starting from `pytest` version 4.1.0, `Node.get_marker()` has been
  removed, and hence our tests break when running with newer versions of
  `pytest`. It was deprecated since a while back but it has recently been
  removed completely. Use `get_closest_marker()` as a replacement that is
  suggested in the changelog, and seems to work fine for our use case.
  
  See https://github.com/pytest-dev/pytest/pull/4564 for more context on
  the upstream issue.
  
  One way of verifying this change is that this should fix the recently
  added `tests-fedora-update-deps` job, that was failing before due to
  this issue.
  

• ecae4d73
  by Javier Jardón at 2019-01-15T23:23:41Z

  Merge branch 'chandan/fix-pytest-get-marker' into 'master'
  
  conftest.py: Don't use deprecated get_marker() function
  
  See merge request BuildStream/buildstream!1073

• 0eac4008
  by Valentin David at 2019-01-16T10:04:57Z

  buildstream/_gitsourcebase.py: Reduce git history for git describe.
  
  Found during #833.
  
  `git rev-list --boundary tag..HEAD` unfortunately gives boundaries
  that are deeper than should when there is a merge commit between `tag`
  and `HEAD`. The common ancestory of the two parents of the merge is
  a boundary instead of the parent of the branch that is not traversed.
  
  `--ancestry-path` fixes this issue by restricting `git` traversing
  those branches.
  

• a405e08f
  by Valentin David at 2019-01-16T10:04:57Z

  buildstream/_gitsourcebase.py: Fix case where HEAD is tagged
  
  `git rev-list --boundary HEAD..HEAD` does not return any boundary.
  So in this case we need to manually tag the HEAD as a boundary.
  

• c0631d48
  by Valentin David at 2019-01-16T10:33:52Z

  Merge branch 'valentindavid/git-reduced-history' into 'master'
  
  buildstream/_gitsourcebase.py: Reduce git history for git describe.
  
  See merge request BuildStream/buildstream!1069

• b608ac86
  by James Ennis at 2019-01-16T11:05:44Z

  _context.py: Doc fix: get_toplevel_project() returns object not list
  

• 97a3beb6
  by James Ennis at 2019-01-16T11:05:44Z

  _context.py: Add documentation to get_workspaces() command
  

• d6587aa0
  by James Ennis at 2019-01-16T11:33:21Z

  Merge branch 'jennis/doc_fixes_in_context' into 'master'
  
  Small documentation/comment fixes in context.py
  
  See merge request BuildStream/buildstream!1072

• 2683f98a
  by Raoul Hidalgo Charman at 2019-01-16T11:55:07Z

  _cas: Rename artifactcache folder and move that to a root module
  
  Other components will start to reply on cas modules, and not the artifact cache
  modules so it should be organized to reflect this.
  
  All relevant imports have been changed.
  
  Part #802
  

• d2cc4798
  by Raoul Hidalgo Charman at 2019-01-16T11:55:07Z

  casremote.py: Move remote CAS classes into its own file
  
  Part of #802
  

• 76f67483
  by Raoul Hidalgo Charman at 2019-01-16T11:55:07Z

  cas: move remote only functions to CASRemote
  
  List of methods moved
  * Initialization check: made it a class method that is run in a subprocess, for
    when checking in the main buildstream process.
  * fetch_blobs
  * send_blobs
  * verify_digest_on_remote
  * push_method
  
  Part of #802
  

• 6c428bc9
  by Jürg Billeter at 2019-01-16T12:56:38Z

  Merge branch 'raoul/cas-refactor' into 'master'
  
  Cas refactor
  
  See merge request BuildStream/buildstream!1071

• 2648b0bd
  by Angelos Evripiotis at 2019-01-16T14:44:25Z

  bst-docker-import: fix Chandan's name

• 780d0f3a
  by Angelos Evripiotis at 2019-01-16T15:13:06Z

  Merge branch 'chadnan' into 'master'
  
  bst-docker-import: fix Chandan's name
  
  See merge request BuildStream/buildstream!1076

• aaf9d1b8
  by Benjamin Schubert at 2019-01-16T15:43:59Z

  Add a Centos runner
  
  Centos is apparently different enough from fedora when running tests.
  

30 changed files:

• .coveragerc
• .gitignore
• .gitlab-ci.yml
• CONTRIBUTING.rst
• buildstream/_artifactcache/artifactcache.py → buildstream/_artifactcache.py
• buildstream/_artifactcache/__init__.py → buildstream/_cas/__init__.py
• buildstream/_artifactcache/cascache.py → buildstream/_cas/cascache.py
• + buildstream/_cas/casremote.py
• buildstream/_artifactcache/casserver.py → buildstream/_cas/casserver.py
• buildstream/_context.py
• buildstream/_exceptions.py
• buildstream/_frontend/cli.py
• buildstream/_gitsourcebase.py
• buildstream/_options/optionarch.py
• buildstream/_pipeline.py
• buildstream/_platform/platform.py
• buildstream/_scheduler/queues/queue.py
• buildstream/element.py
• buildstream/sandbox/_sandboxremote.py
• conftest.py
• contrib/bst-docker-import
• doc/source/using_configuring_artifact_server.rst
• requirements/dev-requirements.txt
• tests/artifactcache/config.py
• tests/artifactcache/expiry.py
• tests/completions/completions.py
• + tests/format/option-arch-alias/element.bst
• + tests/format/option-arch-alias/project.conf
• + tests/format/option-arch-unknown/element.bst
• + tests/format/option-arch-unknown/project.conf

The diff was not included because it is too large.

—
View it on GitLab.
You're receiving this email because of your account on gitlab.com. If you'd like to receive fewer emails, you can adjust your notification settings.