[Notes] [Git][BuildStream/buildstream][master] 2 commits: _scheduler/queues/queue.py: Put elements in the skip list, not jobs

[Tristan Van Berkom <gitlab mg gitlab com>]

Title: GitLab

Tristan Van Berkom pushed to branch master at BuildStream / buildstream

Commits:

• 829a2b93
  by Tristan Van Berkom at 2019-01-12T21:32:13Z

  _scheduler/queues/queue.py: Put elements in the skip list, not jobs
  
  Minor correction, looks like we're not observing this queue
  otherwise we'd be seeing crashes.
  

• 993e30ae
  by Tristan Van Berkom at 2019-01-12T22:02:55Z

  Merge branch 'tristan/fix-skipped-elements' into 'master'
  
  _scheduler/queues/queue.py: Put elements in the skip list, not jobs
  
  See merge request BuildStream/buildstream!1063

1 changed file:

• buildstream/_scheduler/queues/queue.py

Changes:

buildstream/_scheduler/queues/queue.py

---

...	...	@@ -170,9 +170,9 @@ class Queue():
170	170	skip = [job for job in jobs if self.status(job.element) == QueueStatus.SKIP]
171	171	wait = [job for job in jobs if job not in skip]
172	172
	173	+ self.skipped_elements.extend([job.element for job in skip])
173	174	self._wait_queue.extend(wait)
174	175	self._done_queue.extend(skip)
175		- self.skipped_elements.extend(skip)
176	176
177	177	# dequeue()
178	178	#

—
View it on GitLab.
You're receiving this email because of your account on gitlab.com. If you'd like to receive fewer emails, you can adjust your notification settings.