[Notes] [Git][BuildStream/buildstream][valentindavid/remote_execution

Valentin David pushed to branch valentindavid/remote_execution_configuration at BuildStream / buildstream

Commits:

bb9df2a1

by Chandan Singh at 2019-01-02T11:59:35Z

doc/Makefile: Update comment about sphinx entrypoint

https://github.com/sphinx-doc/sphinx/issues/4375 has been closed as
`wontfix`. Update the comment in doc/Makefile that mentions it, based on
the discussion on the issue.

43eaf6ee

by Chandan Singh at 2019-01-02T13:42:10Z

Merge branch 'chandan/update-doc-makefile-note' into 'master'

doc/Makefile: Update comment about sphinx entrypoint

See merge request BuildStream/buildstream!1026

3b5c8a28

by Tristan Maat at 2019-01-02T15:57:13Z

.gitlab-ci.yml: Use new testsuite images with pycodestyle 1.4.0

We need to bump the testsuite image versions to use the new
pycodestyle update that allows excluding file paths, so that we can
exclude generated python code.

bd60e8a9

by Javier Jardón at 2019-01-02T16:59:41Z

Use pycodestyle instead of pep8

pep8 package was renamed to pycodestyle to reduce confusion.

Disabled warnings:
W504 - Line break after binary operator (seems people like this)
W605 - Invalid escape sequence (some of our regexes use these)

32c47d1c

by Tristan Maat at 2019-01-02T17:32:09Z

Merge branch 'jjardon/pycodestyle' into 'master'

Use pycodestyle instead pep8 python module

See merge request BuildStream/buildstream!638

1cbd9a73

by Chandan Singh at 2019-01-02T19:39:58Z

Add requirements files for install, test and plugin dependencies

Add `.in` and `.txt` requirements files for BuildStream's pure python
dependencies. For each pair, the `.in` file is supposed to capture the
loose version requirements, and the corresponding `.txt` file is
supposed to have frozen requirements. We have 3 such sets:

* `requirements`: BuildStream's runtime dependencies
* `dev-requirements`: Dependencies for running tests
* `plugin-requirements`: Dependencies for core plugins

Note that the frozen requirements files will only be used for testing
purposes, and `setup.py` will continue to read loose requirements.

6b0cb5f3

by Chandan Singh at 2019-01-02T19:41:21Z

Add tox.ini to enable running tests using tox

Add `tox.ini` file that will enable us to use
[tox](https://tox.readthedocs.io/) as a frontend for running tests.
Since we share the config via `setup.cfg` and requirements via
requirements files, commands like `python3 setup.py test` will continue
to work.

9d2d1d4f

by Chandan Singh at 2019-01-03T03:31:52Z

.gitlab-ci.yml: Run tests using tox

Instead of invoking tests throung `setup.py`, use `tox` as a frontend in
the CI pipelines.

8ae04283

by Tristan Van Berkom at 2019-01-03T03:31:52Z

CONTRIBUTING.rst: Updated to reflect running tests using tox.

e7e2a5c1

by Chandan Singh at 2019-01-03T03:31:52Z

CONTRIBUTING.rst: Add steps for installing non-python build dependencies

Since we don't allow use of site packages by default in our `tox`
configuration, people will need to install non-python build dependencies
of some of our dependencies that do not provide pre-built wheels. We
have two such packages at the moment:

* psuitl: requires python C headers, compiler
* pygobject: requires python C headers, pkg-config, compiler, cairo
  headers, and gobject libraries

afa0a369

by Chandan Singh at 2019-01-03T03:31:52Z

Move all requirements files into "tools" directory

These new `.in` and `.txt` are making the repository look very
cluttered. Move them to a separate `tools` directory to make it look a
bit cleaner.

3fae3446

by Chandan Singh at 2019-01-03T03:44:17Z

Move sphinx build functionality to tox

Currently the CI and the docs both have to duplicate the same inforation
about how to gather dependencies etc, and have to use hacky ways to run
them.

Add a new `docs` environment to our tox setup so that building docs is
as simple as running `tox -e docs`.

1f7bc655

by Chandan Singh at 2019-01-03T03:44:17Z

CONTRIBUTING.rst: Add instructions to recreate tox environment

When we update our dependencies, developers will eventually need to
recreate their `tox` environments to get correct results. This happens
because `tox` isn't particularly good at recognizing changes in the
requirements files.

669b55b0

by Tristan Van Berkom at 2019-01-03T15:47:27Z

Merge branch 'chandan/toxify' into 'master'

Use tox as a frontend for running tests

See merge request BuildStream/buildstream!1027

ca547f19

by Chandan Singh at 2019-01-03T19:34:49Z

tests/frontend/buildcheckout.py: Fix bad filename issue for Windows

In BuildStream/buildstream!1028, we added a test specifically to test
that BuildStream correctly raises an warning when the name of an element
contains characters that are invalid on Windows. Unfortunately, we
didn't see it coming that it would make it impossible to checkout this
branch on Windows.

Fix it by generating this file, only if we are not running on Windows.

* tests/testutils/site.py: Add `IS_WINDOWS` check
* tests/frontend/buildcheckout.py: Generate file with invalid filename
  on the fly
* Remove tests/frontend/project/elements/invalid-chars.

Fixes #842.

Note that this may still cause issues on WSL when running tests on a
shared filesystem, but that seems to be a generic issue on WSL with
`os.rename`.

01c3761c

by Chandan Singh at 2019-01-03T20:03:32Z

Merge branch 'chandan/fix-bad-filename-mini-disaster' into 'master'

tests/frontend/buildcheckout.py: Fix bad filename issue for Windows

Closes #842

See merge request BuildStream/buildstream!1032

7850e4e2

by Tristan Van Berkom at 2019-01-03T20:55:00Z

setup.cfg: Specify the pycodestyle configurations separately from pytest configuration

3c9d592d

by Tristan Van Berkom at 2019-01-03T20:55:00Z

setup.cfg: Don't lint by default through setup.py test invocations

feba48e7

by Tristan Van Berkom at 2019-01-03T20:55:00Z

tox.ini: Added new 'lint' environment to lint separately

9caa0ea0

by Tristan Van Berkom at 2019-01-03T20:55:00Z

.gitlab-ci.yml: Update the CI to run the linter separately through tox

This should save us some cycles in CI, and also allow the
developer to more conveniently lint separately from testing.

91c8b634

by Tristan Van Berkom at 2019-01-03T21:04:49Z

CONTRIBUTING.rst: Adding instructions to run the linter separately

892bf99e

by Tristan Van Berkom at 2019-01-03T21:31:04Z

tools/requirements.{in,txt}: Fix warning about duplicate jinja

Apparently you need to spell Jinja2 with a capital J, otherwise
we find it listed twice in the resulting requirements.txt files.

7c681c42

by Tristan Van Berkom at 2019-01-03T21:32:40Z

tools/dev-requirements.{in,txt}: Removed requirements on pylint/codestyle pytest plugins

We no longer run the linters through pytest, so we don't need these
plugins anymore.

d6689ed2

by Tristan Van Berkom at 2019-01-03T22:09:02Z

Merge branch 'tristan/toxic-linting' into 'master'

Run the linter separately from the tests

See merge request BuildStream/buildstream!1033

e15278d7

by Thomas Coldrick at 2019-01-03T22:14:01Z

Use collections.abc for Mapping, Iterable

In _yaml.py and _frontend/complete.py we were getting pylint warnings
for using collections.Mapping and collections.Iterable, which are
abstract classes now provided from collections.abc. This patch just
uses the classes from the right place.

a85da591

by Tristan Van Berkom at 2019-01-03T22:36:16Z

Merge branch 'coldtom/collections' into 'master'

Use collections.abc for Mapping, Iterable

Closes #831

See merge request BuildStream/buildstream!1020

cf0e7d26

by Jürg Billeter at 2019-01-04T07:07:59Z

_frontend/cli.py: Reinstate support for guessing targets

Moving fetch and track to the source command group accidentally dropped
the support for guessing targets for these commands when invoked from a
workspace directory. This brings it back.

0751fc8f

by Jürg Billeter at 2019-01-04T11:27:58Z

Merge branch 'juerg/source-guess-target' into 'master'

_frontend/cli.py: Reinstate support for guessing targets

See merge request BuildStream/buildstream!1036

d0a30f89

by Valentin David at 2019-01-04T14:15:48Z

Use relative path to project directory for remote execution certificates/keys

79ef60be

by Valentin David at 2019-01-04T14:15:48Z

Add support for user remote execution configuration

Fixes #631.

65cb17a1

by Valentin David at 2019-01-04T14:15:48Z

Add support for https channel to remote execution and actions servers

Fixes #780.

29 changed files:

.gitignore
.gitlab-ci.yml
CONTRIBUTING.rst
MANIFEST.in
buildstream/_context.py
buildstream/_frontend/cli.py
buildstream/_frontend/complete.py
buildstream/_ostree.py
buildstream/_project.py
buildstream/_signals.py
buildstream/_yaml.py
buildstream/element.py
buildstream/sandbox/_sandboxremote.py
doc/Makefile
doc/source/format_project.rst
doc/source/using_config.rst
setup.cfg
setup.py
tests/frontend/buildcheckout.py
− tests/frontend/project/elements/invalid-chars|<>-in-name.bst
tests/testutils/http_server.py
tests/testutils/site.py
dev-requirements.txt → tools/dev-requirements.in
+ tools/dev-requirements.txt
+ tools/plugin-requirements.in
+ tools/plugin-requirements.txt
+ tools/requirements.in
+ tools/requirements.txt
+ tox.ini

Changes:

.gitignore

@@ -17,6 +17,7 @@ tmp
  .cache
  .pytest_cache/
  *.bst/
 +.tox
  # Pycache, in case buildstream is ran directly from within the source
  # tree

.gitlab-ci.yml

 -image: buildstream/testsuite-debian:9-master-123-7ce6581b
 +image: buildstream/testsuite-debian:9-5da27168-32c47d1c
  cache:
    key: "$CI_JOB_NAME-"
@@ -13,7 +13,7 @@ stages:
  variables:
    PYTEST_ADDOPTS: "--color=yes"
    INTEGRATION_CACHE: "${CI_PROJECT_DIR}/cache/integration-cache"
 -  TEST_COMMAND: 'python3 setup.py test --index-url invalid://uri --addopts --integration'
 +  TEST_COMMAND: "tox -- --color=yes --integration"
  #####################################################
  #                  Prepare stage                    #
@@ -68,10 +68,6 @@ source_dist:
    - mount
    - df -h
 -  # Unpack
 -  - cd dist && ./unpack.sh
 -  - cd buildstream
+-
    script:
    - useradd -Um buildstream
    - chown -R buildstream:buildstream .
@@ -83,7 +79,7 @@ source_dist:
    after_script:
    # Collect our reports
    - mkdir -p ${COVERAGE_DIR}
 -  - cp dist/buildstream/.coverage ${COVERAGE_DIR}/coverage."${CI_JOB_NAME}"
 +  - cp .coverage ${COVERAGE_DIR}/coverage."${CI_JOB_NAME}"
    except:
    - schedules
    artifacts:
@@ -91,23 +87,23 @@ source_dist:
      - ${COVERAGE_DIR}
  tests-debian-9:
 -  image: buildstream/testsuite-debian:9-master-123-7ce6581b
 +  image: buildstream/testsuite-debian:9-5da27168-32c47d1c
    <<: *tests
  tests-fedora-27:
 -  image: buildstream/testsuite-fedora:27-master-123-7ce6581b
 +  image: buildstream/testsuite-fedora:27-5da27168-32c47d1c
    <<: *tests
  tests-fedora-28:
 -  image: buildstream/testsuite-fedora:28-master-123-7ce6581b
 +  image: buildstream/testsuite-fedora:28-5da27168-32c47d1c
    <<: *tests
  tests-ubuntu-18.04:
 -  image: buildstream/testsuite-ubuntu:18.04-master-123-7ce6581b
 +  image: buildstream/testsuite-ubuntu:18.04-5da27168-32c47d1c
    <<: *tests
  overnight-fedora-28-aarch64:
 -  image: buildstream/testsuite-fedora:aarch64-28-master-123-7ce6581b
 +  image: buildstream/testsuite-fedora:aarch64-28-06bab030-32a101f6
    tags:
      - aarch64
    <<: *tests
@@ -120,7 +116,7 @@ overnight-fedora-28-aarch64:
  tests-unix:
    # Use fedora here, to a) run a test on fedora and b) ensure that we
    # can get rid of ostree - this is not possible with debian-8
 -  image: buildstream/testsuite-fedora:27-master-123-7ce6581b
 +  image: buildstream/testsuite-fedora:27-5da27168-32c47d1c
    <<: *tests
    variables:
      BST_FORCE_BACKEND: "unix"
@@ -140,7 +136,7 @@ tests-unix:
  tests-fedora-missing-deps:
    # Ensure that tests behave nicely while missing bwrap and ostree
 -  image: buildstream/testsuite-fedora:28-master-123-7ce6581b
 +  image: buildstream/testsuite-fedora:28-5da27168-32c47d1c
    <<: *tests
    script:
@@ -155,23 +151,28 @@ tests-fedora-missing-deps:
      - ${TEST_COMMAND}
 +# Lint separately from testing
 +lint:
 +  stage: test
++
 +  before_script:
 +  # Diagnostics
 +  - python3 --version
++
 +  script:
 +  - tox -e lint
 +  except:
 +  - schedules
  # Automatically build documentation for every commit, we want to know
  # if building documentation fails even if we're not deploying it.
 -# Note: We still do not enforce a consistent installation of python3-sphinx,
 -#       as it will significantly grow the backing image.
  docs:
    stage: test
 +  variables:
 +    BST_FORCE_SESSION_REBUILD: 1
    script:
 -  - export BST_SOURCE_CACHE="$(pwd)/cache/integration-cache/sources"
 -  # Currently sphinx_rtd_theme does not support Sphinx >1.8, this breaks search functionality
 -  - pip3 install sphinx==1.7.9
 -  - pip3 install sphinx-click
 -  - pip3 install sphinx_rtd_theme
 -  - cd dist && ./unpack.sh && cd buildstream
 -  - make BST_FORCE_SESSION_REBUILD=1 -C doc
 -  - cd ../..
 -  - mv dist/buildstream/doc/build/html public
 +  - env BST_SOURCE_CACHE="$(pwd)/cache/integration-cache/sources" tox -e docs
 +  - mv doc/build/html public
    except:
    - schedules
    artifacts:
@@ -275,6 +276,7 @@ coverage:
    coverage: '/TOTAL +\d+ +\d+ +(\d+\.\d+)%/'
    script:
      - cd dist && ./unpack.sh && cd buildstream
 +    - pip3 install -r tools/requirements.txt -r tools/dev-requirements.txt
      - pip3 install --no-index .
      - mkdir report
      - cd report

CONTRIBUTING.rst

@@ -1222,27 +1222,13 @@ For further information about using the reStructuredText with sphinx, please see
  Building Docs
  ~~~~~~~~~~~~~
 -The documentation build is not integrated into the ``setup.py`` and is
 -difficult (or impossible) to do so, so there is a little bit of setup
 -you need to take care of first.
+-
 -Before you can build the BuildStream documentation yourself, you need
 -to first install ``sphinx`` along with some additional plugins and dependencies,
 -using pip or some other mechanism::
+-
 -  # Install sphinx
 -  pip3 install --user sphinx
+-
 -  # Install some sphinx extensions
 -  pip3 install --user sphinx-click
 -  pip3 install --user sphinx_rtd_theme
+-
 -  # Additional optional dependencies required
 -  pip3 install --user arpy
 +Before you can build the docs, you will end to ensure that you have installed
 +the required :ref:`buid dependencies <contributing_build_deps>` as mentioned
 +in the testing section above.
  To build the documentation, just run the following::
 -  make -C doc
 +  tox -e docs
  This will give you a ``doc/build/html`` directory with the html docs which
  you can view in your browser locally to test.
@@ -1260,9 +1246,10 @@ will make the docs build reuse already downloaded sources::
    export BST_SOURCE_CACHE=~/.cache/buildstream/sources
 -To force rebuild session html while building the doc, simply build the docs like this::
 +To force rebuild session html while building the doc, simply run `tox` with the
 +``BST_FORCE_SESSION_REBUILD`` environment variable set, like so::
 -  make BST_FORCE_SESSION_REBUILD=1 -C doc
 +  env BST_FORCE_SESSION_REBUILD=1 tox -e docs
  Man pages
@@ -1468,57 +1455,123 @@ regenerate them locally in order to build the docs.
  Testing
  -------
 -BuildStream uses pytest for regression tests and testing out
 -the behavior of newly added components.
 +BuildStream uses `tox <https://tox.readthedocs.org/>`_ as a frontend to run the
 +tests which are implemented using `pytest <https://pytest.org/>`_. We use
 +pytest for regression tests and testing out the behavior of newly added
 +components.
  The elaborate documentation for pytest can be found here: http://doc.pytest.org/en/latest/contents.html
  Don't get lost in the docs if you don't need to, follow existing examples instead.
 +.. _contributing_build_deps:
++
 +Installing build dependencies
 +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 +Some of BuildStream's dependencies have non-python build dependencies. When
 +running tests with ``tox``, you will first need to install these dependencies.
 +Exact steps to install these will depend on your oprtation systemm. Commands
 +for installing them for some common distributions are lised below.
++
 +For Fedora-based systems::
++
 +  dnf install gcc pkg-config python3-devel cairo-gobject-devel glib2-devel gobject-introspection-devel
++
++
 +For Debian-based systems::
++
 +  apt install gcc pkg-config python3-dev libcairo2-dev libgirepository1.0-dev
++
++
  Running tests
  ~~~~~~~~~~~~~
 -To run the tests, just type::
 +To run the tests, simply navigate to the toplevel directory of your BuildStream
 +checkout and run::
++
 +  tox
++
 +By default, the test suite will be run against every supported python version
 +found on your host. If you have multiple python versions installed, you may
 +want to run tests against only one version and you can do that using the ``-e``
 +option when running tox::
 -  ./setup.py test
 +  tox -e py37
 -At the toplevel.
 +Linting is performed separately from testing. In order to run the linting step which
 +consists of running the ``pycodestyle`` and ``pylint`` tools, run the following::
 -When debugging a test, it can be desirable to see the stdout
 -and stderr generated by a test, to do this use the ``--addopts``
 -function to feed arguments to pytest as such::
 +  tox -e lint
 -  ./setup.py test --addopts -s
 +.. tip::
++
 +   The project specific pylint and pycodestyle configurations are stored in the
 +   toplevel buildstream directory in the ``.pylintrc`` file and ``setup.cfg`` files
 +   respectively. These configurations can be interesting to use with IDEs and
 +   other developer tooling.
++
 +The output of all failing tests will always be printed in the summary, but
 +if you want to observe the stdout and stderr generated by a passing test,
 +you can pass the ``-s`` option to pytest as such::
++
 +  tox -- -s
++
 +.. tip::
++
 +   The ``-s`` option is `a pytest option <https://docs.pytest.org/latest/usage.html>`_.
++
 +   Any options specified before the ``--`` separator are consumed by ``tox``,
 +   and any options after the ``--`` separator will be passed along to pytest.
  You can always abort on the first failure by running::
 -  ./setup.py test --addopts -x
 +  tox -- -x
  If you want to run a specific test or a group of tests, you
  can specify a prefix to match. E.g. if you want to run all of
  the frontend tests you can do::
 -  ./setup.py test --addopts 'tests/frontend/'
 +  tox -- tests/frontend/
  Specific tests can be chosen by using the :: delimeter after the test module.
  If you wanted to run the test_build_track test within frontend/buildtrack.py you could do::
 -  ./setup.py test --addopts 'tests/frontend/buildtrack.py::test_build_track'
 +  tox -- tests/frontend/buildtrack.py::test_build_track
  We also have a set of slow integration tests that are disabled by
  default - you will notice most of them marked with SKIP in the pytest
  output. To run them, you can use::
 -  ./setup.py test --addopts '--integration'
 +  tox -- --integration
 -By default, buildstream also runs pylint on all files. Should you want
 -to run just pylint (these checks are a lot faster), you can do so
 -with::
 +In case BuildStream's dependencies were updated since you last ran the
 +tests, you might see some errors like
 +``pytest: error: unrecognized arguments: --codestyle``. If this happens, you
 +will need to force ``tox`` to recreate the test environment(s). To do so, you
 +can run ``tox`` with ``-r`` or  ``--recreate`` option.
++
 +.. note::
++
 +   By default, we do not allow use of site packages in our ``tox``
 +   confguration to enable running the tests in an isolated environment.
 +   If you need to enable use of site packages for whatever reason, you can
 +   do so by passing the ``--sitepackages`` option to ``tox``. Also, you will
 +   not need to install any of the build dependencies mentioned above if you
 +   use this approach.
++
 +.. note::
++
 +   While using ``tox`` is practical for developers running tests in
 +   more predictable execution environments, it is still possible to
 +   execute the test suite against a specific installation environment
 +   using pytest directly::
++
 +     ./setup.py test
 -  ./setup.py test --addopts '-m pylint'
 +   Specific options can be passed to ``pytest`` using the ``--addopts``
 +   option::
 -Alternatively, any IDE plugin that uses pytest should automatically
 -detect the ``.pylintrc`` in the project's root directory.
 +     ./setup.py test --addopts 'tests/frontend/buildtrack.py::test_build_track'
  Adding tests

MANIFEST.in

@@ -24,6 +24,7 @@ recursive-include doc/sessions *.run
  # Tests
  recursive-include tests *
  include conftest.py
 +include tox.ini
  include .coveragerc
  include .pylintrc
@@ -31,7 +32,12 @@ include .pylintrc
  recursive-include buildstream/_protos *.proto
  # Requirements files
 -include dev-requirements.txt
 +include tools/requirements.in
 +include tools/requirements.txt
 +include tools/dev-requirements.in
 +include tools/dev-requirements.txt
 +include tools/plugin-requirements.in
 +include tools/plugin-requirements.txt
  # Versioneer
  include versioneer.py

buildstream/_context.py

@@ -34,6 +34,7 @@ from ._artifactcache import ArtifactCache
  from ._artifactcache.cascache import CASCache
  from ._workspaces import Workspaces, WorkspaceProjectCache, WORKSPACE_PROJECT_FILE
  from .plugin import _plugin_lookup
 +from .sandbox import SandboxRemote
  # Context()
@@ -72,6 +73,9 @@ class Context():
          # The locations from which to push and pull prebuilt artifacts
          self.artifact_cache_specs = None
 +        # The global remote execution configuration
 +        self.remote_execution_specs = None
++
          # The directory to store build logs
          self.logdir = None
@@ -187,7 +191,7 @@ class Context():
          _yaml.node_validate(defaults, [
              'sourcedir', 'builddir', 'artifactdir', 'logdir',
              'scheduler', 'artifacts', 'logging', 'projects',
 -            'cache', 'prompt', 'workspacedir',
 +            'cache', 'prompt', 'workspacedir', 'remote-execution'
          ])
          for directory in ['sourcedir', 'builddir', 'artifactdir', 'logdir', 'workspacedir']:
@@ -212,6 +216,8 @@ class Context():
          # Load artifact share configuration
          self.artifact_cache_specs = ArtifactCache.specs_from_config_node(defaults)
 +        self.remote_execution_specs = SandboxRemote.specs_from_config_node(defaults)
++
          # Load pull build trees configuration
          self.pull_buildtrees = _yaml.node_get(cache, bool, 'pull-buildtrees')
@@ -271,7 +277,8 @@ class Context():
          # Shallow validation of overrides, parts of buildstream which rely
          # on the overrides are expected to validate elsewhere.
          for _, overrides in _yaml.node_items(self._project_overrides):
 -            _yaml.node_validate(overrides, ['artifacts', 'options', 'strict', 'default-mirror'])
 +            _yaml.node_validate(overrides, ['artifacts', 'options', 'strict', 'default-mirror',
 +                                            'remote-execution'])
          profile_end(Topics.LOAD_CONTEXT, 'load')

buildstream/_frontend/cli.py

@@ -719,6 +719,11 @@ def source_fetch(app, elements, deps, track_, except_, track_cross_junctions):
          deps = PipelineSelection.ALL
      with app.initialized(session_name="Fetch"):
 +        if not elements:
 +            guessed_target = app.context.guess_element()
 +            if guessed_target:
 +                elements = (guessed_target,)
++
          app.stream.fetch(elements,
                           selection=deps,
                           except_targets=except_,
@@ -755,6 +760,11 @@ def source_track(app, elements, deps, except_, cross_junctions):
          all:   All dependencies of all specified elements
      """
      with app.initialized(session_name="Track"):
 +        if not elements:
 +            guessed_target = app.context.guess_element()
 +            if guessed_target:
 +                elements = (guessed_target,)
++
          # Substitute 'none' for 'redirect' so that element redirections
          # will be done
          if deps == 'none':

buildstream/_frontend/complete.py

@@ -31,7 +31,7 @@
  #  (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  #  OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ #
 -import collections
 +import collections.abc
  import copy
  import os
@@ -218,7 +218,7 @@ def is_incomplete_argument(current_params, cmd_param):
          return True
      if cmd_param.nargs == -1:
          return True
 -    if isinstance(current_param_values, collections.Iterable) \
 +    if isinstance(current_param_values, collections.abc.Iterable) \
              and cmd_param.nargs > 1 and len(current_param_values) < cmd_param.nargs:
          return True
      return False

buildstream/_ostree.py

@@ -34,7 +34,7 @@ from ._exceptions import BstError, ErrorDomain
  # pylint: disable=wrong-import-position,wrong-import-order
  gi.require_version('OSTree', '1.0')
 -from gi.repository import GLib, Gio, OSTree  # nopep8
 +from gi.repository import GLib, Gio, OSTree  # noqa
  # For users of this file, they must expect (except) it.

buildstream/_project.py

@@ -507,7 +507,16 @@ class Project():
          self.artifact_cache_specs = ArtifactCache.specs_from_config_node(config, self.directory)
          # Load remote-execution configuration for this project
 -        self.remote_execution_specs = SandboxRemote.specs_from_config_node(config, self.directory)
 +        project_specs = SandboxRemote.specs_from_config_node(config, self.directory)
 +        override_specs = SandboxRemote.specs_from_config_node(
 +            self._context.get_overrides(self.name), self.directory)
++
 +        if override_specs is not None:
 +            self.remote_execution_specs = override_specs
 +        elif project_specs is not None:
 +            self.remote_execution_specs = project_specs
 +        else:
 +            self.remote_execution_specs = self._context.remote_execution_specs
          # Load sandbox environment variables
          self.base_environment = _yaml.node_get(config, Mapping, 'environment')

buildstream/_signals.py

@@ -38,7 +38,7 @@ def terminator_handler(signal_, frame):
          terminator_ = terminator_stack.pop()
          try:
              terminator_()
 -        except:                                                 # pylint: disable=bare-except
 +        except:                               # noqa pylint: disable=bare-except
              # Ensure we print something if there's an exception raised when
              # processing the handlers. Note that the default exception
              # handler won't be called because we os._exit next, so we must

buildstream/_yaml.py

@@ -287,7 +287,7 @@ def node_decorate_dict(filename, target, source, toplevel):
          provenance.members[key] = member
          target_value = target.get(key)
 -        if isinstance(value, collections.Mapping):
 +        if isinstance(value, collections.abc.Mapping):
              node_decorate_dict(filename, target_value, value, toplevel)
          elif isinstance(value, list):
              member.elements = node_decorate_list(filename, target_value, value, toplevel)
@@ -302,7 +302,7 @@ def node_decorate_list(filename, target, source, toplevel):
          target_item = target[idx]
          element = ElementProvenance(filename, source, idx, toplevel)
 -        if isinstance(item, collections.Mapping):
 +        if isinstance(item, collections.abc.Mapping):
              node_decorate_dict(filename, target_item, item, toplevel)
          elif isinstance(item, list):
              element.elements = node_decorate_list(filename, target_item, item, toplevel)
@@ -578,7 +578,7 @@ def is_ruamel_str(value):
+ #
  def is_composite_list(node):
 -    if isinstance(node, collections.Mapping):
 +    if isinstance(node, collections.abc.Mapping):
          has_directives = False
          has_keys = False
@@ -847,7 +847,7 @@ def composite_dict(target, source, path=None):
          target_value = target.get(key)
 -        if isinstance(source_value, collections.Mapping):
 +        if isinstance(source_value, collections.abc.Mapping):
              # Handle creating new dicts on target side
              if target_value is None:
@@ -862,7 +862,7 @@ def composite_dict(target, source, path=None):
                  # Add a new provenance member element to the containing dict
                  target_provenance.members[key] = source_provenance.members[key]
 -            if not isinstance(target_value, collections.Mapping):
 +            if not isinstance(target_value, collections.abc.Mapping):
                  raise CompositeTypeError(thispath, type(target_value), type(source_value))
              # Recurse into matching dictionary
@@ -923,7 +923,7 @@ RoundTripRepresenter.add_representer(SanitizedDict,
+ #
  def node_sanitize(node):
 -    if isinstance(node, collections.Mapping):
 +    if isinstance(node, collections.abc.Mapping):
          result = SanitizedDict()
@@ -1067,7 +1067,7 @@ class ChainMap(collections.ChainMap):
  def node_chain_copy(source):
      copy = ChainMap({}, source)
      for key, value in source.items():
 -        if isinstance(value, collections.Mapping):
 +        if isinstance(value, collections.abc.Mapping):
              copy[key] = node_chain_copy(value)
          elif isinstance(value, list):
              copy[key] = list_chain_copy(value)
@@ -1080,7 +1080,7 @@ def node_chain_copy(source):
  def list_chain_copy(source):
      copy = []
      for item in source:
 -        if isinstance(item, collections.Mapping):
 +        if isinstance(item, collections.abc.Mapping):
              copy.append(node_chain_copy(item))
          elif isinstance(item, list):
              copy.append(list_chain_copy(item))
@@ -1095,7 +1095,7 @@ def list_chain_copy(source):
  def node_copy(source):
      copy = {}
      for key, value in source.items():
 -        if isinstance(value, collections.Mapping):
 +        if isinstance(value, collections.abc.Mapping):
              copy[key] = node_copy(value)
          elif isinstance(value, list):
              copy[key] = list_copy(value)
@@ -1112,7 +1112,7 @@ def node_copy(source):
  def list_copy(source):
      copy = []
      for item in source:
 -        if isinstance(item, collections.Mapping):
 +        if isinstance(item, collections.abc.Mapping):
              copy.append(node_copy(item))
          elif isinstance(item, list):
              copy.append(list_copy(item))
@@ -1147,7 +1147,7 @@ def node_final_assertions(node):
              raise LoadError(LoadErrorReason.TRAILING_LIST_DIRECTIVE,
                              "{}: Attempt to override non-existing list".format(provenance))
 -        if isinstance(value, collections.Mapping):
 +        if isinstance(value, collections.abc.Mapping):
              node_final_assertions(value)
          elif isinstance(value, list):
              list_final_assertions(value)
@@ -1155,7 +1155,7 @@ def node_final_assertions(node):
  def list_final_assertions(values):
      for value in values:
 -        if isinstance(value, collections.Mapping):
 +        if isinstance(value, collections.abc.Mapping):
              node_final_assertions(value)
          elif isinstance(value, list):
              list_final_assertions(value)

buildstream/element.py

@@ -1568,7 +1568,7 @@ class Element(Plugin):
                  utils._force_rmtree(rootdir)
              with _signals.terminator(cleanup_rootdir), \
 -                self.__sandbox(rootdir, output_file, output_file, self.__sandbox_config) as sandbox:  # nopep8
 +                self.__sandbox(rootdir, output_file, output_file, self.__sandbox_config) as sandbox:  # noqa
                  # By default, the dynamic public data is the same as the static public data.
                  # The plugin's assemble() method may modify this, though.

buildstream/sandbox/_sandboxremote.py

@@ -62,10 +62,32 @@ class SandboxRemote(Sandbox):
          self.storage_url = config.storage_service['url']
          self.exec_url = config.exec_service['url']
 +        exec_certs = {}
 +        for key in ['client-cert', 'client-key', 'server-cert']:
 +            if key in config.exec_service:
 +                with open(config.exec_service[key], 'rb') as f:
 +                    exec_certs[key] = f.read()
++
 +        self.exec_credentials = grpc.ssl_channel_credentials(
 +            root_certificates=exec_certs.get('server-cert'),
 +            private_key=exec_certs.get('client-key'),
 +            certificate_chain=exec_certs.get('client-cert'))
++
 +        action_certs = {}
 +        for key in ['client-cert', 'client-key', 'server-cert']:
 +            if key in config.action_service:
 +                with open(config.action_service[key], 'rb') as f:
 +                    action_certs[key] = f.read()
++
          if config.action_service:
              self.action_url = config.action_service['url']
 +            self.action_credentials = grpc.ssl_channel_credentials(
 +                root_certificates=action_certs.get('server-cert'),
 +                private_key=action_certs.get('client-key'),
 +                certificate_chain=action_certs.get('client-cert'))
          else:
              self.action_url = None
 +            self.action_credentials = None
          self.server_instance = config.exec_service.get('instance', None)
          self.storage_instance = config.storage_service.get('instance', None)
@@ -81,7 +103,7 @@ class SandboxRemote(Sandbox):
          self._get_context().message(Message(None, MessageType.INFO, msg))
      @staticmethod
 -    def specs_from_config_node(config_node, basedir):
 +    def specs_from_config_node(config_node, basedir=None):
          def require_node(config, keyname):
              val = config.get(keyname)
@@ -109,10 +131,10 @@ class SandboxRemote(Sandbox):
          remote_exec_storage_config = require_node(remote_config, 'storage-service')
          remote_exec_action_config = remote_config.get('action-cache-service', {})
 -        _yaml.node_validate(remote_exec_service_config, ['url', 'instance'])
 +        _yaml.node_validate(remote_exec_service_config, ['url', 'instance'] + tls_keys)
          _yaml.node_validate(remote_exec_storage_config, ['url', 'instance'] + tls_keys)
          if remote_exec_action_config:
 -            _yaml.node_validate(remote_exec_action_config, ['url'])
 +            _yaml.node_validate(remote_exec_action_config, ['url'] + tls_keys)
          else:
              remote_config['action-service'] = None
@@ -135,6 +157,19 @@ class SandboxRemote(Sandbox):
                                        "remote-execution configuration. Your config is missing '{}'."
                                        .format(str(provenance), tls_keys, key))
 +        def resolve_path(path):
 +            if basedir and path:
 +                return os.path.join(basedir, path)
 +            else:
 +                return path
++
 +        for key in tls_keys:
 +            for d in (remote_config['execution-service'],
 +                      remote_config['storage-service'],
 +                      remote_exec_action_config):
 +                if key in d:
 +                    d[key] = resolve_path(d[key])
++
          spec = RemoteExecutionSpec(remote_config['execution-service'],
                                     remote_config['storage-service'],
                                     remote_exec_action_config)
@@ -295,6 +330,8 @@ class SandboxRemote(Sandbox):
                                 "for example: http://buildservice:50051.")
          if url.scheme == 'http':
              channel = grpc.insecure_channel('{}:{}'.format(url.hostname, url.port))
 +        elif url.scheme == 'https':
 +            channel = grpc.secure_channel('{}:{}'.format(url.hostname, url.port), self.exec_credentials)
          else:
              raise SandboxError("Remote execution currently only supports the 'http' protocol "
                                 "and '{}' was supplied.".format(url.scheme))
@@ -352,11 +389,11 @@ class SandboxRemote(Sandbox):
          if not url.port:
              raise SandboxError("You must supply a protocol and port number in the action-cache-service url, "
                                 "for example: http://buildservice:50051.")
 -        if not url.scheme == "http":
 -            raise SandboxError("Currently only support http for the action cache"
 -                               "and {} was supplied".format(url.scheme))
 +        if url.scheme == 'http':
 +            channel = grpc.insecure_channel('{}:{}'.format(url.hostname, url.port))
 +        elif url.scheme == 'https':
 +            channel = grpc.secure_channel('{}:{}'.format(url.hostname, url.port), self.action_credentials)
 -        channel = grpc.insecure_channel('{}:{}'.format(url.hostname, url.port))
          request = remote_execution_pb2.GetActionResultRequest(action_digest=action_digest)
          stub = remote_execution_pb2_grpc.ActionCacheStub(channel)
          try:

doc/Makefile

@@ -6,10 +6,10 @@
  # we dont use the standard `sphinx-build` and `sphinx-apidoc` entry points.
+ #
  # The following technique works as long as sphinx is installed for python3,
 -# regardless of the entry point which might be in /usr/bin or PATH, but
 -# will stop working in sphinx >= 2.0. Hopefully by then, the mentioned
 -# bug will be fixed and we can use a standard python3 specific script to
 -# invoke sphnix.
 +# regardless of the entry point which might be in /usr/bin or PATH.
 +#
 +# Since Sphinx 2.0 is planned to be Python 3-only, this workaround should not
 +# be needed once Spinx 2.0 is released, and we upgrade to it
+ #
  SPHINXOPTS    =
  SPHINXBUILD   = python3 -m sphinx

doc/source/format_project.rst

@@ -218,6 +218,7 @@ The use of ports are required to distinguish between pull only access and
  push/pull access. For information regarding the server/client certificates
  and keys, please see: :ref:`Key pair for the server <server_authentication>`.
 +.. _project_remote_execution:
  Remote execution
  ~~~~~~~~~~~~~~~~
@@ -243,9 +244,6 @@ using the `remote-execution` option:
      action-cache-service:
        url: http://bar.action.com:50052
 -The execution-service part of remote execution does not support encrypted
 -connections yet, so the protocol must always be http.
+-
  storage-service specifies a remote CAS store and the parameters are the
  same as those used to specify an :ref:`artifact server <artifacts>`.
@@ -268,6 +266,9 @@ instance names.
  The Remote Execution API can be found via https://github.com/bazelbuild/remote-apis.
 +Remote execution configuration can be also provided in the `user
 +configuration <user_config_remote_execution>`.
++
  .. _project_essentials_mirrors:
  Mirrors

doc/source/using_config.rst

@@ -100,6 +100,54 @@ pull only access and push/pull access. For information regarding this and the
  server/client certificates and keys, please see:
  :ref:`Key pair for the server <server_authentication>`.
 +.. _user_config_remote_execution:
++
 +Remote execution
 +~~~~~~~~~~~~~~~~
++
 +The same configuration for :ref:`remote execution <project_remote_execution>`
 +in ``project.conf`` can be provided in the user configuation.
++
 +There is only one remote execution configuration used per project.
++
 +The project overrides will be taken in priority. The global
 +configuration will be used as fallback.
++
 +1. Global remote execution fallback:
++
 +.. code:: yaml
++
 +  remote-execution:
 +    execution-service:
 +      url: http://execution.fallback.example.com:50051
 +      instance-name: main
 +    storage-service:
 +      url: https://storage.fallback.example.com:11002/
 +      server-cert: /keys/server.crt
 +      client-cert: /keys/client.crt
 +      client-key: /keys/client.key
 +      instance-name: main
 +    action-cache-service:
 +      url: http://action.flalback.example.com:50052
++
 +2. Project override:
++
 +.. code:: yaml
++
 +  projects:
 +    some_project:
 +      remote-execution:
 +        execution-service:
 +          url: http://execution.some_project.example.com:50051
 +          instance-name: main
 +        storage-service:
 +          url: https://storage.some_project.example.com:11002/
 +          server-cert: /some_project_keys/server.crt
 +          client-cert: /some_project_keys/client.crt
 +          client-key: /some_project_keys/client.key
 +          instance-name: main
 +        action-cache-service:
 +          url: http://action.some_project.example.com:50052
  Strict build plan

setup.cfg

@@ -11,20 +11,13 @@ parentdir_prefix = BuildStream-
  test=pytest
  [tool:pytest]
 -addopts = --verbose --basetemp ./tmp --pep8 --pylint --pylint-rcfile=.pylintrc --cov=buildstream --cov-config .coveragerc --durations=20
 +addopts = --verbose --basetemp ./tmp --cov=buildstream --cov-config .coveragerc --durations=20
  norecursedirs = tests/integration/project integration-cache tmp __pycache__ .eggs
  python_files = tests/*/*.py
 -pep8maxlinelength = 119
 -pep8ignore =
 -    * E129
 -    * E125
 -    doc/source/conf.py ALL
 -    tmp/* ALL
 -    */lib/python3* ALL
 -    */bin/* ALL
 -    buildstream/_fuse/fuse.py ALL
 -    .eggs/* ALL
 -    *_pb2.py ALL
 -    *_pb2_grpc.py ALL
  env =
      D:BST_TEST_SUITE=True
++
 +[pycodestyle]
 +max-line-length = 119
 +ignore = E129,E125,W504,W605
 +exclude = .git/**,.tox/**,doc/source/conf.py,buildstream/_fuse/fuse.py,buildstream/_protos/**/*py

setup.py

@@ -270,9 +270,12 @@ def get_cmdclass():
  #####################################################
  #               Gather requirements                 #
  #####################################################
 -with open('dev-requirements.txt') as dev_reqs:
 +with open('tools/dev-requirements.in') as dev_reqs:
      dev_requires = dev_reqs.read().splitlines()
 +with open('tools/requirements.in') as install_reqs:
 +    install_requires = install_reqs.read().splitlines()
++
  #####################################################
  #     Prepare package description from README       #
  #####################################################
@@ -334,23 +337,7 @@ setup(name='BuildStream',
                os.path.join('buildstream', 'data', 'bst')
            ])
        ],
 -      install_requires=[
 -          'setuptools',
 -          'psutil',
 -          # According to ruamel.yaml's PyPI page, we are suppose to use
 -          # "<=0.15" in production until 0.15 becomes API stable.
 -          # However we need ruamel.yaml 0.15.41 or greater for Python 3.7.
 -          # We know that ruamel.yaml 0.15.52 breaks API in a way that
 -          # is incompatible with BuildStream.
 -          #
 -          # See issues #571 and #790.
 -          'ruamel.yaml >= 0.15.41, < 0.15.52',
 -          'pluginbase',
 -          'Click >= 7.0',
 -          'jinja2 >= 2.10',
 -          'protobuf >= 3.5',
 -          'grpcio >= 1.10',
 -      ],
 +      install_requires=install_requires,
        entry_points=bst_install_entry_points,
        tests_require=dev_requires,
        zip_safe=False)

tests/frontend/buildcheckout.py

@@ -3,6 +3,7 @@ import tarfile
  import hashlib
  import pytest
  from tests.testutils import cli, create_repo, ALL_REPO_KINDS, generate_junction
 +from tests.testutils.site import IS_WINDOWS
  from buildstream import _yaml
  from buildstream._exceptions import ErrorDomain, LoadErrorReason
@@ -85,16 +86,37 @@ def test_build_invalid_suffix_dep(datafiles, cli, strict, hardlinks):
      result.assert_main_error(ErrorDomain.LOAD, "bad-element-suffix")
 +@pytest.mark.skipif(IS_WINDOWS, reason='Not available on Windows')
  @pytest.mark.datafiles(DATA_DIR)
  def test_build_invalid_filename_chars(datafiles, cli):
      project = os.path.join(datafiles.dirname, datafiles.basename)
 -    result = cli.run(project=project, args=strict_args(['build', 'invalid-chars|<>-in-name.bst'], 'non-strict'))
 +    element_name = 'invalid-chars|<>-in-name.bst'
++
 +    # The name of this file contains characters that are not allowed by
 +    # BuildStream, using it should raise a warning.
 +    element = {
 +        'kind': 'stack',
 +    }
 +    _yaml.dump(element, os.path.join(project, 'elements', element_name))
++
 +    result = cli.run(project=project, args=strict_args(['build', element_name], 'non-strict'))
      result.assert_main_error(ErrorDomain.LOAD, "bad-characters-in-name")
 +@pytest.mark.skipif(IS_WINDOWS, reason='Not available on Windows')
  @pytest.mark.datafiles(DATA_DIR)
  def test_build_invalid_filename_chars_dep(datafiles, cli):
      project = os.path.join(datafiles.dirname, datafiles.basename)
 +    element_name = 'invalid-chars|<>-in-name.bst'
++
 +    # The name of this file contains characters that are not allowed by
 +    # BuildStream, and is listed as a dependency of 'invalid-chars-in-dep.bst'.
 +    # This should also raise a warning.
 +    element = {
 +        'kind': 'stack',
 +    }
 +    _yaml.dump(element, os.path.join(project, 'elements', element_name))
++
      result = cli.run(project=project, args=strict_args(['build', 'invalid-chars-in-dep.bst'], 'non-strict'))
      result.assert_main_error(ErrorDomain.LOAD, "bad-characters-in-name")

tests/frontend/project/elements/invalid-chars|<>-in-name.bst deleted

 -kind: stack
 -description: |
 -  The name of this files contains characters that are not allowed by
 -  BuildStream, using it should raise a warning.

tests/testutils/http_server.py

@@ -29,7 +29,7 @@ class RequestHandler(SimpleHTTPRequestHandler):
                  expected_password, directory = self.server.users[user]
                  if password == expected_password:
                      return directory
 -            except:
 +            except:                           # noqa
                  raise Unauthorized('unauthorized')
              return None

tests/testutils/site.py

@@ -52,5 +52,6 @@ except ImportError:
      HAVE_ARPY = False
  IS_LINUX = os.getenv('BST_FORCE_BACKEND', sys.platform).startswith('linux')
 +IS_WINDOWS = (os.name == 'nt')
  MACHINE_ARCH = Platform.get_host_arch()

dev-requirements.txt → tools/dev-requirements.in

  coverage == 4.4.0
 -pep8
  pylint
 +pycodestyle
  pytest >= 3.9
  pytest-cov >= 2.5.0
  pytest-datafiles >= 2.0
  pytest-env
 -pytest-pep8
 -pytest-pylint
  pytest-xdist
  pytest-timeout
  pyftpdlib

tools/dev-requirements.txt

 +coverage==4.4
 +pylint==2.2.2
 +pycodestyle==2.4.0
 +pytest==4.0.2
 +pytest-cov==2.6.0
 +pytest-datafiles==2.0
 +pytest-env==0.6.2
 +pytest-xdist==1.25.0
 +pytest-timeout==1.3.3
 +pyftpdlib==1.5.4
 +## The following requirements were added by pip freeze:
 +apipkg==1.5
 +astroid==2.1.0
 +atomicwrites==1.2.1
 +attrs==18.2.0
 +execnet==1.5.0
 +isort==4.3.4
 +lazy-object-proxy==1.3.1
 +mccabe==0.6.1
 +more-itertools==5.0.0
 +pluggy==0.8.0
 +py==1.7.0
 +pytest-forked==0.2
 +six==1.12.0
 +wrapt==1.10.11

tools/plugin-requirements.in

	1	+arpy
	2	+PyGObject

tools/plugin-requirements.txt

 +arpy==1.1.1
 +PyGObject==3.30.4
 +## The following requirements were added by pip freeze:
 +pycairo==1.18.0

tools/requirements.in

 +Click
 +grpcio >= 1.10
 +Jinja2 >= 2.10
 +pluginbase
 +protobuf >= 3.5
 +psutil
 +# According to ruamel.yaml's PyPI page, we are suppose to use
 +# "<=0.15" in production until 0.15 becomes API stable.
 +# However we need ruamel.yaml 0.15.41 or greater for Python 3.7.
 +# We know that ruamel.yaml 0.15.52 breaks API in a way that
 +# is incompatible with BuildStream.
 +#
 +# See issues #571 and #790.
 +ruamel.yaml >= 0.15.41, < 0.15.52
 +setuptools

tools/requirements.txt

 +Click==7.0
 +grpcio==1.17.1
 +Jinja2==2.10
 +pluginbase==0.7
 +protobuf==3.6.1
 +psutil==5.4.8
 +# According to ruamel.yaml's PyPI page, we are suppose to use
 +# "<=0.15" in production until 0.15 becomes API stable.
 +# However we need ruamel.yaml 0.15.41 or greater for Python 3.7.
 +# We know that ruamel.yaml 0.15.52 breaks API in a way that
 +# is incompatible with BuildStream.
 +#
 +# See issues #571 and #790.
 +ruamel.yaml==0.15.51
 +setuptools==39.0.1
 +## The following requirements were added by pip freeze:
 +MarkupSafe==1.1.0
 +six==1.12.0

tox.ini

 +[tox]
 +envlist = py35,py36,py37
 +skip_missing_interpreters = true
++
 +[testenv]
 +commands = pytest {posargs}
 +deps =
 +    -rtools/requirements.txt
 +    -rtools/dev-requirements.txt
 +    -rtools/plugin-requirements.txt
 +passenv =
 +    BST_FORCE_BACKEND
 +    GI_TYPELIB_PATH
 +    INTEGRATION_CACHE
++
 +[testenv:lint]
 +commands =
 +    pycodestyle
 +    pylint buildstream
 +deps =
 +    -rtools/requirements.txt
 +    -rtools/dev-requirements.txt
 +    -rtools/plugin-requirements.txt
++
 +[testenv:docs]
 +commands =
 +    make -C doc
 +# Currently sphinx_rtd_theme does not support Sphinx >1.8, this breaks search functionality
 +deps =
 +    sphinx==1.7.9
 +    sphinx-click
 +    sphinx_rtd_theme
 +    -rtools/requirements.txt
 +    -rtools/plugin-requirements.txt
 +passenv =
 +    BST_FORCE_SESSION_REBUILD
 +    BST_SOURCE_CACHE
 +    HOME
 +    LANG
 +    LC_ALL
 +whitelist_externals =
 +    make

[Notes] [Git][BuildStream/buildstream][valentindavid/remote_execution_configuration] 31 commits: doc/Makefile: Update comment about sphinx entrypoint

Valentin David pushed to branch valentindavid/remote_execution_configuration at BuildStream / buildstream

Commits:

29 changed files:

Changes: