[Notes] [Git][BuildStream/buildstream][jjardon/pycodestyle] 5 commits: U

Tristan Maat pushed to branch jjardon/pycodestyle at BuildStream / buildstream

Commits:

63d3c93a

by Javier Jardón at 2019-01-02T13:12:58Z

Use pycodestyle instead pep8

pep8 package was renamed to pycodestyle to reduce confusion.

2adbfd80

by Javier Jardón at 2019-01-02T13:13:04Z

setup.cfg: Ignore W605 and W504 for now

This is the current occurence:
40      W605 invalid escape sequence '\s'
75      W504 line break after binary operator

cf5970a7
by Javier Jardón at 2019-01-02T13:13:04Z
```
setup.cfg: Exclude non-code paths
```
24d013b8
by Javier Jardón at 2019-01-02T13:13:15Z
```
.gitlab-ci.yml: Install pytest-codestyle
```

1913da86

by Tristan Maat at 2019-01-02T13:13:28Z

.gitlab-ci.yml: Use new testsuite images with pycodestyle 1.4.0

Changes:

.gitlab-ci.yml

 -image: buildstream/testsuite-debian:9-master-119-552f5fc6
 +image: buildstream/testsuite-debian:9-06bab030-b848172c
  cache:
    key: "$CI_JOB_NAME-"
@@ -75,6 +75,7 @@ source_dist:
    script:
    - useradd -Um buildstream
    - chown -R buildstream:buildstream .
 +  - pip3 install pytest-codestyle
    # Run the tests from the source distribution, We run as a simple
    # user to test for permission issues
@@ -91,23 +92,23 @@ source_dist:
      - ${COVERAGE_DIR}
  tests-debian-9:
 -  image: buildstream/testsuite-debian:9-master-123-7ce6581b
 +  image: buildstream/testsuite-debian:9-06bab030-b848172c
    <<: *tests
  tests-fedora-27:
 -  image: buildstream/testsuite-fedora:27-master-123-7ce6581b
 +  image: buildstream/testsuite-fedora:27-06bab030-b848172c
    <<: *tests
  tests-fedora-28:
 -  image: buildstream/testsuite-fedora:28-master-123-7ce6581b
 +  image: buildstream/testsuite-fedora:28-06bab030-b848172c
    <<: *tests
  tests-ubuntu-18.04:
 -  image: buildstream/testsuite-ubuntu:18.04-master-123-7ce6581b
 +  image: buildstream/testsuite-ubuntu:18.04-06bab030-b848172c
    <<: *tests
  overnight-fedora-28-aarch64:
 -  image: buildstream/testsuite-fedora:aarch64-28-master-123-7ce6581b
 +  image: buildstream/testsuite-fedora:aarch64-28-06bab030-32a101f6
    tags:
      - aarch64
    <<: *tests
@@ -120,7 +121,7 @@ overnight-fedora-28-aarch64:
  tests-unix:
    # Use fedora here, to a) run a test on fedora and b) ensure that we
    # can get rid of ostree - this is not possible with debian-8
 -  image: buildstream/testsuite-fedora:27-master-123-7ce6581b
 +  image: buildstream/testsuite-fedora:27-06bab030-b848172c
    <<: *tests
    variables:
      BST_FORCE_BACKEND: "unix"
@@ -140,7 +141,7 @@ tests-unix:
  tests-fedora-missing-deps:
    # Ensure that tests behave nicely while missing bwrap and ostree
 -  image: buildstream/testsuite-fedora:28-master-119-552f5fc6
 +  image: buildstream/testsuite-fedora:28-06bab030-b848172c
    <<: *tests
    script:

buildstream/_ostree.py

@@ -34,7 +34,7 @@ from ._exceptions import BstError, ErrorDomain
  # pylint: disable=wrong-import-position,wrong-import-order
  gi.require_version('OSTree', '1.0')
 -from gi.repository import GLib, Gio, OSTree  # nopep8
 +from gi.repository import GLib, Gio, OSTree  # noqa
  # For users of this file, they must expect (except) it.

buildstream/_signals.py

@@ -38,7 +38,7 @@ def terminator_handler(signal_, frame):
          terminator_ = terminator_stack.pop()
          try:
              terminator_()
 -        except:                                                 # pylint: disable=bare-except
 +        except:                               # noqa pylint: disable=bare-except
              # Ensure we print something if there's an exception raised when
              # processing the handlers. Note that the default exception
              # handler won't be called because we os._exit next, so we must

buildstream/element.py

@@ -1547,7 +1547,7 @@ class Element(Plugin):
                  utils._force_rmtree(rootdir)
              with _signals.terminator(cleanup_rootdir), \
 -                self.__sandbox(rootdir, output_file, output_file, self.__sandbox_config) as sandbox:  # nopep8
 +                self.__sandbox(rootdir, output_file, output_file, self.__sandbox_config) as sandbox:  # noqa
                  # By default, the dynamic public data is the same as the static public data.
                  # The plugin's assemble() method may modify this, though.

dev-requirements.txt

  coverage == 4.4.0
 -pep8
  pylint == 2.1.1
  pytest >= 3.8
 +pytest-codestyle >= 1.4.0
  pytest-cov >= 2.5.0
  pytest-datafiles
  pytest-env
 -pytest-pep8
  pytest-pylint
  pytest-xdist
  pytest-timeout

setup.cfg

@@ -11,20 +11,11 @@ parentdir_prefix = BuildStream-
  test=pytest
  [tool:pytest]
 -addopts = --verbose --basetemp ./tmp --pep8 --pylint --pylint-rcfile=.pylintrc --cov=buildstream --cov-config .coveragerc --durations=20
 +addopts = --verbose --basetemp ./tmp --codestyle --pylint --pylint-rcfile=.pylintrc --cov=buildstream --cov-config .coveragerc --durations=20
  norecursedirs = tests/integration/project integration-cache tmp __pycache__ .eggs
  python_files = tests/*/*.py
 -pep8maxlinelength = 119
 -pep8ignore =
 -    * E129
 -    * E125
 -    doc/source/conf.py ALL
 -    tmp/* ALL
 -    */lib/python3* ALL
 -    */bin/* ALL
 -    buildstream/_fuse/fuse.py ALL
 -    .eggs/* ALL
 -    *_pb2.py ALL
 -    *_pb2_grpc.py ALL
 +codestyle_max_line_length = 119
 +codestyle_ignore = E129 E125 W504 W605
 +codestyle_exclude = doc/source/conf.py buildstream/_fuse/fuse.py buildstream/_protos/**/*py
  env =
      D:BST_TEST_SUITE=True

[Notes] [Git][BuildStream/buildstream][jjardon/pycodestyle] 5 commits: Use pycodestyle instead pep8

Tristan Maat pushed to branch jjardon/pycodestyle at BuildStream / buildstream

Commits:

6 changed files:

Changes: