[Notes] [Git][BuildStream/buildstream][master] 3 commits: tests/integration/shell.py: Skip test_isolated_no_mount without sandbox

[Jürg Billeter <gitlab mg gitlab com>]

Title: GitLab

Jürg Billeter pushed to branch master at BuildStream / buildstream

Commits:

• 1cd27edf
  by Jürg Billeter at 2019-02-19T13:19:43Z

  tests/integration/shell.py: Skip test_isolated_no_mount without sandbox
  
  This test passes without a sandbox but only because the exit code is
  also non-zero in that case. It didn't actually perform the desired test.
  
  This test is very slow on WSL, so let's skip it if there is no sandbox.
  

• 69675d22
  by Jürg Billeter at 2019-02-19T13:27:31Z

  tests/integration/shell.py: More asserts in test_isolated_no_mount
  
  This verifies that the command fails with the right error.
  

• 99764715
  by Jürg Billeter at 2019-02-19T15:03:58Z

  Merge branch 'juerg/shell-test' into 'master'
  
  tests/integration/shell.py: Improve test_isolated_no_mount
  
  See merge request BuildStream/buildstream!1163

1 changed file:

• tests/integration/shell.py

Changes:

tests/integration/shell.py

---

...	...	@@ -212,6 +212,7 @@ def test_host_files_expand_environ(cli, tmpdir, datafiles, path):
212	212	# Test that bind mounts defined in project.conf dont mount in isolation
213	213	@pytest.mark.parametrize("path", [("/etc/pony.conf"), ("/usr/share/pony/pony.txt")])
214	214	@pytest.mark.datafiles(DATA_DIR)
	215	+@pytest.mark.skipif(not HAVE_SANDBOX, reason='Only available with a functioning sandbox')
215	216	def test_isolated_no_mount(cli, tmpdir, datafiles, path):
216	217	project = os.path.join(datafiles.dirname, datafiles.basename)
217	218	ponyfile = os.path.join(project, 'files', 'shell-mount', 'pony.txt')
...	...	@@ -226,6 +227,8 @@ def test_isolated_no_mount(cli, tmpdir, datafiles, path):
226	227	}
227	228	})
228	229	assert result.exit_code != 0
	230	+ assert path in result.stderr
	231	+ assert 'No such file or directory' in result.stderr
229	232
230	233
231	234	# Test that we warn about non-existing files on the host if the mount is not

—
View it on GitLab.
You're receiving this email because of your account on gitlab.com. If you'd like to receive fewer emails, you can adjust your notification settings.