[Notes] [Git][BuildGrid/buildgrid][mablanch/160-docker-compose] scheduler.py: Unregister peer after internal cleanup

[Martin Blanchard <gitlab mg gitlab com>]

Title: GitLab

Martin Blanchard pushed to branch mablanch/160-docker-compose at BuildGrid / buildgrid

Commits:

• 14fc7888
  by Martin Blanchard at 2019-02-19T13:06:40Z

  scheduler.py: Unregister peer after internal cleanup
  
  This should prevent a race between delete_job_operation() and
  delete_job_lease() when dropping Job objects after execution.
  
  https://gitlab.com/BuildGrid/buildgrid/issues/160
  

1 changed file:

• buildgrid/server/scheduler.py

Changes:

buildgrid/server/scheduler.py

---

...	...	@@ -151,14 +151,14 @@ class Scheduler:
151	151	raise NotFoundError("Operation name does not exist: [{}]"
152	152	.format(operation_name))
153	153
154		- job.unregister_operation_peer(operation_name, peer)
155		-
156	154	if not job.n_peers_for_operation(operation_name):
157	155	del self.__jobs_by_operation[operation_name]
158	156
159	157	if not job.n_peers and job.done and not job.lease:
160	158	self._delete_job(job.name)
161	159
	160	+ job.unregister_operation_peer(operation_name, peer)
	161	+
162	162	def queue_job_action(self, action, action_digest, platform_requirements=None,
163	163	priority=0, skip_cache_lookup=False):
164	164	"""Inserts a newly created job into the execution queue.

—
View it on GitLab.
You're receiving this email because of your account on gitlab.com. If you'd like to receive fewer emails, you can adjust your notification settings.