[Notes] [Git][BuildStream/buildstream][master] 2 commits: Prevent caching when Element.stage() fails

[Jürg Billeter <gitlab mg gitlab com>]

Title: GitLab

Jürg Billeter pushed to branch master at BuildStream / buildstream

Commits:

• e2074693
  by Gökçen Nurlu at 2019-02-19T07:44:54Z

  Prevent caching when Element.stage() fails
  
  That step is not actually part of the build phase should not be cached and
  causes hard to find bugs.
  
  Fixes #791
  

• cfbe409d
  by Jürg Billeter at 2019-02-19T09:00:31Z

  Merge branch 'gokcennurlu/dont_cache_if_stage_fails' into 'master'
  
  Prevent caching when Element.stage() fails
  
  Closes #791
  
  See merge request BuildStream/buildstream!1012

1 changed file:

• buildstream/element.py

Changes:

buildstream/element.py

---

...	...	@@ -1620,12 +1620,12 @@ class Element(Plugin):
1620	1620	self.__dynamic_public = _yaml.node_copy(self.__public)
1621	1621
1622	1622	# Call the abstract plugin methods
1623		- try:
1624		- # Step 1 - Configure
1625		- self.__configure_sandbox(sandbox)
1626		- # Step 2 - Stage
1627		- self.stage(sandbox)
1628	1623
	1624	+ # Step 1 - Configure
	1625	+ self.__configure_sandbox(sandbox)
	1626	+ # Step 2 - Stage
	1627	+ self.stage(sandbox)
	1628	+ try:
1629	1629	if self.__batch_prepare_assemble:
1630	1630	cm = sandbox.batch(self.__batch_prepare_assemble_flags,
1631	1631	collect=self.__batch_prepare_assemble_collect)

—
View it on GitLab.
You're receiving this email because of your account on gitlab.com. If you'd like to receive fewer emails, you can adjust your notification settings.