[Notes] [Git][BuildStream/buildstream][tristan/collect-missing-coverage] 3 commits: requirements/Makefile: exclude pkg-resources

[Tristan Van Berkom <gitlab mg gitlab com>]

Title: GitLab

Tristan Van Berkom pushed to branch tristan/collect-missing-coverage at BuildStream / buildstream

Commits:

• e0f0a01d
  by Chandan Singh at 2019-02-18T12:41:31Z

  requirements/Makefile: exclude pkg-resources
  
  Having `pkg-resources` in requirements files is never the right thing as
  it is not really a package that one can install. This is basically an
  artifact of Debian-based systems providing incorrect metadata to pip.
  See [this pip issue](https://github.com/pypa/pip/issues/4022) and
  [this Ubuntu issue](https://bugs.launchpad.net/ubuntu/+source/python-pip/+bug/1635463)
  for more background.
  

• f149fed2
  by Tristan Van Berkom at 2019-02-18T13:43:28Z

  Merge branch 'chandan/remove-pkg-resources' into 'master'
  
  requirements/Makefile: exclude pkg-resources
  
  Closes #918
  
  See merge request BuildStream/buildstream!1156

• 4022234e
  by Tristan Van Berkom at 2019-02-18T13:44:29Z

  .gitlab-ci.yml: Some new test environments were added, but not collecting coverage.
  
  The test jobs which create coverage reports need to be listed
  in the dependencies of the coverage job, as highlighted in
  issue #356.
  

2 changed files:

• .gitlab-ci.yml
• requirements/Makefile

Changes:

.gitlab-ci.yml

---

...	...	@@ -281,10 +281,12 @@ coverage:
281	281	- tox -e coverage
282	282	- cp -a .coverage-reports/ ./coverage-report
283	283	dependencies:
	284	+ - tests-centos-7.6
284	285	- tests-debian-9
285	286	- tests-fedora-28
286	287	- tests-fedora-29
287	288	- tests-fedora-missing-deps
	289	+ - tests-fedora-update-deps
288	290	- tests-ubuntu-18.04
289	291	- tests-unix
290	292	except:

requirements/Makefile

---

...	...	@@ -17,5 +17,5 @@ all: $(REQUIREMENTS_TXT)
17	17	$(eval VENVDIR := $(shell mktemp -d $(CURDIR)/.bst-venv.XXXXXX))
18	18	$(VENV) $(VENVDIR)
19	19	$(VENV_PIP) install -r $^
20		- $(VENV_PIP) freeze -r $^ > $@
	20	+ $(VENV_PIP) freeze -r $^ | grep -v pkg-resources > $@
21	21	rm -rf $(VENVDIR)

—
View it on GitLab.
You're receiving this email because of your account on gitlab.com. If you'd like to receive fewer emails, you can adjust your notification settings.