[Notes] [Git][BuildStream/buildstream][bschubert/cleanup-local-state] Don't register exceptions when not running the testsuite

[Benjamin Schubert <gitlab mg gitlab com>]

Title: GitLab

Benjamin Schubert pushed to branch bschubert/cleanup-local-state at BuildStream / buildstream

Commits:

• 6c7f42c1
  by Benjamin Schubert at 2019-02-13T14:55:39Z

  Don't register exceptions when not running the testsuite
  
  This fix a problem with the garbage collector not being able to
  clean the MetaElements that are loaded.
  
  On small projects this is not a problem, but in bigger projects, this
  can save a few hundred of MBs at runtime
  
  The reason behind this is, whenever we have a "stack" element, which
  has no stack.yaml configuration, since it doesn't need it, we would
  get an exception thrown when initiating the first one, as loading the
  yaml file would fail.
  
  This would capture the frame in which this command was executed, which
  references meta_elements. Therefore, as long as another exception is not
  thrown, the garbage collector would not be able to clean all the
  MetaElements.
  

1 changed file:

• buildstream/_exceptions.py

Changes:

buildstream/_exceptions.py

---

...	...	@@ -19,6 +19,7 @@
19	19	# Tiago Gomes <tiago gomes codethink co uk>
20	20
21	21	from enum import Enum
	22	+import os
22	23
23	24	# Disable pylint warnings for whole file here:
24	25	# pylint: disable=global-statement
...	...	@@ -50,6 +51,9 @@ def get_last_exception():
50	51	# Used by regression tests
51	52	#
52	53	def get_last_task_error():
	54	+ if 'BST_TEST_SUITE' not in os.environ:
	55	+ raise BstError("Getting the last task error is only supported when running tests")
	56	+
53	57	global _last_task_error_domain
54	58	global _last_task_error_reason
55	59
...	...	@@ -67,11 +71,12 @@ def get_last_task_error():
67	71	# tests about how things failed in a machine readable way
68	72	#
69	73	def set_last_task_error(domain, reason):
70		- global _last_task_error_domain
71		- global _last_task_error_reason
	74	+ if 'BST_TEST_SUITE' in os.environ:
	75	+ global _last_task_error_domain
	76	+ global _last_task_error_reason
72	77
73		- _last_task_error_domain = domain
74		- _last_task_error_reason = reason
	78	+ _last_task_error_domain = domain
	79	+ _last_task_error_reason = reason
75	80
76	81
77	82	class ErrorDomain(Enum):
...	...	@@ -126,7 +131,8 @@ class BstError(Exception):
126	131	self.reason = reason
127	132
128	133	# Hold on to the last raised exception for testing purposes
129		- _last_exception = self
	134	+ if 'BST_TEST_SUITE' in os.environ:
	135	+ _last_exception = self
130	136
131	137
132	138	# PluginError

—
View it on GitLab.
You're receiving this email because of your account on gitlab.com. If you'd like to receive fewer emails, you can adjust your notification settings.