[Notes] [Git][BuildStream/buildstream][juerg/symlinks] 36 commits: testutils/site.py: Support parsing more exotic git versions

[Jürg Billeter <gitlab mg gitlab com>]

Title: GitLab

Jürg Billeter pushed to branch juerg/symlinks at BuildStream / buildstream

Commits:

• dd791373
  by Chandan Singh at 2019-01-31T14:32:44Z

  testutils/site.py: Support parsing more exotic git versions
  
  We use output of `git --version` to determine if we can run some tests
  that rely on features from newer git versions. Usually, we expect the
  output to be like:
  
      git version 2.17.2
  
  On some platforms, like MacOS, there could be a suffix after the version
  string, so that it looks something like:
  
      git version 2.17.2 (Apple Git-113)
  
  This causes things to fail like so:
  
      ValueError: invalid literal for int() with base 10: '2 (Apple Git-113)\n'
  
  Fix logic around `HAVE_OLD_GIT` such that we split the output of
  `git --version` without limit on how many times we split. Previously we
  used to split only twice so the suffixes like `(Apple Git-113)` are not
  part of the parsed version.
  

• 96c0fbd6
  by Chandan Singh at 2019-01-31T15:39:19Z

  Merge branch 'chandan/fix-git-version-mac' into 'master'
  
  testutils/site.py: Support parsing more exotic git versions
  
  See merge request BuildStream/buildstream!1118

• d25e2795
  by Benjamin Schubert at 2019-01-31T17:06:23Z

  Add LoadElement in dependency list for LoadElement idrectly
  
  This removes the need for the 'Dependency' list to then be matched
  with the corresponding LoadElement and will allow iterating the
  graph more easily
  

• 2d0eebbf
  by Benjamin Schubert at 2019-01-31T17:06:23Z

  Pass element directly to collect_element
  
  This simplifies the loading
  

• 583bd97d
  by Benjamin Schubert at 2019-02-01T10:26:37Z

  Merge branch 'bschubert/loader' into 'master'
  
  Cleanup loader by linking LoadElements sooner
  
  See merge request BuildStream/buildstream!1122

• 51cec3da
  by Phil Dawson at 2019-02-01T14:25:44Z

  tests/cachekey: Test cache keys are independent of target elements
  

• 2b38aabe
  by Phil Dawson at 2019-02-01T15:33:00Z

  Merge branch 'phil/cache-key-stability-test' into 'master'
  
  tests/cachekey: Test cache keys are independent of target elements
  
  See merge request BuildStream/buildstream!1123

• dbb3d232
  by James Ennis at 2019-02-01T15:51:32Z

  filter.py/filter.yaml: Documentation improvements
  

• 7e4205cb
  by James Ennis at 2019-02-01T15:51:32Z

  filter.py: Add an example to the documentation
  

• 4109a34a
  by James Ennis at 2019-02-01T17:11:29Z

  Merge branch 'jennis/filter-docs' into 'master'
  
  Improve our filter documentation
  
  Closes #278
  
  See merge request BuildStream/buildstream!1112

• c9345014
  by James Ennis at 2019-02-04T13:53:42Z

  filter.py: Fail if declared domains do not exist in the parent element
  
  This patch also uncovered the fact that our test_filter_deps_ok() test
  has been inaccurate. Thus the element built in this test
  (deps-permitted.bst) has been modified so that it build depends on the
  input.bst element, as it should.
  
  tests/filter.py: Ensure deps_ok test passes
  

• 3ab09651
  by James Ennis at 2019-02-04T14:47:43Z

  Merge branch 'jennis/warn_for_nonexistent_domains' into 'master'
  
  Fail when we explictly try to include/exclude non-existent domains in a filter element
  
  See merge request BuildStream/buildstream!1117

• cd8e5e27
  by Tom Pollard at 2019-02-05T11:22:01Z

  Add --remote, -r option to bst build, inline with pull & push
  
  Providing a remote will limit build's pull/push remote actions to
  the given remote specifically, ignoring those defined via user or
  project configuration.
  

• a46650d0
  by Tom Pollard at 2019-02-05T12:41:30Z

  Merge branch 'tpollard/buildremote' into 'master'
  
  Add --remote, -r option to bst build, inline with pull & push
  
  See merge request BuildStream/buildstream!1119

• 9c94e8e5
  by Daniel Silverstone at 2019-02-05T13:15:24Z

  requirements: Add roaringbitmap to the requirements
  
  In order to support use of roaring bitmaps in the loader, we need to
  depend on it here.
  
  Signed-off-by: Daniel Silverstone <daniel silverstone codethink co uk>
  

• 7682ef49
  by Daniel Silverstone at 2019-02-05T13:15:24Z

  loadelement.py: Use roaring bitmaps in dep cache
  
  The dependency cache in LoadElement causes the peak RAM consumption of
  the loader to be exceedingly large, upwards of 25GB for a test of a
  Debian stack.  By switching from the old dict cache to a roaring bitmap
  based cache, we reduce the cost of the loader cache in RAM terms to
  around 5.5GB for the same stack, which makes it plausible for the short
  term.
  
  Signed-off-by: Daniel Silverstone <daniel silverstone codethink co uk>
  

• 0e471144
  by Benjamin Schubert at 2019-02-05T15:45:37Z

  Merge branch 'danielsilverstone-ct/roaring-bitmaps' into 'master'
  
  Switch to roaring bitmaps for the loader dependency caches
  
  See merge request BuildStream/buildstream!1128

• f17ea6a6
  by Jonathan Maw at 2019-02-06T10:32:05Z

  gitlab-ci: Add commands to be run by WSL runners
  

• d4d2f897
  by Jonathan Maw at 2019-02-06T10:45:34Z

  tests: Skip tests that use sandboxes on WSL
  

• f4c8a0ec
  by Jonathan Maw at 2019-02-06T10:45:34Z

  tests: Fix test failures caused by unix sockets' path length limit
  
  The unix specification for unix sockets only allocates ~100 characters
  for the length of the path. This may be longer than the path for a CI
  runner, or the path to a user's buildstream directory.
  

• 256bcde5
  by Jonathan Maw at 2019-02-06T15:29:18Z

  Merge branch 'jonathan/wsl-tests' into 'master'
  
  Add pre-merge tests that use a WSL runner
  
  Closes #852
  
  See merge request BuildStream/buildstream!1108

• 335ef2b8
  by Daniel Silverstone at 2019-02-06T17:30:13Z

  loadelement.py: Switch from roaringbitmap to pyroaring
  
  The licence for roaringbitmap was not compatible.  pyroaring is
  a similar project which is MIT licensed and is slightly better on
  memory too.
  
  Signed-off-by: Daniel Silverstone <daniel silverstone codethink co uk>
  

• 8f90be91
  by Benjamin Schubert at 2019-02-06T18:36:17Z

  Update testing images to include c++ compiler
  

• 1a75b252
  by Benjamin Schubert at 2019-02-06T19:34:09Z

  Merge branch 'danielsilverstone-ct/other-roaring' into 'master'
  
  loadelement.py: Switch from roaringbitmap to pyroaring
  
  Closes #899
  
  See merge request BuildStream/buildstream!1133

• 7285e87e
  by William Salmon at 2019-02-07T09:42:36Z

  Add more log formatting options
  
  The 'wallclock-us' is a option that we thought we already had.
  

• e61f4713
  by Will Salmon at 2019-02-07T10:58:54Z

  Merge branch 'willsalmon/log_formating' into 'master'
  
  Add more log formatting options
  
  See merge request BuildStream/buildstream!1125

• b4d4c4f5
  by Phil Dawson at 2019-02-08T14:27:54Z

  Expose basic api for testing external plugins.
  
  We want external plugins to be able to make use of the core testing utils.
  This commit exposes the basic utilities which are currently in use in
  bst-external plugins. If necessary, more utilities could be exposed in the
  future.
  
  Moves the following files from tests/testutils/ to
  buildstream/plugintestingutils/:
  o runcli.py
  o integration.py
  
  As part of this, this commit makes the following changes to runcli.py
  and integration.py:
  o runcli.py: Fix linting errors
  o runcli.py: Add user facing documentation
  o Integration.py: Add user facing documentation
  

• 77ce0c16
  by Phil Dawson at 2019-02-08T16:28:05Z

  Merge branch 'phil/plugin-testing-api' into 'master'
  
  Expose basic api for testing external plugins.
  
  Closes #847
  
  See merge request BuildStream/buildstream!1075

• 1ee4a4ba
  by Abderrahim Kitouni at 2019-02-08T16:42:23Z

  _artifactcache.py: don't leak the project specific remote caches
  
  the code for initializing remotes added the project specific remote
  caches to the global list instead of making a copy.
  
  Fixes #618
  

• 24c0de16
  by Abderrahim Kitouni at 2019-02-08T16:42:23Z

  _project.py: use artifact caches from the parent project for junctions
  
  This makes a junction use the artifact cache of the parent project
  before the ones defined for the junction
  
  Fixes #401
  

• a937f99a
  by Javier Jardón at 2019-02-08T20:29:05Z

  Merge branch 'abderrahim/artifact-cache-junction' into 'master'
  
  Use artifact cache specs from the parent project before those defined in junctions
  
  Closes #618 and #401
  
  See merge request BuildStream/buildstream!1113

• a7c17169
  by Jürg Billeter at 2019-02-09T06:16:38Z

  local.py: Do not follow symlinks in local directories
  
  isdir() follows symlinks on the host, resulting in potential host
  contamination. This change reorders the file checks to avoid this issue.
  

• f4af343b
  by Jürg Billeter at 2019-02-09T06:16:38Z

  sandbox/sandbox.py: Do not follow symlinks in _has_command()
  
  This is required to ensure symlinks are not resolved on the host.
  

• 378868fc
  by Jürg Billeter at 2019-02-09T06:16:38Z

  utils.py: Remove list_dirs parameter from list_relative_paths()
  
  list_dirs was always True in the BuildStream code base. There was also a
  bug in the list_dirs=False code path as it did not return symlinks in
  `dirnames`.
  
  This is an API break, however, there are no known external callers.
  

• 505da955
  by Jürg Billeter at 2019-02-09T06:16:38Z

  utils.py: Fix sorting of symlinks to directories
  
  os.walk() resolves symlinks to check whether they point to a directory
  even when followlinks is set to False. We already work around that
  broken behavior by extracting symlinks from `dirnames`. However, the
  sort order was still incorrect as we returned symlinks in dirnames
  before files and other symlinks. This change fixes this, sorting all
  files and symlinks in a single list.
  

• a162ef1f
  by Jürg Billeter at 2019-02-09T06:16:38Z

  _casbaseddirectory.py: Do not mimic os.walk() in list_relative_paths()
  
  This matches the change in utils.list_relative_paths() that now sorts
  all symlinks as files, instead of following the broken behavior of
  os.walk().
  

30 changed files:

• .gitlab-ci.yml
• NEWS
• buildstream/_artifactcache.py
• buildstream/_frontend/cli.py
• buildstream/_frontend/widget.py
• buildstream/_loader/loadelement.py
• buildstream/_loader/loader.py
• buildstream/_project.py
• buildstream/_stream.py
• buildstream/plugins/elements/filter.py
• buildstream/plugins/elements/filter.yaml
• buildstream/plugins/sources/local.py
• + buildstream/plugintestutils/__init__.py
• tests/testutils/integration.py → buildstream/plugintestutils/integration.py
• tests/testutils/runcli.py → buildstream/plugintestutils/runcli.py
• buildstream/sandbox/sandbox.py
• buildstream/storage/_casbaseddirectory.py
• buildstream/utils.py
• requirements/requirements.in
• requirements/requirements.txt
• tests/artifactcache/cache_size.py
• tests/artifactcache/config.py
• tests/artifactcache/expiry.py
• tests/artifactcache/junctions.py
• tests/artifactcache/pull.py
• tests/artifactcache/push.py
• tests/cachekey/cachekey.py
• + tests/cachekey/project/elements/key-stability/aaa.bst
• + tests/cachekey/project/elements/key-stability/t1.bst
• + tests/cachekey/project/elements/key-stability/t2.bst

The diff was not included because it is too large.

—
View it on GitLab.
You're receiving this email because of your account on gitlab.com. If you'd like to receive fewer emails, you can adjust your notification settings.