[Notes] [Git][BuildStream/buildstream][master] 2 commits: Fix outside-of-project check when project path is not canonical.

[Tiago Gomes <gitlab mg gitlab com>]

Title: GitLab

Tiago Gomes pushed to branch master at BuildStream / buildstream

Commits:

• e91eb38b
  by Valentin David at 2018-09-27T16:32:57Z

  Fix outside-of-project check when project path is not canonical.
  
  The issue happens on Silverblue where /home is a symlink to /var/home.
  With this element-path is something like
  /var/home/user/project/elements, when the project path is
  /home/usr/project. Comparing canonical paths solves the issue.
  
  Fixes #673
  

• 7babd55c
  by Tiago Gomes at 2018-09-27T16:57:12Z

  Merge branch 'valentindavid/silverblue-path' into 'master'
  
  Fix outside-of-project check when project path is not canonical.
  
  Closes #673
  
  See merge request BuildStream/buildstream!832

2 changed files:

• buildstream/_yaml.py
• tests/format/project.py

Changes:

buildstream/_yaml.py

---

...	...	@@ -467,7 +467,7 @@ def node_get_project_path(node, key, project_dir, *,
467	467	"{}: Specified path '{}' does not exist"
468	468	.format(provenance, path_str))
469	469
470		- is_inside = project_dir_path in full_resolved_path.parents or (
	470	+ is_inside = project_dir_path.resolve() in full_resolved_path.parents or (
471	471	full_resolved_path == project_dir_path)
472	472
473	473	if path.is_absolute() or not is_inside:

tests/format/project.py

---

...	...	@@ -188,3 +188,15 @@ def test_project_refs_options(cli, datafiles):
188	188
189	189	# Assert that the cache keys are different
190	190	assert result1.output != result2.output
	191	+
	192	+
	193	+@pytest.mark.datafiles(os.path.join(DATA_DIR, 'element-path'))
	194	+def test_element_path_project_path_contains_symlinks(cli, datafiles, tmpdir):
	195	+ real_project = str(datafiles)
	196	+ linked_project = os.path.join(str(tmpdir), 'linked')
	197	+ os.symlink(real_project, linked_project)
	198	+ os.makedirs(os.path.join(real_project, 'elements'), exist_ok=True)
	199	+ with open(os.path.join(real_project, 'elements', 'element.bst'), 'w') as f:
	200	+ f.write("kind: manual\n")
	201	+ result = cli.run(project=linked_project, args=['show', 'element.bst'])
	202	+ result.assert_success()

—
View it on GitLab.
You're receiving this email because of your account on gitlab.com. If you'd like to receive fewer emails, you can adjust your notification settings.