[Notes] [Git][BuildStream/buildstream][willsalmon/outOfSourecBuild] 20 commits: _project.py: Fix option resolution in element & source overrides

[Will Salmon <gitlab mg gitlab com>]

Title: GitLab

Will Salmon pushed to branch willsalmon/outOfSourecBuild at BuildStream / buildstream

Commits:

• 727f2faa
  by Tristan Van Berkom at 2018-09-18T07:43:07Z

  _project.py: Fix option resolution in element & source overrides
  
  This ensures that option expressions are resolved in the project
  level overrides before attempting to composite them on the instantiated
  elements. Seems this is a regression from introducing the include
  directive.
  
  This fixes issue #658
  

• ffa0bb36
  by Tristan Van Berkom at 2018-09-18T07:47:44Z

  tests/format/optionoverrides.py: Added test for options in element overrides
  
  This is a regression test for issue #658
  

• f2ae46f8
  by Tristan Van Berkom at 2018-09-18T08:14:23Z

  Merge branch 'tristan/fix-override-options' into 'master'
  
  Fix override options
  
  Closes #658
  
  See merge request BuildStream/buildstream!802

• 7b117e40
  by Daniel Silverstone at 2018-09-18T08:41:32Z

  _artifactcache/artifactcache.py: Ensure no double-setup of remotes
  
  Since ArtifactCache.setup_remotes() can be expensive and should only
  happen once, this commit will assert() if it is called a second time
  on an artifact cache instance.
  
  Signed-off-by: Daniel Silverstone <daniel silverstone codethink co uk>
  

• 345f5f49
  by Daniel Silverstone at 2018-09-18T08:41:32Z

  tests/artifactcache/pull.py: Do not double-initialize remotes
  
  The initialization of remotes is done by ArtifactCache.setup_remotes()
  and as such it was wrong for these tests to be calling
  CASCache.initialize_remotes() a second time.
  
  Signed-off-by: Daniel Silverstone <daniel silverstone codethink co uk>
  

• e32221b6
  by Daniel Silverstone at 2018-09-18T08:45:50Z

  sandbox/_sandboxremote.py: Acquire artifact cache via Platform
  
  The SandboxRemote used to construct its own CASCache which was
  considered dangerous.  This patch replaces that with acquisition of
  the cache via the Platform singleton, hopefully eliminating issues
  from having more than one artifact cache object in a single process.
  
  Signed-off-by: Daniel Silverstone <daniel silverstone codethink co uk>
  

• b587579f
  by Tristan Van Berkom at 2018-09-18T09:53:26Z

  Merge branch 'danielsilverstone-ct/fix-654' into 'master'
  
  sandbox/_sandboxremote.py: Acquire cache via Platform
  
  See merge request BuildStream/buildstream!797

• 30b41959
  by Tristan Van Berkom at 2018-09-18T09:56:45Z

  _artifactcache/artifactcache.py: Error out gracefully when push remote is mal-specified
  
  When configuring a push remote and specifying either the client-cert
  or the client-key, then both must be specified. This ensures we
  get an informative error instead of a stack trace and BUG.
  
  Fixes issue #625
  

• 41e8dc81
  by Tristan Van Berkom at 2018-09-18T09:56:45Z

  tests/artifactcache/config.py: Added test for invalid push remote configuration
  
  Test that we get the expected error when configuring a client-cert
  without client-key, or the inverse.
  

• 97071b6e
  by Tristan Van Berkom at 2018-09-18T10:16:43Z

  Merge branch 'tristan/fix-artifact-config-crash' into 'master'
  
  Fix artifact config crash
  
  Closes #625
  
  See merge request BuildStream/buildstream!804

• 081dcafa
  by Richard Maw at 2018-09-18T13:22:38Z

  fuse: Report the correct device number for devices
  
  This fixes all devices being mapped to the non-existant device 0,
  which prevents being able to use even safe devices like /dev/null
  through the hardlinks FUSE layer.
  

• d0425608
  by Richard Maw at 2018-09-18T13:22:38Z

  FUSE: Mount with -odev in chroot sandbox
  
  This is needed to permit access to the device nodes added to /dev
  on Linux when FUSE is used as root.
  
  The chroot sandbox only works with all privileges,
  so there's no explicit check for being root
  or having the appropriate capabilities.
  
  A check for whether it's running as root isn't needed on Linux with bubblewrap
  because /dev or its devices are mounted on top of the FUSE layer,
  so device nodes are accessed directly rather than through the FUSE layer.
  

• 8430fdc7
  by Richard Maw at 2018-09-18T13:22:38Z

  tests: test that integration commands can use /dev
  

• d8450166
  by Tristan Van Berkom at 2018-09-18T13:50:15Z

  Merge branch 'richardmaw/fix-chroot-sandbox-devices' into 'master'
  
  fix chroot sandbox devices
  
  See merge request BuildStream/buildstream!781

• d5c82c1b
  by William Salmon at 2018-09-19T08:07:49Z

  Bug: CWD was not being created for workspaces
  
  The code was creating the cwd folder but when the workspace was
  mounted in to the buildroot it was hiding the folder created in it
  behind the bind mounted workspace.
  
  However buy using the bubble warp `--dir` directive to ensure that cwd
  exists then we can cover both workspace and non workspace situation with
  the same method.
  

• 08a2a51b
  by William Salmon at 2018-09-19T08:07:49Z

  New Integration test for workspace command-subdir
  
  Build stream was only creating command-subdir for non workspace builds
  this has now been fixed, and this regression test should support the
  feature.
  

• c5938c2e
  by William Salmon at 2018-09-19T08:07:49Z

  Add conf-root variable to builds
  
  Adding the conf-root variable makes creating out of source builds
  slightly easier.
  

• 4c841dbc
  by William Salmon at 2018-09-19T08:07:49Z

  Adding Out of Source Build Examples
  
  Three examples covering out of source builds for:
   * basic autotools
   * basic cmake
   * autotools from a folder inside the source folder
  
  This is also the first cmake example.
  

• da19f859
  by William Salmon at 2018-09-19T08:07:49Z

  Adding Tests for Out of Source Build examples
  

• b08ed7e6
  by William Salmon at 2018-09-19T08:07:49Z

  Extended the Documentation to cover out of source builds
  

30 changed files:

• buildstream/_artifactcache/artifactcache.py
• buildstream/_fuse/hardlinks.py
• buildstream/_fuse/mount.py
• buildstream/_project.py
• buildstream/buildelement.py
• buildstream/data/projectconfig.yaml
• buildstream/plugins/elements/autotools.yaml
• buildstream/plugins/elements/cmake.yaml
• buildstream/sandbox/_mount.py
• buildstream/sandbox/_sandboxbwrap.py
• buildstream/sandbox/_sandboxchroot.py
• buildstream/sandbox/_sandboxremote.py
• buildstream/sandbox/sandbox.py
• buildstream/source.py
• + doc/examples/cmake/elements/base.bst
• + doc/examples/cmake/elements/base/alpine.bst
• + doc/examples/cmake/elements/hello.bst
• + doc/examples/cmake/files/hello/CMakeLists.txt
• + doc/examples/cmake/files/hello/main.c
• + doc/examples/cmake/project.conf
• + doc/examples/out-of-source-autotool-in-source-tree/elements/base.bst
• + doc/examples/out-of-source-autotool-in-source-tree/elements/base/alpine.bst
• + doc/examples/out-of-source-autotool-in-source-tree/elements/hello.bst
• + doc/examples/out-of-source-autotool-in-source-tree/project.conf
• + doc/examples/out-of-source-build-helloworld/elements/base.bst
• + doc/examples/out-of-source-build-helloworld/elements/base/alpine.bst
• + doc/examples/out-of-source-build-helloworld/elements/hello.bst
• + doc/examples/out-of-source-build-helloworld/files/hello/AUTHORS
• + doc/examples/out-of-source-build-helloworld/files/hello/ChangeLog
• + doc/examples/out-of-source-build-helloworld/files/hello/Makefile.am

The diff was not included because it is too large.

—
View it on GitLab.
You're receiving this email because of your account on gitlab.com. If you'd like to receive fewer emails, you can adjust your notification settings.