[Notes] [Git][BuildStream/buildstream][issue-642-Invalid_project.conf_seen_as_missing] 48 commits: element: Remove __cached field

[Phillip Smyth <gitlab mg gitlab com>]

Title: GitLab

Phillip Smyth pushed to branch issue-642-Invalid_project.conf_seen_as_missing at BuildStream / buildstream

Commits:

• 55956762
  by Richard Maw at 2018-09-13T16:50:33Z

  element: Remove __cached field
  
  This can get out of sync with other two cache states,
  and we can do without it.
  

• fc7f83ac
  by richardmaw-codethink at 2018-09-13T17:14:31Z

  Merge branch 'richardmaw/element-cache-state-simplify' into 'master'
  
  Simplify element state by removing `__cached`
  
  See merge request BuildStream/buildstream!784

• 233a7d83
  by Richard Maw at 2018-09-14T08:53:14Z

  Handle sockets when copying trees into artifacts
  
  We can't include a socket in a CAS tree, but it's mostly meaningless to do so
  since there can't possibly be a process serving it.
  

• f06f234a
  by Richard Maw at 2018-09-14T08:53:14Z

  tests: cover builds that make sockets
  

• f86ab8f6
  by richardmaw-codethink at 2018-09-14T09:46:07Z

  Merge branch 'richardmaw/builddir-sockets' into 'master'
  
  Fix: While caching build artifact: "Cannot extract [path to socket file] into staging-area. Unsupported type."
  
  See merge request BuildStream/buildstream!783

• e7427462
  by Richard Maw at 2018-09-14T10:28:17Z

  tests: Use cli.configure for custom logging test
  
  Overriding the config with a custom config file on the command-line
  prevents it merging in the test-specific configuration
  and can permit it to attempt to initialise the user's cache.
  

• 800a8403
  by Richard Maw at 2018-09-14T10:28:17Z

  Tidy relative workspace tests
  
  They were moving the whole tmpdir to move the project repository.
  This moves the cache directories etc. as well, meaning cli.run can't find them.
  This was worked around by setting configure=False,
  but this has the side-effect of making use of the user's caches,
  which it should not be doing for reproducibility reasons.
  
  By changing the tempdir layout to have the project in a subdirectory
  we can move the project around for the relative workspace tests
  without losing track of the configured state directories,
  so we can leave configure=True and avoid touching the user's caches.
  

• d7152ef4
  by richardmaw-codethink at 2018-09-14T10:55:16Z

  Merge branch 'richardmaw/test-config-fixes' into 'master'
  
  Fix tests that attempt to access the home directory
  
  See merge request BuildStream/buildstream!780

• 160bb0c6
  by Tristan Van Berkom at 2018-09-14T12:07:46Z

  _artifactcache/artifactcache.py: Changes to mark_required_elements()
  
  This was previously append_required_artifacts(), which presumed that
  we knew at startup time what the cache keys of all elements in the
  loaded pipeline would be.
  
  This fixes unexpected deletions of required artifacts when
  dynamic tracking is enabled with `bst build --track-all target.bst`
  

• 39125d24
  by Tristan Van Berkom at 2018-09-14T12:07:46Z

  tests/artifactcache/expiry.py: Cleanup of test for required artifacts
  
  This commit renames test_never_delete_dependencies() to
  test_never_delete_required(), renders the test more readable by renaming
  some elements and reordering some statements and makes the comments more
  straight forward and accurate.
  

• f60558a3
  by Tristan Van Berkom at 2018-09-14T12:07:46Z

  tests/artifactcache/expiry.py: Assert the expected errors
  
  These tests were not checking that we fail for the expected reasons.
  
  Added `res.assert_task_error(ErrorDomain.ARTIFACT, 'cache-too-full')`
  where we expect to fail because the cache is too full.
  

• ce68fd27
  by Tristan Van Berkom at 2018-09-14T12:07:46Z

  testutils/repo/git.py: Added modify_file() method
  
  This allows one to modify a file in an existing git repo,
  as opposed to adding a new one.
  

• 532ec1eb
  by Tristan Van Berkom at 2018-09-14T12:07:46Z

  testutils/element_generators.py: Changing sized element functions
  
   * create_element_size()
  
     Now uses a git Repo object instead of a local source, and
     returns the repo.
  
   * update_element_size()
  
     Added this function which can now resize the expected output
     of an element generated with create_element_size(), useful
     to allow testing sized elements with the tracking feature.
  

• 20b797cb
  by Tristan Van Berkom at 2018-09-14T12:07:46Z

  tests/artifactcache/expiry.py: Added test_never_delete_required_track()
  
  Same test as test_never_delete_required(), except that this test ensures
  that we never delete required artifacts when their cache keys are
  discovered dynamically during the build.
  

• c2af0d51
  by Tristan Van Berkom at 2018-09-14T12:44:42Z

  Merge branch 'tristan/fix-required-artifacts' into 'master'
  
  Don't delete required artifacts when tracking is enabled
  
  See merge request BuildStream/buildstream!793

• 924cdc75
  by Tiago Gomes at 2018-09-14T15:32:01Z

  core: remove unused variable on Context
  

• 510ccbfd
  by Tiago Gomes at 2018-09-14T15:32:21Z

  artifactcache: fix oversight
  
  We want to check if some file is already cached here, not the parent
  directory.
  

• 82d4e2ac
  by Tiago Gomes at 2018-09-14T15:32:21Z

  scheduler: add missing copyright
  
  Tristan Maat created the original file, so he is added as the author.
  

• 18b37aab
  by Tiago Gomes at 2018-09-14T15:34:10Z

  artifactcache: improve _create_tree()
  
  * Rename it to _commit_directory() because… it is what it does; and
    also for symmetry with _fetch_directory().
  * Rename digest to dir_digest to make it clear this is a digest for a
    directory. A following commit will also reuse the same variable name
  * Document method.
  

• 32fad24f
  by Tiago Gomes at 2018-09-14T15:38:41Z

  artifactcache: improve _fetch_directory()
  
  * Rename tree to dir_digest to make it clear this is a Digest object,
    and not a Tree object.
  * Add documentation
  

• 46cbd889
  by Tiago Gomes at 2018-09-14T15:38:43Z

  artifactcache: rename get_quota_exceeded()
  

• 2fa92716
  by Tiago Gomes at 2018-09-14T15:38:43Z

  scheduler: minor cleanups to CleanupJob
  
  Remove unneeded cruft.
  

• c285f244
  by Tiago Gomes at 2018-09-14T16:08:07Z

  Merge branch 'tiagogomes/some-cleanups' into 'master'
  
  Bunch of cleanups
  
  See merge request BuildStream/buildstream!798

• 662d22a9
  by Tristan Van Berkom at 2018-09-16T08:54:00Z

  buildstream/_frontend/complete.py: Added missing click license compliance
  
  Somehow I missed this when originally forking the file from the click
  library, now noticing that we should have followed what was written
  in: https://github.com/pallets/click/blob/master/LICENSE
  

• a344407b
  by Richard Maw at 2018-09-16T10:22:59Z

  sandbox: deduplicate default environment logic
  

• c8fab440
  by Richard Maw at 2018-09-16T10:22:59Z

  Bump Artifact Version
  
  Since we now set PWD in the environment of builds
  existing builds may behave differently so must cache differently now.
  

• eb9481da
  by Richard Maw at 2018-09-16T10:22:59Z

  Cachekey update helper: Document ensuring . in PYTHONPATH
  
  The current directory isn't always in the python module search path,
  so we have to ensure it is for the script to work.
  
  Strictly speaking, the user may already have a modified PYTHONPATH
  at which point PYTHONPATH=".${PYTHONPATH+:$PYTHONPATH}" is necessary,
  but it's probably premature to overcomplicate the documentation like that
  before we discover it's a problem.
  

• 9b7b2a25
  by Tristan Van Berkom at 2018-09-16T10:50:36Z

  Merge branch 'richardmaw/subprocess-PWD' into 'master'
  
  Address post-merge review of Ensure PWD is set in process environment
  
  See merge request BuildStream/buildstream!788

• 8db62230
  by Adam Jones at 2018-09-17T07:39:06Z

  Add a section on how to raise an issue
  

• 6f0a3e98
  by Adam Jones at 2018-09-17T07:39:20Z

  Rename HACKING.rst to CONTRIBUTING.rst
  

• ade19151
  by Adam Jones at 2018-09-17T07:40:45Z

  update HACKING references
  

• b9c5ff7d
  by Tristan Van Berkom at 2018-09-17T08:09:12Z

  Merge branch 'tristan/contributing-guide' into 'master'
  
  Update contributing guide
  
  See merge request BuildStream/buildstream!801

• 727f2faa
  by Tristan Van Berkom at 2018-09-18T07:43:07Z

  _project.py: Fix option resolution in element & source overrides
  
  This ensures that option expressions are resolved in the project
  level overrides before attempting to composite them on the instantiated
  elements. Seems this is a regression from introducing the include
  directive.
  
  This fixes issue #658
  

• ffa0bb36
  by Tristan Van Berkom at 2018-09-18T07:47:44Z

  tests/format/optionoverrides.py: Added test for options in element overrides
  
  This is a regression test for issue #658
  

• f2ae46f8
  by Tristan Van Berkom at 2018-09-18T08:14:23Z

  Merge branch 'tristan/fix-override-options' into 'master'
  
  Fix override options
  
  Closes #658
  
  See merge request BuildStream/buildstream!802

• 7b117e40
  by Daniel Silverstone at 2018-09-18T08:41:32Z

  _artifactcache/artifactcache.py: Ensure no double-setup of remotes
  
  Since ArtifactCache.setup_remotes() can be expensive and should only
  happen once, this commit will assert() if it is called a second time
  on an artifact cache instance.
  
  Signed-off-by: Daniel Silverstone <daniel silverstone codethink co uk>
  

• 345f5f49
  by Daniel Silverstone at 2018-09-18T08:41:32Z

  tests/artifactcache/pull.py: Do not double-initialize remotes
  
  The initialization of remotes is done by ArtifactCache.setup_remotes()
  and as such it was wrong for these tests to be calling
  CASCache.initialize_remotes() a second time.
  
  Signed-off-by: Daniel Silverstone <daniel silverstone codethink co uk>
  

• e32221b6
  by Daniel Silverstone at 2018-09-18T08:45:50Z

  sandbox/_sandboxremote.py: Acquire artifact cache via Platform
  
  The SandboxRemote used to construct its own CASCache which was
  considered dangerous.  This patch replaces that with acquisition of
  the cache via the Platform singleton, hopefully eliminating issues
  from having more than one artifact cache object in a single process.
  
  Signed-off-by: Daniel Silverstone <daniel silverstone codethink co uk>
  

• b587579f
  by Tristan Van Berkom at 2018-09-18T09:53:26Z

  Merge branch 'danielsilverstone-ct/fix-654' into 'master'
  
  sandbox/_sandboxremote.py: Acquire cache via Platform
  
  See merge request BuildStream/buildstream!797

• 30b41959
  by Tristan Van Berkom at 2018-09-18T09:56:45Z

  _artifactcache/artifactcache.py: Error out gracefully when push remote is mal-specified
  
  When configuring a push remote and specifying either the client-cert
  or the client-key, then both must be specified. This ensures we
  get an informative error instead of a stack trace and BUG.
  
  Fixes issue #625
  

• 41e8dc81
  by Tristan Van Berkom at 2018-09-18T09:56:45Z

  tests/artifactcache/config.py: Added test for invalid push remote configuration
  
  Test that we get the expected error when configuring a client-cert
  without client-key, or the inverse.
  

• 97071b6e
  by Tristan Van Berkom at 2018-09-18T10:16:43Z

  Merge branch 'tristan/fix-artifact-config-crash' into 'master'
  
  Fix artifact config crash
  
  Closes #625
  
  See merge request BuildStream/buildstream!804

• 081dcafa
  by Richard Maw at 2018-09-18T13:22:38Z

  fuse: Report the correct device number for devices
  
  This fixes all devices being mapped to the non-existant device 0,
  which prevents being able to use even safe devices like /dev/null
  through the hardlinks FUSE layer.
  

• d0425608
  by Richard Maw at 2018-09-18T13:22:38Z

  FUSE: Mount with -odev in chroot sandbox
  
  This is needed to permit access to the device nodes added to /dev
  on Linux when FUSE is used as root.
  
  The chroot sandbox only works with all privileges,
  so there's no explicit check for being root
  or having the appropriate capabilities.
  
  A check for whether it's running as root isn't needed on Linux with bubblewrap
  because /dev or its devices are mounted on top of the FUSE layer,
  so device nodes are accessed directly rather than through the FUSE layer.
  

• 8430fdc7
  by Richard Maw at 2018-09-18T13:22:38Z

  tests: test that integration commands can use /dev
  

• d8450166
  by Tristan Van Berkom at 2018-09-18T13:50:15Z

  Merge branch 'richardmaw/fix-chroot-sandbox-devices' into 'master'
  
  fix chroot sandbox devices
  
  See merge request BuildStream/buildstream!781

• ba4da3a4
  by knownexus at 2018-09-18T16:45:09Z

  Incorrect error when malformed project.conf
  
  bst build returns "missing project.conf" when a project.conf is invalid
  This results in an existing project with malformed yaml being dismissed
  and attempts to make a new project
  
  Added new exception
  

• 89a16e17
  by knownexus at 2018-09-18T16:45:09Z

  Adding test for Invalid Yaml
  

30 changed files:

• HACKING.rst → CONTRIBUTING.rst
• MANIFEST.in
• buildstream/_artifactcache/artifactcache.py
• buildstream/_artifactcache/cascache.py
• buildstream/_context.py
• buildstream/_frontend/complete.py
• buildstream/_fuse/hardlinks.py
• buildstream/_fuse/mount.py
• buildstream/_project.py
• buildstream/_scheduler/jobs/__init__.py
• buildstream/_scheduler/jobs/cleanupjob.py
• buildstream/_scheduler/queues/buildqueue.py
• buildstream/_scheduler/scheduler.py
• buildstream/_stream.py
• buildstream/_versions.py
• buildstream/element.py
• buildstream/sandbox/_mount.py
• buildstream/sandbox/_sandboxbwrap.py
• buildstream/sandbox/_sandboxchroot.py
• buildstream/sandbox/_sandboxremote.py
• buildstream/sandbox/sandbox.py
• buildstream/utils.py
• doc/bst2html.py
• + doc/source/CONTRIBUTING.rst
• − doc/source/HACKING.rst
• doc/source/index.rst
• tests/artifactcache/config.py
• tests/artifactcache/expiry.py
• + tests/artifactcache/missing-certs/certificates/client.crt
• + tests/artifactcache/missing-certs/certificates/client.key

The diff was not included because it is too large.

—
View it on GitLab.
You're receiving this email because of your account on gitlab.com. If you'd like to receive fewer emails, you can adjust your notification settings.