[Notes] [Git][BuildStream/buildstream][jonathan/pickle-yaml] 29 commits: _artifactcache/artifactcache.py: Changes to mark_required_elements()

[Jonathan Maw <gitlab mg gitlab com>]

Title: GitLab

Jonathan Maw pushed to branch jonathan/pickle-yaml at BuildStream / buildstream

Commits:

• 160bb0c6
  by Tristan Van Berkom at 2018-09-14T12:07:46Z

  _artifactcache/artifactcache.py: Changes to mark_required_elements()
  
  This was previously append_required_artifacts(), which presumed that
  we knew at startup time what the cache keys of all elements in the
  loaded pipeline would be.
  
  This fixes unexpected deletions of required artifacts when
  dynamic tracking is enabled with `bst build --track-all target.bst`
  

• 39125d24
  by Tristan Van Berkom at 2018-09-14T12:07:46Z

  tests/artifactcache/expiry.py: Cleanup of test for required artifacts
  
  This commit renames test_never_delete_dependencies() to
  test_never_delete_required(), renders the test more readable by renaming
  some elements and reordering some statements and makes the comments more
  straight forward and accurate.
  

• f60558a3
  by Tristan Van Berkom at 2018-09-14T12:07:46Z

  tests/artifactcache/expiry.py: Assert the expected errors
  
  These tests were not checking that we fail for the expected reasons.
  
  Added `res.assert_task_error(ErrorDomain.ARTIFACT, 'cache-too-full')`
  where we expect to fail because the cache is too full.
  

• ce68fd27
  by Tristan Van Berkom at 2018-09-14T12:07:46Z

  testutils/repo/git.py: Added modify_file() method
  
  This allows one to modify a file in an existing git repo,
  as opposed to adding a new one.
  

• 532ec1eb
  by Tristan Van Berkom at 2018-09-14T12:07:46Z

  testutils/element_generators.py: Changing sized element functions
  
   * create_element_size()
  
     Now uses a git Repo object instead of a local source, and
     returns the repo.
  
   * update_element_size()
  
     Added this function which can now resize the expected output
     of an element generated with create_element_size(), useful
     to allow testing sized elements with the tracking feature.
  

• 20b797cb
  by Tristan Van Berkom at 2018-09-14T12:07:46Z

  tests/artifactcache/expiry.py: Added test_never_delete_required_track()
  
  Same test as test_never_delete_required(), except that this test ensures
  that we never delete required artifacts when their cache keys are
  discovered dynamically during the build.
  

• c2af0d51
  by Tristan Van Berkom at 2018-09-14T12:44:42Z

  Merge branch 'tristan/fix-required-artifacts' into 'master'
  
  Don't delete required artifacts when tracking is enabled
  
  See merge request BuildStream/buildstream!793

• 924cdc75
  by Tiago Gomes at 2018-09-14T15:32:01Z

  core: remove unused variable on Context
  

• 510ccbfd
  by Tiago Gomes at 2018-09-14T15:32:21Z

  artifactcache: fix oversight
  
  We want to check if some file is already cached here, not the parent
  directory.
  

• 82d4e2ac
  by Tiago Gomes at 2018-09-14T15:32:21Z

  scheduler: add missing copyright
  
  Tristan Maat created the original file, so he is added as the author.
  

• 18b37aab
  by Tiago Gomes at 2018-09-14T15:34:10Z

  artifactcache: improve _create_tree()
  
  * Rename it to _commit_directory() because… it is what it does; and
    also for symmetry with _fetch_directory().
  * Rename digest to dir_digest to make it clear this is a digest for a
    directory. A following commit will also reuse the same variable name
  * Document method.
  

• 32fad24f
  by Tiago Gomes at 2018-09-14T15:38:41Z

  artifactcache: improve _fetch_directory()
  
  * Rename tree to dir_digest to make it clear this is a Digest object,
    and not a Tree object.
  * Add documentation
  

• 46cbd889
  by Tiago Gomes at 2018-09-14T15:38:43Z

  artifactcache: rename get_quota_exceeded()
  

• 2fa92716
  by Tiago Gomes at 2018-09-14T15:38:43Z

  scheduler: minor cleanups to CleanupJob
  
  Remove unneeded cruft.
  

• c285f244
  by Tiago Gomes at 2018-09-14T16:08:07Z

  Merge branch 'tiagogomes/some-cleanups' into 'master'
  
  Bunch of cleanups
  
  See merge request BuildStream/buildstream!798

• 662d22a9
  by Tristan Van Berkom at 2018-09-16T08:54:00Z

  buildstream/_frontend/complete.py: Added missing click license compliance
  
  Somehow I missed this when originally forking the file from the click
  library, now noticing that we should have followed what was written
  in: https://github.com/pallets/click/blob/master/LICENSE
  

• a344407b
  by Richard Maw at 2018-09-16T10:22:59Z

  sandbox: deduplicate default environment logic
  

• c8fab440
  by Richard Maw at 2018-09-16T10:22:59Z

  Bump Artifact Version
  
  Since we now set PWD in the environment of builds
  existing builds may behave differently so must cache differently now.
  

• eb9481da
  by Richard Maw at 2018-09-16T10:22:59Z

  Cachekey update helper: Document ensuring . in PYTHONPATH
  
  The current directory isn't always in the python module search path,
  so we have to ensure it is for the script to work.
  
  Strictly speaking, the user may already have a modified PYTHONPATH
  at which point PYTHONPATH=".${PYTHONPATH+:$PYTHONPATH}" is necessary,
  but it's probably premature to overcomplicate the documentation like that
  before we discover it's a problem.
  

• 9b7b2a25
  by Tristan Van Berkom at 2018-09-16T10:50:36Z

  Merge branch 'richardmaw/subprocess-PWD' into 'master'
  
  Address post-merge review of Ensure PWD is set in process environment
  
  See merge request BuildStream/buildstream!788

• 8db62230
  by Adam Jones at 2018-09-17T07:39:06Z

  Add a section on how to raise an issue
  

• 6f0a3e98
  by Adam Jones at 2018-09-17T07:39:20Z

  Rename HACKING.rst to CONTRIBUTING.rst
  

• ade19151
  by Adam Jones at 2018-09-17T07:40:45Z

  update HACKING references
  

• b9c5ff7d
  by Tristan Van Berkom at 2018-09-17T08:09:12Z

  Merge branch 'tristan/contributing-guide' into 'master'
  
  Update contributing guide
  
  See merge request BuildStream/buildstream!801

• 1d727ff3
  by Jonathan Maw at 2018-09-17T17:12:37Z

  Loader: Make _extract_depends_from_node not 'del' nonexistent fields
  
  This is benign because a _yaml.ChainMap doesn't raise a
  KeyError, but it's not required to be a ChainMap.
  

• 5f9542c6
  by Jonathan Maw at 2018-09-17T17:12:37Z

  Add a cache of parsed and provenanced yaml
  
  Note that the ProvenanceFile's names will be incorrect after loading
  from the cache, but this is currently only used for writeback, which
  isn't used in junctions.
  

• a4ffbc4c
  by Jonathan Maw at 2018-09-17T17:12:37Z

  YamlCache: Remove project.directory from the cache as it was never used
  

• 0cad20cd
  by Jonathan Maw at 2018-09-17T17:12:37Z

  YamlCache: Add an is_cached helper
  

• 0b5e83f4
  by Jonathan Maw at 2018-09-17T17:12:37Z

  Add very-WIP tests
  

30 changed files:

• HACKING.rst → CONTRIBUTING.rst
• MANIFEST.in
• buildstream/_artifactcache/artifactcache.py
• buildstream/_artifactcache/cascache.py
• buildstream/_context.py
• buildstream/_frontend/complete.py
• buildstream/_loader/loadelement.py
• buildstream/_loader/loader.py
• + buildstream/_pickler.py
• buildstream/_project.py
• buildstream/_scheduler/jobs/__init__.py
• buildstream/_scheduler/jobs/cleanupjob.py
• buildstream/_scheduler/queues/buildqueue.py
• buildstream/_scheduler/scheduler.py
• buildstream/_stream.py
• buildstream/_versions.py
• buildstream/_yaml.py
• buildstream/element.py
• buildstream/sandbox/_sandboxbwrap.py
• buildstream/sandbox/_sandboxchroot.py
• buildstream/sandbox/sandbox.py
• doc/bst2html.py
• + doc/source/CONTRIBUTING.rst
• − doc/source/HACKING.rst
• doc/source/index.rst
• tests/artifactcache/expiry.py
• tests/cachekey/project/elements/build1.expected
• tests/cachekey/project/elements/build2.expected
• tests/cachekey/project/elements/compose1.expected
• tests/cachekey/project/elements/compose2.expected

The diff was not included because it is too large.

—
View it on GitLab.
You're receiving this email because of your account on gitlab.com. If you'd like to receive fewer emails, you can adjust your notification settings.