[Notes] [Git][BuildStream/buildstream][jjardon/pycodestyle] 3 commits: Use pycodestyle instead pep8

[Javier Jardón <gitlab mg gitlab com>]

Title: GitLab

Javier Jardón pushed to branch jjardon/pycodestyle at BuildStream / buildstream

Commits:

• 2f4a4838
  by Javier Jardón at 2018-09-12T14:51:51Z

  Use pycodestyle instead pep8
  
  pep8 package was renamed to pycodestyle to reduce confusion.
  

• b04a7fac
  by Javier Jardón at 2018-09-12T14:51:51Z

  setup.cfg: Ignore W605 and W504 for now
  
  This is the current occurence:
  40      W605 invalid escape sequence '\s'
  75      W504 line break after binary operator
  

• 31fc612b
  by Javier Jardón at 2018-09-12T14:51:51Z

  WIP
  

5 changed files:

• .gitlab-ci.yml
• buildstream/_ostree.py
• buildstream/element.py
• dev-requirements.txt
• setup.cfg

Changes:

.gitlab-ci.yml

---

...	...	@@ -84,25 +84,25 @@ source_dist:
84	84	- coverage-linux/
85	85
86	86	tests-debian-9:
87		- image: buildstream/testsuite-debian:9-master-117-aa3a33b3
	87	+ image: buildstream/testsuite-debian:9-master-117-b3ffcdc8
88	88	<<: *linux-tests
89	89
90	90	tests-fedora-27:
91		- image: buildstream/testsuite-fedora:27-master-117-aa3a33b3
	91	+ image: buildstream/testsuite-fedora:27-master-117-b3ffcdc8
92	92	<<: *linux-tests
93	93
94	94	tests-fedora-28:
95		- image: buildstream/testsuite-fedora:28-master-117-aa3a33b3
	95	+ image: buildstream/testsuite-fedora:28-master-117-b3ffcdc8
96	96	<<: *linux-tests
97	97
98	98	tests-ubuntu-18.04:
99		- image: buildstream/testsuite-ubuntu:18.04-master-117-aa3a33b3
	99	+ image: buildstream/testsuite-ubuntu:18.04-master-117-b3ffcdc8
100	100	<<: *linux-tests
101	101
102	102	tests-unix:
103	103	# Use fedora here, to a) run a test on fedora and b) ensure that we
104	104	# can get rid of ostree - this is not possible with debian-8
105		- image: buildstream/testsuite-fedora:27-master-117-aa3a33b3
	105	+ image: buildstream/testsuite-fedora:27-master-117-b3ffcdc8
106	106	stage: test
107	107	variables:
108	108	BST_FORCE_BACKEND: "unix"

buildstream/_ostree.py

---

...	...	@@ -34,7 +34,7 @@ from ._exceptions import BstError, ErrorDomain
34	34
35	35	# pylint: disable=wrong-import-position,wrong-import-order
36	36	gi.require_version('OSTree', '1.0')
37		-from gi.repository import GLib, Gio, OSTree # nopep8
	37	+from gi.repository import GLib, Gio, OSTree # noqa
38	38
39	39
40	40	# For users of this file, they must expect (except) it.

buildstream/element.py

---

...	...	@@ -1528,7 +1528,7 @@ class Element(Plugin):
1528	1528	utils._force_rmtree(rootdir)
1529	1529
1530	1530	with _signals.terminator(cleanup_rootdir), \
1531		- self.__sandbox(rootdir, output_file, output_file, self.__sandbox_config) as sandbox: # nopep8
	1531	+ self.__sandbox(rootdir, output_file, output_file, self.__sandbox_config) as sandbox: # noqa
1532	1532
1533	1533	sandbox_vroot = sandbox.get_virtual_directory()
1534	1534

dev-requirements.txt

---

1	1	coverage == 4.4.0
2		-pep8
3	2	pylint == 2.1.1
4	3	pytest >= 3.7
	4	+pytest-codestyle >= 1.3.0
5	5	pytest-cov >= 2.5.0
6	6	pytest-datafiles
7	7	pytest-env
8		-pytest-pep8
9	8	pytest-pylint
10	9	pytest-xdist
11	10	pytest-timeout

setup.cfg

---

...	...	@@ -11,20 +11,11 @@ parentdir_prefix = BuildStream-
11	11	test=pytest
12	12
13	13	[tool:pytest]
14		-addopts = --verbose --basetemp ./tmp --pep8 --pylint --pylint-rcfile=.pylintrc --cov=buildstream --cov-config .coveragerc --durations=20
	14	+addopts = --verbose --basetemp ./tmp --codestyle --pylint --pylint-rcfile=.pylintrc --cov=buildstream --cov-config .coveragerc --durations=20
15	15	norecursedirs = tests/integration/project integration-cache tmp __pycache__ .eggs
16	16	python_files = tests/*/*.py
17		-pep8maxlinelength = 119
18		-pep8ignore =
19		- * E129
20		- * E125
21		- doc/source/conf.py ALL
22		- tmp/* ALL
23		- */lib/python3* ALL
24		- */bin/* ALL
25		- buildstream/_fuse/fuse.py ALL
26		- .eggs/* ALL
27		- *_pb2.py ALL
28		- *_pb2_grpc.py ALL
	17	+codestyle_max_line_length = 119
	18	+codestyle_ignore = E129 E125 W504 W605
	19	+codestyle_exclude = doc/source/conf.py buildstream/_fuse/fuse.py *_pb2.py *_pb2_grpc.py
29	20	env =
30	21	D:BST_TEST_SUITE=True

—
View it on GitLab.
You're receiving this email because of your account on gitlab.com. If you'd like to receive fewer emails, you can adjust your notification settings.