[Notes] [Git][BuildGrid/buildgrid][finn/scheduler-race-fix] Fixed race condition.

[finn <gitlab mg gitlab com>]

Title: GitLab

finn pushed to branch finn/scheduler-race-fix at BuildGrid / buildgrid

Commits:

• b972be17
  by finnball at 2018-09-10T14:39:26Z

  Fixed race condition.
  
  If a job was marked as completed, it may be destroyed before
  it had time to update the action cache.
  

1 changed file:

• buildgrid/server/scheduler.py

Changes:

buildgrid/server/scheduler.py

---

...	...	@@ -87,10 +87,9 @@ class Scheduler:
87	87	def job_complete(self, name, result):
88	88	job = self.jobs[name]
89	89	job.result = result
90		- job.update_execute_stage(ExecuteStage.COMPLETED)
91		- self.jobs[name] = job
92	90	if not job.do_not_cache and self._action_cache is not None:
93	91	self._action_cache.update_action_result(job.action_digest, result)
	92	+ job.update_execute_stage(ExecuteStage.COMPLETED)
94	93
95	94	def get_operations(self):
96	95	response = operations_pb2.ListOperationsResponse()

—
View it on GitLab.
You're receiving this email because of your account on gitlab.com. If you'd like to receive fewer emails, you can adjust your notification settings.