[Notes] [Git][BuildStream/buildstream][bschubert/dont-cache-errors-from-host-tools] fixup! Add test to ensure host tools failure are not cached

[Benjamin Schubert <gitlab mg gitlab com>]

Title: GitLab

Benjamin Schubert pushed to branch bschubert/dont-cache-errors-from-host-tools at BuildStream / buildstream

Commits:

• f09f5699
  by Benjamin Schubert at 2018-10-25T10:29:16Z

  fixup! Add test to ensure host tools failure are not cached
  

2 changed files:

• buildstream/sandbox/_sandboxdummy.py
• tests/integration/cachedfail.py

Changes:

buildstream/sandbox/_sandboxdummy.py

---

...	...	@@ -38,4 +38,5 @@ class SandboxDummy(Sandbox):
38	38	"'{}'".format(command[0]),
39	39	reason='missing-command')
40	40
41		- raise SandboxError("This platform does not support local builds: {}".format(self._reason))
	41	+ raise SandboxError("This platform does not support local builds: {}".format(self._reason),
	42	+ reason='unavailable-local-sandbox')

tests/integration/cachedfail.py

---

...	...	@@ -185,7 +185,7 @@ def test_host_tools_errors_are_not_cached(cli, tmpdir, datafiles):
185	185
186	186	# Build without access to host tools, this will fail
187	187	result1 = cli.run(project=project, args=['build', 'element.bst'], env={'PATH': ''})
188		- result1.assert_task_error(ErrorDomain.SANDBOX, None)
	188	+ result1.assert_task_error(ErrorDomain.SANDBOX, 'unavailable-local-sandbox')
189	189
190	190	# When rebuilding, this should work
191	191	result2 = cli.run(project=project, args=['build', 'element.bst'])

—
View it on GitLab.
You're receiving this email because of your account on gitlab.com. If you'd like to receive fewer emails, you can adjust your notification settings.