[Notes] [Git][BuildStream/buildstream][master] 2 commits: _downloadablefilesource: handle ValueError-s

[Angelos Evripiotis <gitlab mg gitlab com>]

Title: GitLab

Angelos Evripiotis pushed to branch master at BuildStream / buildstream

Commits:

• 276d2195
  by Angelos Evripiotis at 2018-10-25T10:17:49Z

  _downloadablefilesource: handle ValueError-s
  

• 2d012a21
  by Angelos Evripiotis at 2018-10-25T10:17:49Z

  Merge branch 'aevri/unknown-uri-452' into 'master'
  
  _downloadablefilesource: handle ValueError-s
  
  Closes #452
  
  See merge request BuildStream/buildstream!893

1 changed file:

• buildstream/plugins/sources/_downloadablefilesource.py

Changes:

buildstream/plugins/sources/_downloadablefilesource.py

---

...	...	@@ -152,7 +152,9 @@ class DownloadableFileSource(Source):
152	152	raise SourceError("{}: Error mirroring {}: {}"
153	153	.format(self, self.url, e), temporary=True) from e
154	154
155		- except (urllib.error.URLError, urllib.error.ContentTooShortError, OSError) as e:
	155	+ except (urllib.error.URLError, urllib.error.ContentTooShortError, OSError, ValueError) as e:
	156	+ # Note that urllib.request.Request in the try block may throw a
	157	+ # ValueError for unknown url types, so we handle it here.
156	158	raise SourceError("{}: Error mirroring {}: {}"
157	159	.format(self, self.url, e), temporary=True) from e
158	160

—
View it on GitLab.
You're receiving this email because of your account on gitlab.com. If you'd like to receive fewer emails, you can adjust your notification settings.