[Notes] [Git][BuildStream/buildstream][chandan/source-checkout] 11 commi

Chandan Singh pushed to branch chandan/source-checkout at BuildStream / buildstream

Commits:

1c24979a

by Angelos Evripiotis at 2018-10-19T21:17:01Z

Spelling fixes: 'affect', not 'effect' as verb

Fix most instances of 'effect' being used as a verb instead of a noun.
Skipped generated instance in doc/source/conf.py.

43a2eee3

by Angelos Evripiotis at 2018-10-19T21:48:59Z

Merge branch 'aevri/affect' into 'master'

Spelling fixes: 'affect', not 'effect' as verb

See merge request BuildStream/buildstream!885

12719f0d

by Jürg Billeter at 2018-10-22T17:05:41Z

_artifactcache: Rename update_atime() to update_mtime()

os.utime() updates both, however, list_artifacts() sorts refs by mtime,
i.e., atime is irrelevant.

a7a28d14

by Jürg Billeter at 2018-10-22T17:05:41Z

_artifactcache: Fix ref in update_mtime()

get_artifact_fullname() is required to construct the ref. The cache key
alone does not suffice.

be29e0f5

by Jürg Billeter at 2018-10-22T17:53:26Z

Merge branch 'juerg/cas-mtime' into 'master'

_artifactcache: Fix ref in update_mtime()

See merge request BuildStream/buildstream!882

b74aca1a

by Jürg Billeter at 2018-10-23T09:22:19Z

tests/testutils/artifactshare.py: Fix has_artifact() to match core code

Replace path separator with '-' to match Element.normal_name.

c7dda150

by Jürg Billeter at 2018-10-23T09:48:00Z

Merge branch 'juerg/test-artifactshare' into 'master'

tests/testutils/artifactshare.py: Fix has_artifact() to match core code

See merge request BuildStream/buildstream!890

74c115b9

by Angelos Evripiotis at 2018-10-23T10:07:31Z

plugins/sources: refactor, rm needless ExitStack-s

Remove two uses of ExitStack that aren't necessary and make the code
a little harder to follow.

ecb58b42

by Phil Dawson at 2018-10-23T10:33:47Z

Merge branch 'aevri/rm-exitstack' into 'master'

plugins/sources: refactor, rm needless ExitStack-s

See merge request BuildStream/buildstream!888

db0611b9

by Chandan Singh at 2018-10-23T11:30:05Z

buildstream/_pipeline.py: Simplify error message for assert_consistent()

Currently, `Pipeline.assert_consistent()` prints an error message like
the one below when certain elements have inconsistent sources:

```
...
      Element: hello.bst is inconsistent
        Source tar source at hello.bst [line 16 column 2] is missing ref
...
```

Drop the word "Source" from the beginning of the message as
"Source <source-kind> source ..." is kind of awkward to read.

e0b99945

by Chandan Singh at 2018-10-23T11:30:05Z

Add `bst source-checkout` command

As discussed in
https://mail.gnome.org/archives/buildstream-list/2018-September/msg00064.html,
add `bst source-checkout` command. This will allow users to checkout
sources for a given target.

* _frontend/cli.py: Add source-checkout command
* _pipeline.py: Add assert_sources_cached() method
* _stream.py: Add source_checkout method, abstract out
  __check_location_writable() method that used to part of checkout()

23 changed files:

buildstream/_artifactcache/artifactcache.py
buildstream/_artifactcache/cascache.py
buildstream/_frontend/cli.py
buildstream/_pipeline.py
buildstream/_scheduler/queues/queue.py
buildstream/_stream.py
buildstream/_yaml.py
buildstream/buildelement.py
buildstream/plugin.py
buildstream/plugins/elements/autotools.yaml
buildstream/plugins/elements/cmake.yaml
buildstream/plugins/elements/make.yaml
buildstream/plugins/elements/manual.yaml
buildstream/plugins/elements/meson.yaml
buildstream/plugins/elements/qmake.yaml
buildstream/plugins/sources/deb.py
buildstream/plugins/sources/git.py
buildstream/plugins/sources/tar.py
tests/completions/completions.py
+ tests/frontend/project/elements/checkout-deps.bst
+ tests/frontend/project/files/etc-files/etc/buildstream/config
+ tests/frontend/source_checkout.py
tests/testutils/artifactshare.py

Changes:

buildstream/_artifactcache/artifactcache.py

@@ -228,7 +228,7 @@ class ArtifactCache():
          self._required_elements.update(elements)
          # For the cache keys which were resolved so far, we bump
 -        # the atime of them.
 +        # the mtime of them.
+         #
          # This is just in case we have concurrent instances of
          # BuildStream running with the same artifact cache, it will
@@ -240,7 +240,7 @@ class ArtifactCache():
              for key in (strong_key, weak_key):
                  if key:
                      try:
 -                        self.update_atime(key)
 +                        self.update_mtime(element, key)
                      except ArtifactError:
                          pass
@@ -391,15 +391,16 @@ class ArtifactCache():
      def preflight(self):
          pass
 -    # update_atime()
 +    # update_mtime()
+     #
 -    # Update the atime of an artifact.
 +    # Update the mtime of an artifact.
+     #
      # Args:
 +    #     element (Element): The Element to update
      #     key (str): The key of the artifact.
+     #
 -    def update_atime(self, key):
 -        raise ImplError("Cache '{kind}' does not implement contains()"
 +    def update_mtime(self, element, key):
 +        raise ImplError("Cache '{kind}' does not implement update_mtime()"
                          .format(kind=type(self).__name__))
      # initialize_remotes():

buildstream/_artifactcache/cascache.py

@@ -538,8 +538,9 @@ class CASCache(ArtifactCache):
          except FileNotFoundError as e:
              raise ArtifactError("Attempt to access unavailable artifact: {}".format(e)) from e
 -    def update_atime(self, ref):
 +    def update_mtime(self, element, key):
          try:
 +            ref = self.get_artifact_fullname(element, key)
              os.utime(self._refpath(ref))
          except FileNotFoundError as e:
              raise ArtifactError("Attempt to access unavailable artifact: {}".format(e)) from e

buildstream/_frontend/cli.py

@@ -662,6 +662,33 @@ def checkout(app, element, location, force, deps, integrate, hardlinks, tar):
                              tar=tar)
 +##################################################################
 +#                  Source Checkout Command                      #
 +##################################################################
 +@cli.command(name='source-checkout', short_help='Checkout sources for an element')
 +@click.option('--except', 'except_', multiple=True,
 +              type=click.Path(readable=False),
 +              help="Except certain dependencies")
 +@click.option('--deps', '-d', default='none',
 +              type=click.Choice(['build', 'none', 'run', 'all']),
 +              help='The dependencies whose sources to checkout (default: none)')
 +@click.option('--fetch', default=False, is_flag=True,
 +              help='Fetch elements if they are not fetched')
 +@click.argument('element',
 +                type=click.Path(readable=False))
 +@click.argument('location', type=click.Path())
 +@click.pass_obj
 +def source_checkout(app, element, location, deps, fetch, except_):
 +    """Checkout sources of an element to the specified location
 +    """
 +    with app.initialized():
 +        app.stream.source_checkout(element,
 +                                   location=location,
 +                                   deps=deps,
 +                                   fetch=fetch,
 +                                   except_targets=except_)
++
++
  ##################################################################
  #                      Workspace Command                         #
  ##################################################################

buildstream/_pipeline.py

@@ -370,7 +370,7 @@ class Pipeline():
                  detail += "  Element: {} is inconsistent\n".format(element._get_full_name())
                  for source in element.sources():
                      if source._get_consistency() == Consistency.INCONSISTENT:
 -                        detail += "    Source {} is missing ref\n".format(source)
 +                        detail += "    {} is missing ref\n".format(source)
                  detail += '\n'
              detail += "Try tracking these elements first with `bst track`\n"
@@ -383,6 +383,33 @@ class Pipeline():
                  detail += "  " + element._get_full_name() + "\n"
              raise PipelineError("Inconsistent pipeline", detail=detail, reason="inconsistent-pipeline-workspaced")
 +    # assert_sources_cached()
 +    #
 +    # Asserts that sources for the given list of elements are cached.
 +    #
 +    # Args:
 +    #    elements (list): The list of elements
 +    #
 +    def assert_sources_cached(self, elements):
 +        uncached = []
 +        with self._context.timed_activity("Checking sources"):
 +            for element in elements:
 +                if element._get_consistency() != Consistency.CACHED:
 +                    uncached.append(element)
++
 +        if uncached:
 +            detail = "Sources are not cached for the following elements:\n\n"
 +            for element in uncached:
 +                detail += "  Sources for element: {} are not cached\n".format(element._get_full_name())
 +                for source in element.sources():
 +                    if source._get_consistency() != Consistency.CACHED:
 +                        detail += "    {}\n".format(source)
 +                detail += '\n'
 +            detail += "Try fetching these elements first with `bst fetch`,\n" + \
 +                      "or run this command with `--fetch` option\n"
++
 +            raise PipelineError("Uncached sources", detail=detail, reason="uncached-sources")
++
      #############################################################
      #                     Private Methods                       #
      #############################################################

buildstream/_scheduler/queues/queue.py


     # This will have different results for elements depending
     # on the Queue.status() implementation.
     #
-    #   o Elements which are QueueStatus.WAIT will not be effected
+    #   o Elements which are QueueStatus.WAIT will not be affected
     #
     #   o Elements which are QueueStatus.SKIP will move directly
     #     to the dequeue pool

buildstream/_stream.py

@@ -379,27 +379,7 @@ class Stream():
          elements, _ = self._load((target,), (), fetch_subprojects=True)
          target = elements[0]
 -        if not tar:
 -            try:
 -                os.makedirs(location, exist_ok=True)
 -            except OSError as e:
 -                raise StreamError("Failed to create checkout directory: '{}'"
 -                                  .format(e)) from e
+-
 -        if not tar:
 -            if not os.access(location, os.W_OK):
 -                raise StreamError("Checkout directory '{}' not writable"
 -                                  .format(location))
 -            if not force and os.listdir(location):
 -                raise StreamError("Checkout directory '{}' not empty"
 -                                  .format(location))
 -        elif os.path.exists(location) and location != '-':
 -            if not os.access(location, os.W_OK):
 -                raise StreamError("Output file '{}' not writable"
 -                                  .format(location))
 -            if not force and os.path.exists(location):
 -                raise StreamError("Output file '{}' already exists"
 -                                  .format(location))
 +        self.__check_location_writable(location, force=force, tar=tar)
          # Stage deps into a temporary sandbox first
          try:
@@ -436,6 +416,42 @@ class Stream():
              raise StreamError("Error while staging dependencies into a sandbox"
                                ": '{}'".format(e), detail=e.detail, reason=e.reason) from e
 +    # source_checkout()
 +    #
 +    # Checkout sources of the target element to the specified location
 +    #
 +    # Args:
 +    #    target (str): The target element whose sources to checkout
 +    #    location (str): Location to checkout the sources to
 +    #    deps (str): The dependencies to checkout
 +    #    fetch (bool): Whether to fetch missing sources
 +    #    except_targets (list): List of targets to except from staging
 +    #
 +    def source_checkout(self, target, *,
 +                        location=None,
 +                        deps='none',
 +                        fetch=False,
 +                        except_targets=()):
++
 +        self.__check_location_writable(location)
++
 +        elements, _ = self._load((target,), (),
 +                                 selection=deps,
 +                                 except_targets=except_targets,
 +                                 fetch_subprojects=True)
++
 +        # Assert all sources are cached
 +        if fetch:
 +            self._fetch(elements)
 +        self._pipeline.assert_sources_cached(elements)
++
 +        # Stage all sources determined by scope
 +        try:
 +            self._write_element_sources(location, elements)
 +        except BstError as e:
 +            raise StreamError("Error while writing sources"
 +                              ": '{}'".format(e), detail=e.detail, reason=e.reason) from e
++
      # workspace_open
+     #
      # Open a project workspace
@@ -719,7 +735,7 @@ class Stream():
                  if self._write_element_script(source_directory, element)
+             ]
 -            self._write_element_sources(tempdir, elements)
 +            self._write_element_sources(os.path.join(tempdir, "source"), elements)
              self._write_build_script(tempdir, elements)
              self._collect_sources(tempdir, tar_location,
                                    target.normal_name, compression)
@@ -1082,11 +1098,10 @@ class Stream():
      # Write all source elements to the given directory
      def _write_element_sources(self, directory, elements):
          for element in elements:
 -            source_dir = os.path.join(directory, "source")
 -            element_source_dir = os.path.join(source_dir, element.normal_name)
 -            os.makedirs(element_source_dir)
+-
 -            element._stage_sources_at(element_source_dir)
 +            element_source_dir = os.path.join(directory, element.normal_name)
 +            if list(element.sources()):
 +                os.makedirs(element_source_dir)
 +                element._stage_sources_at(element_source_dir)
      # Write a master build script to the sandbox
      def _write_build_script(self, directory, elements):
@@ -1115,3 +1130,29 @@ class Stream():
              with tarfile.open(tar_name, permissions) as tar:
                  tar.add(directory, arcname=element_name)
++
 +    #############################################################
 +    #                    Private Methods                        #
 +    #############################################################
++
 +    # Check if given location is writable
 +    def __check_location_writable(self, location, force=False, tar=False):
 +        if not tar:
 +            try:
 +                os.makedirs(location, exist_ok=True)
 +            except OSError as e:
 +                raise StreamError("Failed to create checkout directory: '{}'"
 +                                  .format(e)) from e
 +            if not os.access(location, os.W_OK):
 +                raise StreamError("Checkout directory '{}' not writable"
 +                                  .format(location))
 +            if not force and os.listdir(location):
 +                raise StreamError("Checkout directory '{}' not empty"
 +                                  .format(location))
 +        elif os.path.exists(location) and location != '-':
 +            if not os.access(location, os.W_OK):
 +                raise StreamError("Output file '{}' not writable"
 +                                  .format(location))
 +            if not force and os.path.exists(location):
 +                raise StreamError("Output file '{}' already exists"
 +                                  .format(location))

buildstream/_yaml.py


 #
 # The purpose of this is to create a virtual copy-on-write
 # copy of a dictionary, so that mutating it in any way does
-# not effect the underlying dictionaries.
+# not affect the underlying dictionaries.
 #
 # collections.ChainMap covers this already mostly, but fails
 # to record internal state so as to hide keys which have been

buildstream/buildelement.py

@@ -176,7 +176,7 @@ class BuildElement(Element):
          # Specifying notparallel for a given element effects the
          # cache key, while having the side effect of setting max-jobs to 1,
 -        # which is normally automatically resolved and does not effect
 +        # which is normally automatically resolved and does not affect
          # the cache key.
          if self.get_variable('notparallel'):
              dictionary['notparallel'] = True

buildstream/plugin.py

@@ -266,7 +266,7 @@ class Plugin():
          such as an sha256 sum of a tarball content.
          Elements and Sources should implement this by collecting any configurations
 -        which could possibly effect the output and return a dictionary of these settings.
 +        which could possibly affect the output and return a dictionary of these settings.
          For Sources, this is guaranteed to only be called if
          :func:`Source.get_consistency() <buildstream.source.Source.get_consistency>`

buildstream/plugins/elements/autotools.yaml

@@ -123,7 +123,7 @@ environment:
    V: 1
  # And dont consider MAKEFLAGS or V as something which may
 -# effect build output.
 +# affect build output.
  environment-nocache:
  - MAKEFLAGS
  - V

buildstream/plugins/elements/cmake.yaml

@@ -66,7 +66,7 @@ environment:
    V: 1
  # And dont consider JOBS or V as something which may
 -# effect build output.
 +# affect build output.
  environment-nocache:
  - JOBS
  - V

buildstream/plugins/elements/make.yaml

@@ -36,7 +36,7 @@ environment:
    V: 1
  # And dont consider MAKEFLAGS or V as something which may
 -# effect build output.
 +# affect build output.
  environment-nocache:
  - MAKEFLAGS
  - V

buildstream/plugins/elements/manual.yaml

@@ -35,7 +35,7 @@ environment:
    V: 1
  # And dont consider MAKEFLAGS or V as something which may
 -# effect build output.
 +# affect build output.
  environment-nocache:
  - MAKEFLAGS
  - V

buildstream/plugins/elements/meson.yaml

@@ -74,6 +74,6 @@ environment:
      %{max-jobs}
  # And dont consider NINJAJOBS as something which may
 -# effect build output.
 +# affect build output.
  environment-nocache:
  - NINJAJOBS

buildstream/plugins/elements/qmake.yaml

@@ -44,7 +44,7 @@ environment:
    V: 1
  # And dont consider MAKEFLAGS or V as something which may
 -# effect build output.
 +# affect build output.
  environment-nocache:
  - MAKEFLAGS
  - V

buildstream/plugins/sources/deb.py

@@ -50,7 +50,7 @@ deb - stage files from .deb packages
  """
  import tarfile
 -from contextlib import contextmanager, ExitStack
 +from contextlib import contextmanager
  import arpy                                       # pylint: disable=import-error
  from .tar import TarSource
@@ -69,8 +69,7 @@ class DebSource(TarSource):
      @contextmanager
      def _get_tar(self):
 -        with ExitStack() as context:
 -            deb_file = context.enter_context(open(self._get_mirror_file(), 'rb'))
 +        with open(self._get_mirror_file(), 'rb') as deb_file:
              arpy_archive = arpy.Archive(fileobj=deb_file)
              arpy_archive.read_all_headers()
              data_tar_arpy = [v for k, v in arpy_archive.archived_files.items() if b"data.tar" in k][0]

buildstream/plugins/sources/git.py

@@ -415,7 +415,7 @@ class GitSource(Source):
      def get_unique_key(self):
          # Here we want to encode the local name of the repository and
          # the ref, if the user changes the alias to fetch the same sources
 -        # from another location, it should not effect the cache key.
 +        # from another location, it should not affect the cache key.
          key = [self.original_url, self.mirror.ref]
          # Only modify the cache key with checkout_submodules if it's something

buildstream/plugins/sources/tar.py

@@ -57,7 +57,7 @@ tar - stage files from tar archives
  import os
  import tarfile
 -from contextlib import contextmanager, ExitStack
 +from contextlib import contextmanager
  from tempfile import TemporaryFile
  from buildstream import SourceError
@@ -88,8 +88,7 @@ class TarSource(DownloadableFileSource):
      def _run_lzip(self):
          assert self.host_lzip
          with TemporaryFile() as lzip_stdout:
 -            with ExitStack() as context:
 -                lzip_file = context.enter_context(open(self._get_mirror_file(), 'r'))
 +            with open(self._get_mirror_file(), 'r') as lzip_file:
                  self.call([self.host_lzip, '-d'],
                            stdin=lzip_file,
                            stdout=lzip_stdout)

tests/completions/completions.py

@@ -15,6 +15,7 @@ MAIN_COMMANDS = [
      'push ',
      'shell ',
      'show ',
 +    'source-checkout ',
      'source-bundle ',
      'track ',
      'workspace '

tests/frontend/project/elements/checkout-deps.bst

 +kind: import
 +description: It is important for this element to have both build and runtime dependencies
 +sources:
 +- kind: local
 +  path: files/etc-files
 +depends:
 +- filename: import-dev.bst
 +  type: build
 +- filename: import-bin.bst
 +  type: runtime

tests/frontend/project/files/etc-files/etc/buildstream/config

+config

tests/frontend/source_checkout.py

 +import os
 +import pytest
++
 +from tests.testutils import cli
++
 +from buildstream import utils, _yaml
 +from buildstream._exceptions import ErrorDomain, LoadErrorReason
++
 +# Project directory
 +DATA_DIR = os.path.join(
 +    os.path.dirname(os.path.realpath(__file__)),
 +    'project',
 +)
++
++
 +def generate_remote_import_element(input_path, output_path):
 +    return {
 +        'kind': 'import',
 +        'sources': [
 +            {
 +                'kind': 'remote',
 +                'url': 'file://{}'.format(input_path),
 +                'filename': output_path,
 +                'ref': utils.sha256sum(input_path),
 +            }
 +        ]
 +    }
++
++
 +@pytest.mark.datafiles(DATA_DIR)
 +def test_source_checkout(datafiles, cli):
 +    project = os.path.join(datafiles.dirname, datafiles.basename)
 +    checkout = os.path.join(cli.directory, 'source-checkout')
 +    target = 'checkout-deps.bst'
++
 +    result = cli.run(project=project, args=['source-checkout', target, '--deps', 'none', checkout])
 +    result.assert_success()
++
 +    assert os.path.exists(os.path.join(checkout, 'checkout-deps', 'etc', 'buildstream', 'config'))
++
++
 +@pytest.mark.datafiles(DATA_DIR)
 +@pytest.mark.parametrize('deps', [('build'), ('none'), ('run'), ('all')])
 +def test_source_checkout_deps(datafiles, cli, deps):
 +    project = os.path.join(datafiles.dirname, datafiles.basename)
 +    checkout = os.path.join(cli.directory, 'source-checkout')
 +    target = 'checkout-deps.bst'
++
 +    result = cli.run(project=project, args=['source-checkout', target, '--deps', deps, checkout])
 +    result.assert_success()
++
 +    # Sources of the target
 +    if deps == 'build':
 +        assert not os.path.exists(os.path.join(checkout, 'checkout-deps'))
 +    else:
 +        assert os.path.exists(os.path.join(checkout, 'checkout-deps', 'etc', 'buildstream', 'config'))
++
 +    # Sources of the target's build dependencies
 +    if deps in ('build', 'all'):
 +        assert os.path.exists(os.path.join(checkout, 'import-dev', 'usr', 'include', 'pony.h'))
 +    else:
 +        assert not os.path.exists(os.path.join(checkout, 'import-dev'))
++
 +    # Sources of the target's runtime dependencies
 +    if deps in ('run', 'all'):
 +        assert os.path.exists(os.path.join(checkout, 'import-bin', 'usr', 'bin', 'hello'))
 +    else:
 +        assert not os.path.exists(os.path.join(checkout, 'import-bin'))
++
++
 +@pytest.mark.datafiles(DATA_DIR)
 +def test_source_checkout_except(datafiles, cli):
 +    project = os.path.join(datafiles.dirname, datafiles.basename)
 +    checkout = os.path.join(cli.directory, 'source-checkout')
 +    target = 'checkout-deps.bst'
++
 +    result = cli.run(project=project, args=['source-checkout', target,
 +                                            '--deps', 'all',
 +                                            '--except', 'import-bin.bst',
 +                                            checkout])
 +    result.assert_success()
++
 +    # Sources for the target should be present
 +    assert os.path.exists(os.path.join(checkout, 'checkout-deps', 'etc', 'buildstream', 'config'))
++
 +    # Sources for import-bin.bst should not be present
 +    assert not os.path.exists(os.path.join(checkout, 'import-bin'))
++
 +    # Sources for other dependencies should be present
 +    assert os.path.exists(os.path.join(checkout, 'import-dev', 'usr', 'include', 'pony.h'))
++
++
 +@pytest.mark.datafiles(DATA_DIR)
 +@pytest.mark.parametrize('fetch', [(False), (True)])
 +def test_source_checkout_fetch(datafiles, cli, fetch):
 +    project = os.path.join(datafiles.dirname, datafiles.basename)
 +    checkout = os.path.join(cli.directory, 'source-checkout')
 +    target = 'remote-import-dev.bst'
 +    target_path = os.path.join(project, 'elements', target)
++
 +    # Create an element with remote source
 +    element = generate_remote_import_element(
 +        os.path.join(project, 'files', 'dev-files', 'usr', 'include', 'pony.h'),
 +        'pony.h')
 +    _yaml.dump(element, target_path)
++
 +    # Testing --fetch option requires that we do not have the sources
 +    # cached already
 +    assert cli.get_element_state(project, target) == 'fetch needed'
++
 +    args = ['source-checkout']
 +    if fetch:
 +        args += ['--fetch']
 +    args += [target, checkout]
 +    result = cli.run(project=project, args=args)
++
 +    if fetch:
 +        result.assert_success()
 +        assert os.path.exists(os.path.join(checkout, 'remote-import-dev', 'pony.h'))
 +    else:
 +        result.assert_main_error(ErrorDomain.PIPELINE, 'uncached-sources')

tests/testutils/artifactshare.py

@@ -122,9 +122,8 @@ class ArtifactShare():
          #       same algo for creating an artifact reference
+         #
 -        # Chop off the .bst suffix first
 -        assert element_name.endswith('.bst')
 -        element_name = element_name[:-4]
 +        # Replace path separator and chop off the .bst suffix
 +        element_name = os.path.splitext(element_name.replace(os.sep, '-'))[0]
          valid_chars = string.digits + string.ascii_letters + '-._'
          element_name = ''.join([

...	...	@@ -208,7 +208,7 @@ class Queue():
208	208	# This will have different results for elements depending
209	209	# on the Queue.status() implementation.
210	210	#
211		- # o Elements which are QueueStatus.WAIT will not be effected
	211	+ # o Elements which are QueueStatus.WAIT will not be affected
212	212	#
213	213	# o Elements which are QueueStatus.SKIP will move directly
214	214	# to the dequeue pool

...	...	@@ -972,7 +972,7 @@ def node_validate(node, valid_keys):
972	972	#
973	973	# The purpose of this is to create a virtual copy-on-write
974	974	# copy of a dictionary, so that mutating it in any way does
975		-# not effect the underlying dictionaries.
	975	+# not affect the underlying dictionaries.
976	976	#
977	977	# collections.ChainMap covers this already mostly, but fails
978	978	# to record internal state so as to hide keys which have been

[Notes] [Git][BuildStream/buildstream][chandan/source-checkout] 11 commits: Spelling fixes: 'affect', not 'effect' as verb

Chandan Singh pushed to branch chandan/source-checkout at BuildStream / buildstream

Commits:

23 changed files:

Changes: