[Notes] [Git][BuildStream/buildstream][master] 2 commits: _platform/linux.py: Accept all configs for dummy sandbox

[Jürg Billeter <gitlab mg gitlab com>]

Title: GitLab

Jürg Billeter pushed to branch master at BuildStream / buildstream

Commits:

• 8dc16d3f
  by Jürg Billeter at 2018-10-03T05:08:21Z

  _platform/linux.py: Accept all configs for dummy sandbox
  
  If Sandbox.run() is never called, sandbox config is irrelevant. If it is
  called, the build will fail anyway with the dummy sandbox.
  
  This matches the logic in the Darwin platform.
  

• 66446fc3
  by Jürg Billeter at 2018-10-03T05:36:38Z

  Merge branch 'juerg/dummy-sandbox' into 'master'
  
  _platform/linux.py: Accept all configs for dummy sandbox
  
  See merge request BuildStream/buildstream!843

1 changed file:

• buildstream/_platform/linux.py

Changes:

buildstream/_platform/linux.py

---

...	...	@@ -55,6 +55,10 @@ class Linux(Platform):
55	55	return SandboxBwrap(*args, **kwargs)
56	56
57	57	def check_sandbox_config(self, config):
	58	+ if not self._local_sandbox_available():
	59	+ # Accept all sandbox configs as it's irrelevant with the dummy sandbox (no Sandbox.run).
	60	+ return True
	61	+
58	62	if self._user_ns_available:
59	63	# User namespace support allows arbitrary build UID/GID settings.
60	64	return True

—
View it on GitLab.
You're receiving this email because of your account on gitlab.com. If you'd like to receive fewer emails, you can adjust your notification settings.