[Notes] [Git][BuildStream/buildstream][bschubert/fix-atomic-move-git-rep

richardmaw-codethink pushed to branch bschubert/fix-atomic-move-git-repo at BuildStream / buildstream

Commits:

ae5ccd76

by Phillip Smyth at 2018-11-12T14:57:51Z

_project.py: Validate nodes early in Project._load

_project.py: Added validate_nodes() helper function to prevent duplicate lists

element-path was being used before node validation resulting in uncaught errors

56a54161

by Phillip Smyth at 2018-11-12T14:57:51Z

tests/frontend: Add test for invalid element-path

e55a9703

by Jürg Billeter at 2018-11-12T15:44:45Z

Merge branch 'element-path_not_validated' into 'master'

Element path not validated before use

See merge request BuildStream/buildstream!937

c87d6e45
by Valentin David at 2018-11-14T11:43:33Z
```
Run tests on aarch64

Fixes #755
```

16b01489

by Valentin David at 2018-11-14T11:43:33Z

Disable cachekey tests on other architectures than x86_64

85046b29

by Valentin David at 2018-11-14T11:43:33Z

Disable tests on example on other architectures than x86_64

dd5a073b
by Valentin David at 2018-11-14T11:43:33Z
```
Add support for aarch64 in a test
```
c5d72ae7
by Valentin David at 2018-11-14T11:52:53Z
```
Test aarch64 only overnight
```

264a57f6

by Javier Jardón at 2018-11-14T12:22:03Z

Merge branch 'valentindavid/integration-tests-aarch64' into 'master'

Run tests on aarch64

Closes #369 and #755

See merge request BuildStream/buildstream!948

da735e56

by Richard Maw at 2018-11-14T13:30:34Z

_platform/linux.py: Move get_bwrap_version into _site.py

It's inconvenient to have to create a Linux platform to parse the bwrap version
and we want to get the version in a consistent manner.

e7633500

by Richard Maw at 2018-11-14T13:30:34Z

buildstream/sandbox/_sandboxbwrap.py: Distinguish sandbox failure from command failure

If `bwrap` fails to set up the sandbox and start the payload command
it won't write an exit-code in --json-status-fd,
so we can report if it was a sandboxing failure if we don't get exit-code status
and a payload command failure if we do and it's non-zero.

Closes https://gitlab.com/BuildStream/buildstream/issues/286

e9e08823

by Richard Maw at 2018-11-14T13:30:34Z

tests/testutils/site.py: Check for bwrap supporting --json-status-fd

90ca007e

by Richard Maw at 2018-11-14T13:30:34Z

tests/integration/sandbox-bwrap.py: Test distinguishing sandbox exit code from command

327b19dd

by richardmaw-codethink at 2018-11-14T13:59:16Z

Merge branch 'richardmaw/distinguish-sandboxing-build-fail' into 'master'

Distinguish between bubblewrap sandboxing failure and command failure

Closes #286

See merge request BuildStream/buildstream!868

082b3811

by Angelos Evripiotis at 2018-11-15T19:48:12Z

contributing: add guidance on unit tests

Decrease uncertainty around whether unit tests are welcome in the
project or not.

b5b79056

by Jürg Billeter at 2018-11-15T20:24:58Z

Merge branch 'aevri/unit_tests' into 'master'

contributing: add guidance on unit tests

See merge request BuildStream/buildstream!943

199bfff1

by Tom Pollard at 2018-11-17T13:07:59Z

Add cli main and user config option for 'pull-buildtrees' context.

_context.py: Add pull_buildtrees global user context, the default
of which is set to False via the addition of pull-buildtrees to
userconfig.yaml cache group.

_frontend/app.py & cli.py: Add --pull-buildtrees as a bst main
option, which when passed will override the default or user defined
context for pull_buildtrees.

tests/completions/completions.py: Update for the added flag.

454dcaf1

by Tom Pollard at 2018-11-17T13:07:59Z

Don't pull artifact build trees by default.

The addition of cached build trees being included in element
artifacts has led to mostly redundant download overheads when
pulling from a remote artifact server. As such the default behaviour
of pull shouldn't fetch the build tree object if available.

element.py: extend relevant pull logic for specified subdir
consideration and ensure push logic does not lead to partial
artifact pushes. Change assumption that the buildtree can be
extracted if artifact is cached. __cached_buildtree() and
__pull_directories() helpers added.

_artifactcache/: artifactcache.py & cascache.py inclusion of
helper functions for subdir artifact checking & fetching, fetch
logic extended to only pull required artifact directories.
extract & checkout updated to handle full/partial operation.

tests/: addition of integration test pullbuildtrees.py,
buildtrees.py adapted cli options, testutils/artifactshare.py
has_artifact changed to return artifact digest on true condition.

0d309478

by Jürg Billeter at 2018-11-17T13:49:58Z

Merge branch 'tpollard/494' into 'master'

Don't pull artifact buildtrees by default

See merge request BuildStream/buildstream!786

27932739

by Benjamin Schubert at 2018-11-19T09:46:39Z

plugins/sources/pip.py: also look for python version named "python"

In some virtual environments, we might not have the binary with the
exact python version, which would lead the current pip plugin to
fail to find a working pip version.

This adds "python" at the start of the list of valid python versions

ea2de561

by Benjamin Schubert at 2018-11-19T10:19:24Z

Merge branch 'bschubert/fix-pip-python' into 'master'

plugins/sources/pip.py: also look for python version named "python"

Closes #758

See merge request BuildStream/buildstream!942

f23b6031