| ... |
... |
@@ -85,15 +85,9 @@ For more tips, please read `The seven rules of a great Git commit message`_. |
|
85
|
85
|
Committer access
|
|
86
|
86
|
----------------
|
|
87
|
87
|
|
|
88
|
|
-In the beginning of the project, we handed out commit access to anyone who had
|
|
89
|
|
-successfully landed a single patch to the code base. We then saw the policy in
|
|
90
|
|
-place over at the `Subversion`_ project and thought this was more sensible, so
|
|
91
|
|
-we decided to employ a very similar - although more light-weight - policy.
|
|
92
|
|
-
|
|
93
|
88
|
Committers in the BuildGrid project are those folks to whom the right to
|
|
94
|
89
|
directly commit changes to our version controlled resources has been granted.
|
|
95
|
|
-The project is meritocratic, which means (among other things) that project
|
|
96
|
|
-governance is handled by those who do the work. While every contribution is
|
|
|
90
|
+While every contribution is
|
|
97
|
91
|
valued regardless of its source, not every person who contributes code to the
|
|
98
|
92
|
project will earn commit access. The `COMMITTERS`_ file lists all committers.
|
|
99
|
93
|
|
| ... |
... |
@@ -129,7 +123,7 @@ not made major code contributions, but rather lots of small, clean fixes, each o |
|
129
|
123
|
which was an unambiguous improvement to the code. (Of course, this does not mean the
|
|
130
|
124
|
project needs a bunch of very trivial patches whose only purpose is to gain commit
|
|
131
|
125
|
access; knowing what's worth a patch post and what's not is part of showing good
|
|
132
|
|
-judgement :-) .)
|
|
|
126
|
+judgement.)
|
|
133
|
127
|
|
|
134
|
128
|
When submitting a merge request, please obtain a review from another committer
|
|
135
|
129
|
who is familiar with the area of the code base which the branch effects. Asking on
|
