[Notes] [Git][BuildStream/buildstream][bschubert/fix-atomic-move-git-repo] fixup! fixup! Fix os.rename in git source element to correctly handle error codes

[Benjamin Schubert <gitlab mg gitlab com>]

Title: GitLab

Benjamin Schubert pushed to branch bschubert/fix-atomic-move-git-repo at BuildStream / buildstream

Commits:

• b32d342f
  by Benjamin Schubert at 2018-11-07T14:39:43Z

  fixup! fixup! Fix os.rename in git source element to correctly handle error codes
  

1 changed file:

• tests/sources/git.py

Changes:

tests/sources/git.py

---

...	...	@@ -71,9 +71,9 @@ def test_git_mirror_atomic_move(tmpdir, type_, setup):
71	71	# Copy directory content
72	72	if type_ == "file":
73	73	with pytest.raises(SourceError):
74		- mirror._atomic_move_mirror(download_dir, mirror.url)
	74	+ mirror._atomic_move_mirror(str(download_dir), mirror.url)
75	75	else:
76		- mirror._atomic_move_mirror(download_dir, mirror.url)
	76	+ mirror._atomic_move_mirror(str(download_dir), mirror.url)
77	77
78	78	# Validate
79	79	if type_ == "non-empty-dir":

—
View it on GitLab.
You're receiving this email because of your account on gitlab.com. If you'd like to receive fewer emails, you can adjust your notification settings.