[Notes] [Git][BuildStream/buildstream][valentindavid/fix-recursive-strip-debug] 3 commits: BREAK: manual.yaml: don't set any default env vars



Title: GitLab

Valentin David pushed to branch valentindavid/fix-recursive-strip-debug at BuildStream / buildstream

Commits:

7 changed files:

Changes:

  • NEWS
    ... ... @@ -2,6 +2,12 @@
    2 2
     buildstream 1.3.1
    
    3 3
     =================
    
    4 4
     
    
    5
    +  o BREAKING CHANGE: The 'manual' element lost its default 'MAKEFLAGS' and 'V'
    
    6
    +    environment variables. There is already a 'make' element with the same
    
    7
    +    variables. Note that this is a breaking change, it will require users to
    
    8
    +    make changes to their .bst files if they are expecting these environment
    
    9
    +    variables to be set.
    
    10
    +
    
    5 11
       o Failed builds are included in the cache as well.
    
    6 12
         `bst checkout` will provide anything in `%{install-root}`.
    
    7 13
         A build including cached fails will cause any dependant elements
    

  • buildstream/_versions.py
    ... ... @@ -23,7 +23,7 @@
    23 23
     # This version is bumped whenever enhancements are made
    
    24 24
     # to the `project.conf` format or the core element format.
    
    25 25
     #
    
    26
    -BST_FORMAT_VERSION = 17
    
    26
    +BST_FORMAT_VERSION = 18
    
    27 27
     
    
    28 28
     
    
    29 29
     # The base BuildStream artifact version
    

  • buildstream/data/projectconfig.yaml
    ... ... @@ -62,6 +62,11 @@ variables:
    62 62
               -o -name '*.cmxs' -o -name '*.node' ')' \
    
    63 63
           -exec sh -ec \
    
    64 64
           'read -n4 hdr <"$1" # check for elf header
    
    65
    +       case "$1" in
    
    66
    +         %{install-root}%{debugdir}/*)
    
    67
    +           exit 0
    
    68
    +           ;;
    
    69
    +       esac
    
    65 70
            if [ "$hdr" != "$(printf \\x7fELF)" ]; then
    
    66 71
                exit 0
    
    67 72
            fi
    

  • buildstream/plugins/elements/manual.yaml
    1
    -# No variables added for the manual element by default, set
    
    2
    -# this if you plan to use make, and the sources cannot handle
    
    3
    -# parallelization.
    
    4
    -#
    
    5
    -# variables:
    
    6
    -#
    
    7
    -#   notparallel: True
    
    8
    -
    
    9 1
     # Manual build element does not provide any default
    
    10 2
     # build commands
    
    11 3
     config:
    
    ... ... @@ -28,14 +20,3 @@ config:
    28 20
       strip-commands:
    
    29 21
       - |
    
    30 22
         %{strip-binaries}
    31
    -
    
    32
    -# Use max-jobs CPUs for building and enable verbosity
    
    33
    -environment:
    
    34
    -  MAKEFLAGS: -j%{max-jobs}
    
    35
    -  V: 1
    
    36
    -
    
    37
    -# And dont consider MAKEFLAGS or V as something which may
    
    38
    -# affect build output.
    
    39
    -environment-nocache:
    
    40
    -- MAKEFLAGS
    
    41
    -- V

  • tests/cachekey/project/elements/build1.expected
    1
    -dd5e29baefb84f68eb4abac3a1befc332077ec4c97bb2572e57f3ca98ba46707
    \ No newline at end of file
    1
    +ce0ddf7126d45d14f5ec1a525337c39ec8ddbbe4b0ec2ef51bae777619ed39bb
    \ No newline at end of file

  • tests/cachekey/project/elements/build2.expected
    1
    -99d80454cce44645597c885800edf0bf254d1c3606d869f2ccdd5043ec7685cb
    \ No newline at end of file
    1
    +5e2a48dbeae43f6bab84071dbd02345a3aa32a473c189645ab26f3d5d6cfe547
    \ No newline at end of file

  • tests/cachekey/project/target.expected
    1
    -29a1252ec30dd6ae73c772381f0eb417e3874c75710d08be819f5715dcaa942b
    \ No newline at end of file
    1
    +125d9e7dcf4f49e5f80d85b7f144b43ed43186064afc2e596e57f26cce679cf5
    \ No newline at end of file



  • [Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]