[Notes] [Git][BuildStream/buildstream][tpollard/386] widget.py: Limit failure summary to currently failing elements

[Tom Pollard <gitlab mg gitlab com>]

Title: GitLab

Tom Pollard pushed to branch tpollard/386 at BuildStream / buildstream

Commits:

• 4808448e
  by Tom Pollard at 2018-07-26T14:03:18Z

  widget.py: Limit failure summary to currently failing elements
  
  Change widget.py print_summary() to only print the failure
  messages of elements in the Failure Summary that failed on the
  current try.
  

1 changed file:

• buildstream/_frontend/widget.py

Changes:

buildstream/_frontend/widget.py

---

...	...	@@ -522,12 +522,15 @@ class LogLine(Widget):
522	522	text += "\n\n"
523	523
524	524	if self._failure_messages:
525		- text += self.content_profile.fmt("Failure Summary\n", bold=True)
526	525	values = OrderedDict()
527	526
528	527	for element, messages in sorted(self._failure_messages.items(), key=lambda x: x[0].name):
529		- values[element.name] = ''.join(self._render(v) for v in messages)
530		- text += self._format_values(values, style_value=False)
	528	+ for queue in stream.queues:
	529	+ if any(el.name == element.name for el in queue.failed_elements):
	530	+ values[element.name] = ''.join(self._render(v) for v in messages)
	531	+ if values:
	532	+ text += self.content_profile.fmt("Failure Summary\n", bold=True)
	533	+ text += self._format_values(values, style_value=False)
531	534
532	535	text += self.content_profile.fmt("Pipeline Summary\n", bold=True)
533	536	values = OrderedDict()

—
View it on GitLab.
You're receiving this email because of your account on gitlab.com. If you'd like to receive fewer emails, you can adjust your notification settings.