[Notes] [Git][BuildStream/buildstream][issue-638-validate-all-files] 33

Phillip Smyth pushed to branch issue-638-validate-all-files at BuildStream / buildstream

Commits:

6fcfa452

by Jonathan Maw at 2018-12-03T13:21:05Z

_yamlcache.py: Use a project's junction name if present

This is required because if there are projects with the same name
loaded, that have elements in the same path, with the same contents,
they are considered the same, despite actually belonging to different
Projects.

This fixes buildstream issue #795

d0f9c724

by James Ennis at 2018-12-03T13:21:05Z

tests/loader/junctions.py: Test that we can build a junction that is referred differently, twice.

Test required to close #795 - We should be able to build a project which refers
to the same junction twice, but with two different filenames.

f7581026

by Jürg Billeter at 2018-12-03T16:27:03Z

Merge branch 'jonathan/fix-identical-element' into 'master'

_yamlcache.py: Use a project's junction name if present

Closes #795

See merge request BuildStream/buildstream!980

98c15463

by Tristan Van Berkom at 2018-12-05T07:04:56Z

_scheduler/queues: Don't call update state outside of error handling harness

Commit 3fa79d8da, part of an initiative for caching of the failed builds,
introduced a call to Element._update_state() after a job completes and before
entering the error handling harness intended for handling plugin raised errors.

Element._update_state() can result in triggering plugin code to
run, so this is incorrect, and causes raised errors to crash BuildStream
if they happen here.

After analyzing the code, it appears that this additional call to
Element._update_state() is unneeded, and was only added because the
state needs to be updated for a failure as well as a success.

Instead, we now have the BuildQueue call Element._assemble_done()
unconditionally, regardless of whether the build was successful
or not, which has the same effect and also reads better.

In addition, added a FIXME comment that we are still conditionally
updating the artifact cache size from BuildQueue.done() only
if the build is successful, which is incorrect because failed builds
also increase the local artifact cache size - to fix this we need
to communicate the added artifact size through Element._assemble()
regardless of whether the build succeeded or failed.

5d77b871

by Tristan Van Berkom at 2018-12-05T07:37:54Z

Merge branch 'tristan/refactor-queues-update-state' into 'master'

_scheduler/queues/queue.py: Don't call update state outside of error handling harness

See merge request BuildStream/buildstream!988

82513109

by Valentin David at 2018-12-05T09:47:52Z

git source plugin: Track git tags and save them to reproduce a minimum shallow repository

Instead of tag information being fetched which can change with time,
they are tracked and saved in the projects.refs/.bst. Then we re-tag
automatically the closest tag so that `git describe` works and is
reproducible.

This new feature is opt-in with the new `track-tags` configuration,
and must be used to fix modules which are broken by our new policy
of omitting the `.git/` repository when staging git sources.

This fixes issue #487

ec7b62c3

by Valentin David at 2018-12-05T09:50:15Z

NEWS: Add news about broken 'git describe' by default.

761e7570

by Tristan Van Berkom at 2018-12-05T10:23:49Z

Merge branch 'valentindavid/git_describe_tracking' into 'master'

Track of git tags and save them to reproduce minimum shallow repository

Closes #487

See merge request BuildStream/buildstream!906

2f5966bd

by Raoul Hidalgo Charman at 2018-12-05T10:37:10Z

platform.py: Add mapping of uname to OS-independent values

1ad35fcd