[Notes] [Git][BuildStream/buildstream][Qinusty/retries-should-fail] 2 commits: _message.py: Assert logfile in certain messages

[Qinusty <gitlab mg gitlab com>]

Title: GitLab

Qinusty pushed to branch Qinusty/retries-should-fail at BuildStream / buildstream

Commits:

• 23876ea8
  by Josh Smith at 2018-08-31T10:29:48Z

  _message.py: Assert logfile in certain messages
  
  This forces a Bug message to be displayed when a (START,SUCCESS,FAIL or
  SKIPPED) Message is instantiated without logfile being set.
  

• 8a82bd71
  by Josh Smith at 2018-08-31T10:29:55Z

  tests: Modify tests to ensure retry FAILURE
  

4 changed files:

• buildstream/_message.py
• tests/sources/deb.py
• tests/sources/tar.py
• tests/sources/zip.py

Changes:

buildstream/_message.py

---

...	...	@@ -78,3 +78,7 @@ class Message():
78	78	self.creation_time = datetime.datetime.now()
79	79	if message_type in (MessageType.SUCCESS, MessageType.FAIL):
80	80	assert elapsed is not None
	81	+ # logfile should always be associated with these messages
	82	+ if (self.scheduler and
	83	+ message_type in (MessageType.START, MessageType.SUCCESS, MessageType.FAIL, MessageType.SKIPPED)):
	84	+ assert self.logfile, "START, SUCCESS, FAIL messages require logfile to be provided."

tests/sources/deb.py

---

...	...	@@ -56,7 +56,7 @@ def test_fetch_bad_url(cli, tmpdir, datafiles):
56	56	result = cli.run(project=project, args=[
57	57	'fetch', 'target.bst'
58	58	])
59		- assert "Try #" in result.stderr
	59	+ assert "FAILURE Try #" in result.stderr
60	60	result.assert_main_error(ErrorDomain.STREAM, None)
61	61	result.assert_task_error(ErrorDomain.SOURCE, None)
62	62

tests/sources/tar.py

---

...	...	@@ -67,7 +67,7 @@ def test_fetch_bad_url(cli, tmpdir, datafiles):
67	67	result = cli.run(project=project, args=[
68	68	'fetch', 'target.bst'
69	69	])
70		- assert "Try #" in result.stderr
	70	+ assert "FAILURE Try #" in result.stderr
71	71	result.assert_main_error(ErrorDomain.STREAM, None)
72	72	result.assert_task_error(ErrorDomain.SOURCE, None)
73	73

tests/sources/zip.py

---

...	...	@@ -53,7 +53,7 @@ def test_fetch_bad_url(cli, tmpdir, datafiles):
53	53	result = cli.run(project=project, args=[
54	54	'fetch', 'target.bst'
55	55	])
56		- assert "Try #" in result.stderr
	56	+ assert "FAILURE Try #" in result.stderr
57	57	result.assert_main_error(ErrorDomain.STREAM, None)
58	58	result.assert_task_error(ErrorDomain.SOURCE, None)
59	59

—
View it on GitLab.
You're receiving this email because of your account on gitlab.com. If you'd like to receive fewer emails, you can adjust your notification settings.