[Notes] [Git][BuildStream/buildstream][master] _project.py: Adding FIXME comment to address #591 properly

[Tristan Van Berkom <gitlab mg gitlab com>]

Title: GitLab

Tristan Van Berkom pushed to branch master at BuildStream / buildstream

Commits:

• 775d3fca
  by Tristan Van Berkom at 2018-08-31T06:05:32Z

  _project.py: Adding FIXME comment to address #591 properly
  

1 changed file:

• buildstream/_project.py

Changes:

buildstream/_project.py

---

...	...	@@ -398,7 +398,13 @@ class Project():
398	398	"Project requested format version {}, but BuildStream {}.{} only supports up until format version {}"
399	399	.format(format_version, major, minor, BST_FORMAT_VERSION))
400	400
401		- # Check if project.conf contains name key field
	401	+ # FIXME:
	402	+ #
	403	+ # Performing this check manually in the absense
	404	+ # of proper support from _yaml.node_get(), this should
	405	+ # be removed in favor of a proper accessor function
	406	+ # from the _yaml module when #591 is fixed.
	407	+ #
402	408	if self._project_conf.get('name') is None:
403	409	raise LoadError(LoadErrorReason.INVALID_DATA,
404	410	"{}: project.conf does not contain expected key '{}'".format(projectfile, 'name'))

—
View it on GitLab.
You're receiving this email because of your account on gitlab.com. If you'd like to receive fewer emails, you can adjust your notification settings.