[Notes] [Git][BuildStream/buildstream][bst-1.2] 2 commits: _artifactcache/artifactcache.py: Write the cache_size file atomically

[Tristan Van Berkom <gitlab mg gitlab com>]

Title: GitLab

Tristan Van Berkom pushed to branch bst-1.2 at BuildStream / buildstream

Commits:

• 6d438496
  by Tristan Van Berkom at 2018-08-30T12:10:40Z

  _artifactcache/artifactcache.py: Write the cache_size file atomically
  
  This is causing issues while the size file is being read and written
  simultaneously.
  
  The proper fix will be to read/add/save the file atomically and that
  will require locking, but this fix is a good stop gap to existing crashes.
  

• b83f7fa1
  by Tristan Van Berkom at 2018-08-30T12:32:22Z

  Merge branch 'tristan/atomic-cache-size-file-1.2' into 'bst-1.2'
  
  _artifactcache/artifactcache.py: Write the cache_size file atomically
  
  See merge request BuildStream/buildstream!763

1 changed file:

• buildstream/_artifactcache/artifactcache.py

Changes:

buildstream/_artifactcache/artifactcache.py

---

...	...	@@ -571,7 +571,7 @@ class ArtifactCache():
571	571	def _write_cache_size(self, size):
572	572	assert isinstance(size, int)
573	573	size_file_path = os.path.join(self.context.artifactdir, CACHE_SIZE_FILE)
574		- with open(size_file_path, "w") as f:
	574	+ with utils.save_file_atomic(size_file_path, "w") as f:
575	575	f.write(str(size))
576	576
577	577	# _read_cache_size()

—
View it on GitLab.
You're receiving this email because of your account on gitlab.com. If you'd like to receive fewer emails, you can adjust your notification settings.