[Notes] [Git][BuildStream/buildstream][master] 2 commits: tests/plugins/filter.py: Don't run redundant tests

[Tristan Van Berkom <gitlab mg gitlab com>]

Title: GitLab

Tristan Van Berkom pushed to branch master at BuildStream / buildstream

Commits:

• d28e1353
  by Tristan Van Berkom at 2018-08-30T06:02:41Z

  tests/plugins/filter.py: Don't run redundant tests
  
  There is no reason that the filter element codepaths can behave
  differently depending on the Source implementation used in the test,
  as the Source implementation does not have any filter specific
  virtual methods.
  
  Removing the redundant tests and just performing these tests with the git source.
  

• e77ae07a
  by Tristan Van Berkom at 2018-08-30T06:36:41Z

  Merge branch 'tristan/reduce-filter-tests' into 'master'
  
  tests/plugins/filter.py: Don't run redundant tests
  
  See merge request BuildStream/buildstream!753

1 changed file:

• tests/plugins/filter.py

Changes:

tests/plugins/filter.py

---

...	...	@@ -174,9 +174,8 @@ def test_filter_workspace_reset(datafiles, cli, tmpdir):
174	174
175	175
176	176	@pytest.mark.datafiles(os.path.join(DATA_DIR, 'basic'))
177		-@pytest.mark.parametrize("kind", [(kind) for kind in ALL_REPO_KINDS if kind not in ("patch", "local")])
178		-def test_filter_track(datafiles, cli, tmpdir, kind):
179		- repo = create_repo(kind, str(tmpdir))
	177	+def test_filter_track(datafiles, cli, tmpdir):
	178	+ repo = create_repo('git', str(tmpdir))
180	179	ref = repo.create(os.path.join(str(datafiles), "files"))
181	180	elements_dir = os.path.join(str(tmpdir), "elements")
182	181	project = str(tmpdir)
...	...	@@ -228,9 +227,8 @@ def test_filter_track(datafiles, cli, tmpdir, kind):
228	227
229	228
230	229	@pytest.mark.datafiles(os.path.join(DATA_DIR, 'basic'))
231		-@pytest.mark.parametrize("kind", [(kind) for kind in ALL_REPO_KINDS if kind not in ("patch", "local")])
232		-def test_filter_track_excepted(datafiles, cli, tmpdir, kind):
233		- repo = create_repo(kind, str(tmpdir))
	230	+def test_filter_track_excepted(datafiles, cli, tmpdir):
	231	+ repo = create_repo('git', str(tmpdir))
234	232	ref = repo.create(os.path.join(str(datafiles), "files"))
235	233	elements_dir = os.path.join(str(tmpdir), "elements")
236	234	project = str(tmpdir)
...	...	@@ -282,9 +280,8 @@ def test_filter_track_excepted(datafiles, cli, tmpdir, kind):
282	280
283	281
284	282	@pytest.mark.datafiles(os.path.join(DATA_DIR, 'basic'))
285		-@pytest.mark.parametrize("kind", [(kind) for kind in ALL_REPO_KINDS if kind not in ("patch", "local")])
286		-def test_filter_track_multi_to_one(datafiles, cli, tmpdir, kind):
287		- repo = create_repo(kind, str(tmpdir))
	283	+def test_filter_track_multi_to_one(datafiles, cli, tmpdir):
	284	+ repo = create_repo('git', str(tmpdir))
288	285	ref = repo.create(os.path.join(str(datafiles), "files"))
289	286	elements_dir = os.path.join(str(tmpdir), "elements")
290	287	project = str(tmpdir)
...	...	@@ -336,9 +333,8 @@ def test_filter_track_multi_to_one(datafiles, cli, tmpdir, kind):
336	333
337	334
338	335	@pytest.mark.datafiles(os.path.join(DATA_DIR, 'basic'))
339		-@pytest.mark.parametrize("kind", [(kind) for kind in ALL_REPO_KINDS if kind not in ("patch", "local")])
340		-def test_filter_track_multi(datafiles, cli, tmpdir, kind):
341		- repo = create_repo(kind, str(tmpdir))
	336	+def test_filter_track_multi(datafiles, cli, tmpdir):
	337	+ repo = create_repo('git', str(tmpdir))
342	338	ref = repo.create(os.path.join(str(datafiles), "files"))
343	339	elements_dir = os.path.join(str(tmpdir), "elements")
344	340	project = str(tmpdir)
...	...	@@ -398,9 +394,8 @@ def test_filter_track_multi(datafiles, cli, tmpdir, kind):
398	394
399	395
400	396	@pytest.mark.datafiles(os.path.join(DATA_DIR, 'basic'))
401		-@pytest.mark.parametrize("kind", [(kind) for kind in ALL_REPO_KINDS if kind not in ("patch", "local")])
402		-def test_filter_track_multi_exclude(datafiles, cli, tmpdir, kind):
403		- repo = create_repo(kind, str(tmpdir))
	397	+def test_filter_track_multi_exclude(datafiles, cli, tmpdir):
	398	+ repo = create_repo('git', str(tmpdir))
404	399	ref = repo.create(os.path.join(str(datafiles), "files"))
405	400	elements_dir = os.path.join(str(tmpdir), "elements")
406	401	project = str(tmpdir)

—
View it on GitLab.
You're receiving this email because of your account on gitlab.com. If you'd like to receive fewer emails, you can adjust your notification settings.