[Notes] [Git][BuildStream/buildstream][master] 3 commits: Log not-found

c146dde5
by Benjamin Schubert at 2018-08-29T16:00:24Z
```
Log not-found objects in the cache as SKIPPED
```

19e87afb

by Benjamin Schubert at 2018-08-29T16:01:12Z

Add tests that not-found objects in cache are shown as SKIPPED

9cc5817f

by Qinusty at 2018-08-29T16:25:48Z

Merge branch 'bschubert/log-missed-cache' into 'master'

Log not-found objects in the cache as SKIPPED

See merge request BuildStream/buildstream!729

@@ -249,6 +249,13 @@ class CASCache(ArtifactCache):
                  if e.code() != grpc.StatusCode.NOT_FOUND:
                      raise ArtifactError("Failed to pull artifact {}: {}".format(
                          element._get_brief_display_key(), e)) from e
 +                else:
 +                    self.context.message(Message(
 +                        None,
 +                        MessageType.SKIPPED,
 +                        "Remote ({}) does not have {} cached".format(
 +                            remote.spec.url, element._get_brief_display_key())
 +                    ))
          return False

@@ -338,3 +338,22 @@ def test_pull_missing_blob(cli, tmpdir, datafiles):
          # Assert that no artifacts were pulled
          assert len(result.get_pulled_elements()) == 0
++
++
 +@pytest.mark.datafiles(DATA_DIR)
 +def test_pull_missing_notifies_user(caplog, cli, tmpdir, datafiles):
 +    project = os.path.join(datafiles.dirname, datafiles.basename)
 +    caplog.set_level(1)
++
 +    with create_artifact_share(os.path.join(str(tmpdir), 'artifactshare')) as share:
++
 +        cli.configure({
 +            'artifacts': {'url': share.repo}
 +        })
 +        result = cli.run(project=project, args=['build', 'target.bst'])
++
 +        result.assert_success()
 +        assert not result.get_pulled_elements(), \
 +            "No elements should have been pulled since the cache was empty"
++
 +        assert "SKIPPED Remote ({}) does not have".format(share.repo) in result.stderr

[Notes] [Git][BuildStream/buildstream][master] 3 commits: Log not-found objects in the cache as SKIPPED